RVCX3RXDUIL35VU24QGH6WEWSCX5UYBOLLZFIGXWM2NRWMV7D7ZAC
Hi! Thanks for the patch. There are three issues in its current version:
pijul key prove finchie@ssh.pijul.com
. This is a temporary feature, I’m working on something much better to sign patches.eprintln!
, which can cause broken pipes errors from Pijul when piped into a command. If you use writeln!(stderr, …)
instead, it will work.pijul record
, you can delete some of the stuff in there (there are a few exceptions). If you get a chance, you can pijul record --amend
and remove the hunks introducing just one blank line.Also, you can then just push to this channel again. Patches in discussions aren’t actually applied to anything, they’re just “loose”, so your two version won’t conflict.
UAXGGNAZFUQX2XTVNITFZG54E2W5V4RKJUGEKN7WD2HDLVT5QG6QC
Hello again! I have completely re-done the patch while trying to follow your advice, please let me know what you think!
There should now be output when the user performs any one of the following actions:
clone
, init
etc)pijul add
a directory without --recursive
pijul add
(this one could probably be improved to include recursively added items)Working on this patch also gave me some ideas (that may be suited better to a new discussion):
pijul reset
, should the items reset be listed? Maybe if the output was condensed as to not spam the terminal?pijul reset
? Should this behaviour be gated behind a flag?--recursive
be the default for pijul add
?The more I use pijul, the more fun it is! Thank you so much for your work on this wonderful project :)
Yay! I finally found the time to review and apply this change. Thanks a lot!
I’m still keeping this discussion open to keep working on your other proposed changes.
Based on the discussion in #315, this patch implements some basic feedback for commands such as
init
,reset
,log
andadd
.As this is my first contribution to the Pijul repository, I am very unfamiliar with the codebase. Any feedback would be greatly appreciated!