#741 Allow the user to configure a pager and editor in the config file
Opened by jcdickinson on December 5, 2022 Reviewing
jcdickinson added a change on December 5, 2022
Make bin_diff_test compile again by multun, created on September 9, 2022
DSLBAEDTSUX3IPCX3BNHDLPIKLHIZABP6XL37MDSMNREASVOPZSAC main
jcdickinson added a change on December 5, 2022
Fix zombie in libpijul tests by finchie, created on September 26, 2022
DHMXWWMSWJT5EJK4PNCG46ETUJ4CMBWBQXIHCKRCNUUH2ULEFQDAC main
jcdickinson added a change on December 5, 2022
ABWPZVMX726ZPICWKH6NUKNJUPOTB7OJL2AOIUCAC7VTNXBTRUCQC jcdickinson added a change on December 5, 2022
EA4Z7VO73QB25PB5RMO7GIGQRWVYEZBZ2MT33K4C76JWXP2XWF5AC jcdickinson added a change on December 5, 2022
2ANUAQL3O7PNAJ77RRDDDSUJXSHVLCJCCKQ4QVLFUEZY3QVAZHLAC pmeunier on February 28, 2023
Hi! Nice patch, and great feature suggestion. Just one minor comment, you’re using std::os::unix::prelude::OsStrExt, which doesn’t exist on Windows. Would you mind amending your patch to fix that?
pmeunier added tag Reviewing on February 28, 2023
jcdickinson added a change on February 28, 2023
Allow the user to configure a pager and editor from their config created on December 5, 2022
ITS3PCMQQCGF7L5ZDBMAM57MWC4VDJYARNORO7GP2UBNIRDX4UWQC jcdickinson added a change on February 28, 2023
Allow the user to configure a pager and editor from their config created on December 5, 2022
VL24Z3GGFFLGB2RBEO53LQN4QFFTCJ343XPNBQSDX7E44FUVZ2LAC jcdickinson on February 28, 2023
Thanks! I have switched it to string instead
jcdickinson on March 1, 2023
Not sure if I need to ping you @pmeunier :)
pmeunier on March 1, 2023
Wasn’t needed (but doesn’t hurt), I did receive the notification and even downloaded your patch. Thanks! I hope to review it soon.
pmeunier on March 1, 2023
I’ll probably release another version of Pijul soon-ish, since the new Nest might need a few improvements from the CLI side.
It might be useful to allow Pijul to use a pager and editor that are not
$PAGERand$EDITOR, respectively. For example, it would be simple to build a TUI that specifically deals with the pijul editor file formats (e.g. a commit interface).I also updated the flake as the version of Rust in there wasn’t working on my machine (due to the experimental backtrace feature).