While trying to expand the Diffuse tool to utilize Pijul, I need to get a list of files affected by a change. In Git, the log command has an option to include file names. Can this option be added to pijul log?

This would actually be an excellent introduction to Pijul’s datastructures, for anyone who wants to do it. @joyously, if you’re interested in adding that, I can provide as much support as you need.

Hey, first contribution here :)

I made a really naive implementation and I am not sure if this is the correct way to implement this. Also we probably want to add some information about what kind of changes is being applied per file (addition, deletion etc), and maybe the associated diff ?.

Here is the current ouput format:

Change TQU67HU5IACHDG72A4H6FTFU4VWYXUNZQRDE3XENHTB43KHYIXSQC
Author: Okno (oknozor) <paul.delafosse@protonmail.com>
Date: Tue, 6 Feb 2024 09:22:09 +0000

    Add hunk paths to log ouput

   Changes:
       - pijul/src/commands/log.rs

Change X642QQQTS4X2DENIZT7PGJN2M2FYVFMGGANXSZHJ7LBP6442Z6IAC
Author: G2Wck5FShFeTVqwzUwUXgGzmv6U7RhiXprPScpBxxyWw
Date: Mon, 8 Jan 2024 10:10:31 +0000

    Run record hooks from the repository root

   Changes:
       - pijul/src/config.rs
       - pijul/src/commands/record.rs

I was clicking on code in the change page for review, but it doesn’t do anything…

For let show_paths = cmd.files; it seems to ignore that there could be a --hash-only flag.

For the actual output, I think there are currently two output options (plaintext and json). I don’t know where this is handled though.

It is confusing to use the label Changes: for the files, since the first line is Change: <hash>. I suggest Files: or Paths:.

If the info is readily available, marking the files with their status similar to the diff -s would be even better.

Hello @ joyously, I updated the change so --hash-only and --files arg now conflicts. I changed the label which is now Files.

If the info is readily available, marking the files with their status similar to the diff -s would be even better.

Regarding the output format I am not sure I want to do this yet, I think pijil diffs and log output should have the same kind of output (at least for the diff part). I started another discussion here pijul/872. Maybe it would be better to address this in a separate patch.

Welcome here @oknozor. Excellent job! Just one thing, it seems you didn’t run cargo fmt before recording your change, would you mind doing that and amending again?

Hey @pmeunier, thank you. I did not ran cargo fmt on purpose, when running it I get a very large diff. Not sure why. Here is my current toolchain, rustc 1.75.0, rustfmt 1.7.0-stable.

One thing you can do is cargo fmt then pijul rec pijul/src/commands/log.rs --amend ….

Or you can do C-c C-c C-f from emacs in your file.

Thank you, here you go :)