The sound distributed version control system

#84 commands/pushpull: show change description and don't unwrap write*!()

Closed on November 17, 2020
cole-h on November 16, 2020

It’s nice to see the entire change’s message (both title and description) for more context into why the change was made.

make_changelist() returns a Result, so we should propagate the error rather than unwrap()ping it.

cole-h added a change on November 16, 2020
cole-h added a change on November 16, 2020
This change could not be retrieved at the moment
pmeunier on November 17, 2020

Thanks, I just applied the change for descriptions. However, I don’t know what the “standard” way of writing to Vec<u8> is in Rust, since that never returns Err:

cole-h on November 17, 2020

Alright, I understand. And I guess a panic would result in more information than bubbling up an error from writing to a Vec. Probably no need for that change, then.

cole-h closed this discussion on November 17, 2020