The sound distributed version control system

#918 Refactor repository and channel handling in CLI commands

Opened by dblsaiko on March 29, 2024
dblsaiko on March 29, 2024

There’s a lot of unnecessary code duplication here, this tries to pull that apart a little bit.

dblsaiko added a change on March 29, 2024
GKSVBEUW7Q2M4QPKPHOUPGP36AMXMJVGX7KCSNYXEFQZOURGBSMQC
dblsaiko added a change on March 29, 2024
UBTOH654TM6FU5ZZERAQZPW2PMJ7QVDHPMV6O236GB4Y6G2QGMFAC
dblsaiko added a change on March 29, 2024
LKLEIPWEEQBJWJKAJLWII2TFUNUOVY75HHDNOJU5MZR54YTMGINAC
dblsaiko added a change on March 29, 2024
YV5PVUXVFHZVG5D4R4IHYBXUL4GV3YSXST4JO23PJRGBLFKOGR7AC
dblsaiko added a change on March 29, 2024
4PX6WLAFTZZY6O57NEAPWZG25NR2TZ4KESKPRMS3G3QVKL7L6LNQC
dblsaiko added a change on March 29, 2024
U45JUYYGEUYEIF7WNERHP4DUSQ5FUKZIJYF57YH4MPBISNOGC6PAC
dblsaiko added a change on March 29, 2024
JA4POQALQZSM4U6XII4VE56J3LNM57MCFMAKFKYJCBNY6OCYRZ7AC
dblsaiko added a change on March 29, 2024
6YOM7WMHRWVWXNWDT6A3CCQR2VVRR6TAPTM7L4WX5HD2546TPJKQC
dblsaiko added a change on March 29, 2024
YMCFR3BMW6OIR67YH5I7KFOFGA7PAKPLQFBXQJOYZ5N37NLSF3WAC
dblsaiko added a change on March 29, 2024
KSHG4L44N3RSAEY7UTKMGIWDDR2L5GZDH7MVHM7SUD6DC2BBGYUQC
dblsaiko added a change on March 29, 2024
42MFQSMSKVWFKWHQY2X6AK7AQH3UJUWCL6FPQNGTF4VJKTZBS5SAC
dblsaiko added a change on March 29, 2024
SGSQ3I453KVH4BDWL7QMWEOZNJLKUR75BJIJK3BJT6MJT2ZMQL4QC
dblsaiko added a change on March 29, 2024
K34KD3FTTP3GD7TBEMLPOA2ZCBDTAMSW53RDIN4WRGZD2AAMLEMAC
dblsaiko added a change on March 29, 2024
G2WWGRN2DSO7GGNMKYOGGMDYG42OQQPI76J45RFH27FMBOXUQL2AC
dblsaiko added a change on March 29, 2024
3FNRS6MWYYKFO2IX5WVUFIXKPSTRKQEHMPCYZVMNXGN33KWV2XNAC
dblsaiko added a change on March 29, 2024
7MFC7MVAFNDP4ANWQN25ASBGT4DLLRJ3GKAT4DS56EBKSMUDSDEQC
dblsaiko added a change on March 29, 2024
OWJL5HO72US47LCBHUZVH6ONALVEADWMFAMXK5RMDHLXSCCFSFQAC
dblsaiko added a change on March 29, 2024
EEF5WHUIPNJAD3OQ7XOY4VSDOMRSPMLZ7EWGDRMADGGAY2YYB6OQC
dblsaiko added a change on March 29, 2024
67GIAQEUQG3KUD7YTYNUWK33BKWPFVNT4YPQMZ3RCALOZ2STDLRQC
dblsaiko added a change on March 29, 2024
2VSREFNWAKMHSDRFRRU3JVN2ADKCJ3IEZW2LSJOXW3RDQKNILBRAC
dblsaiko added a change on March 29, 2024
DDEUZMXQRYVBGTJWKZY6W4UFSDCLB6JV7VX32AOTY3ZPD7OS6P6QC
dblsaiko added a change on March 29, 2024
Q5PNWJ5WICBXCVODOZBNZLADNNCBPQPMN32SJKQUVEP4ZJIBPZ3QC
dblsaiko added a change on March 29, 2024
J34NV3PLRHR6SG52G6F33SGPLKWJBJBSSY5HIYO445YAG4R6M6ZQC
dblsaiko added a change on March 29, 2024
ORZKNFDB7JJGZNMJQ5W4SIYNU3JOGNY7R3B5G53IC72CSLMHKVBQC
dblsaiko added a change on March 29, 2024
S4ZDDHTLHU6XCUOCGWZ3TUZGSB7Q5PIECZ7JKEPZEW4VR2XQ4XXAC
dblsaiko added a change on March 29, 2024
O5IM6YXGV2ERHMAGFNX4NZPEH6QRZZQXXTQFJ75JYQY7QSDN3VEQC
dblsaiko on March 29, 2024

look at #903 and #909 first, I accidentally got some dependencies for the changes in those in here. oops

tankf33der on March 30, 2024

I can not pull all patches for testing :( Nest is tricky beast.

I do not see last one, for example.

$ pijul pull --from-channel :918 -a
Downloading changes  [==================================================] 21/21 [00:00:00]  
Applying changes     [==================================================] 21/21 [00:00:00]     
Error: while retrieving EEF5WHUIPNJAD3OQ7XOY4VSDOMRSPMLZ7EWGDRMADGGAY2YYB6OQC: No such file or directory (os error 2)
$ pijul log --hash-only | grep -E "^O5IM"
# empty
dblsaiko on March 30, 2024

Oh, maybe it was a bad idea to remove the changes this depends on but isn’t really part of this changeset from the discussion. Let me add those back.

dblsaiko added a change on March 30, 2024
42MFQSMSKVWFKWHQY2X6AK7AQH3UJUWCL6FPQNGTF4VJKTZBS5SAC
dblsaiko added a change on March 30, 2024
OWJL5HO72US47LCBHUZVH6ONALVEADWMFAMXK5RMDHLXSCCFSFQAC
dblsaiko added a change on March 30, 2024
EEF5WHUIPNJAD3OQ7XOY4VSDOMRSPMLZ7EWGDRMADGGAY2YYB6OQC
dblsaiko added a change on March 30, 2024
67GIAQEUQG3KUD7YTYNUWK33BKWPFVNT4YPQMZ3RCALOZ2STDLRQC
dblsaiko on March 30, 2024

Now you should be able to pull this.

tankf33der on March 30, 2024

pulled. compiled. minimal test bundle passed.

dblsaiko added a change on March 30, 2024
3WADZG36NTZ7RPXZIKYKQ77YOVIPXY277UQ2FD5MSOJRKUYKVXJQC
dblsaiko on March 30, 2024

Currently getting rid of the extra dependencies.

dblsaiko added a change on March 30, 2024
OSWFAKWMXL7N3ZHL74TKXEUDGSBDUHBNFAPI25LUB6RBTQKFC6EQC
dblsaiko added a change on March 30, 2024
Q7LEDPIWGV5LJE3LYXLT74RBKOHEHLL4EJY6N4FDR3B6ZPX3V2UAC
dblsaiko on March 30, 2024

There we go, that should be it.

AfoHT on July 25, 2024

Looks really nice! :)

Had to unrecord 2VSREFNW (and 67GIAQE which was pulled in by 2V...) to return to a conflict free repo, no other issues.

Builds and runs, can’t say I’ve tested more than just everyday pijul usage with these changes applied.

Well done!

dblsaiko on July 25, 2024

Ah right, I forgot to remove 2VSREFNW, that’s old. Thanks!