G4ROOMN2ST7MBHZKD3OXR7KJPMROVP2T2RQ3UTPACTD66FQXIY7AC KV66KF6K34PNCWOR7E74DDY32QP4M27BW3X4SCCB2LSDICTV657QC Would you please squash your two changes together? I don’t think there needs to be a separate “format” change :) Thanks!
Nice work! I have some suggestions, though:
change is not for changing the channel, it’s to show the details of a change.help uses the latter style, so we could conform to that; alternatively, the help message can be customized. #[clap(name = "init", about = "Initialize an empty pijul repository")]
Init(Init),
can also be achieved by
/// Initialize an empty pijul repository
#[clap(name = "init")]
Init(Init),
Which do you prefer?
re your third point: I much prefer using doc comments with structopt. Looks a lot cleaner, IMO.
SXEYMYF7P4RZMZ46WPL4IZUTSQ2ATBWYZX7QNVMS3SGOYXYOHAGQC M3VTIZCPE7CMJXRENE7J3DYEXA4KILMNYLPMPCDRCWXTJ34JKSCQC G734WNM64AR5BLAZMN5MDPKSFTYXTUQR6MAGB32NRBC5FXFRWSJAC IMCZFTIJ245E3JBOHAY3FMEZCGTL4VNIF26WAKJSZMQXZJ4NK3LAC HYRH4E55TIRBB3RFFR432METJPNVBSPL6DJVHXE5XGFGZAGBACDAC 5HF7C67M4DZMYTCIG32XEQQ662AHQMIHTHUK7TAVSO52XLMFBZPAC KQJN63AIKMPAIAV5ROB6ODX6FRSHFCP2AM56QLG3ZPRXFDC45OZAC UZZQ3VIA4YVL7C6P22LBPWWPB4BKH6VQLYKVHGQ3XRFISKM52TRQC OAXTXEAFX6YLO2XX6L4VMCVW4YZSIXWL6QOZKQCDSL7M44QNX66AC AN7IDX26RK33ZXASXLJMD4GTFWHCTHMJ6Y5C4ROCPIH33VUT2EYQC HZPYFG5RCT3SHO7R5MM37IID7X7Q2NXFWLOISKDZGMPSJD6Y74QAC 3S4DR77ZU3XFGGDE6XSCUK6TN76IXNOQIKQSLDBM7KUHNILWHS3QC 2GNO2PLCZ3BM5RRRSPLGVWEWHOOTVT4VKFBNNQMUKOKF3VXL3ZFQC ZWPPIJXFKEL3RP2MEYGB3BPTE73GYRW6FSRZDQKFBJFOK4JBNQ4AC VN6L65VRWLKTIXY7XD7OOZBMNKNSIEJG6PJUX5NKKYVYGVG4DFTAC BAUL3WR2ACY2HCJIM7K6HJOJ3UXDJISGLMDCSPH3WMPGJPL5AR4QC CVAT6LN3SYYLREM6NLM4IUPFI5EX3BL6MRPFTY24ROJFSB3J5OOQC 76PCXGML77EZWTRI5E6KHLVRAFTJ2AB5YRN5EKOYNAPKTWY2KCGAC 2KURKIFC6P62HW2TCV3N7IMCAARI7UBHYR5M3RIGWYLZU3X763AQC GUNVHCG3GTVBGGODDAHVZ5W552BS2IQEOKMAFGFNRTCZR6EPYWJAC IXGIROWKSRQM2E5Q7OVB7ZHGY5I5NSHI2WOOPLEHRKACNE3QH2JAC T3FHN6EYB34LW7UV53G6XXVOVEC4336QGQFQ6OXS4DZPQMXL4B3AC IXWN5CYPMGNBRYKS2MMRV6DVAUQFSYUB2MXZLEMPF6RSEG5AFA6QC Sorry about that, I actually only wanted to push one change. Why is it that pijul thinks I need to push the initial change of the repository as a dependency; surely the channel already has it?
This happens when you’re on a different channel than the channel you’re pushing to. If I make a dummy change while on another branch, branch, and run pijul push cole-h@nest.pijul.com:pijul/pijul --to-channel :96, it will show me every single change from that branch (since branch != main). However, if I run pijul push cole-h@nest.pijul.com:pijul/pijul --to-channel main:96, this doesn’t happen.
The only reason I know about this is because I was debugging something related to pushing earlier and noticed that there’s a regex with two captures (CHANNEL, in pushpull.rs): ([^:]*) and (:(.*)) – with :96, it would capture "" and "96", but with main:96, it would capture "main" and "96".
Ok. I prefer the doc comment version. I will make a change to that. Also I am gonna make sure to change the change subcommand help. But how to squash the changes. Any help is greatly appreciated
To squash the changes you basically just unrec the “Format the code” change (KV66KF6K34PNCWOR7E74DDY32QP4M27BW3X4SCCB2LSDICTV657QC) – this will remove the change from your history, but keep the actual change’s contents – and then pijul rec --amend the “Add help on subcommands” change (G4ROOMN2ST7MBHZKD3OXR7KJPMROVP2T2RQ3UTPACTD66FQXIY7AC).
Thank you very much
JWTT77WJIGJOZVLLZBADUDZIMSEAR7ZLYLWISOXFJJCNWJGJPWQQC This is so cool, thanks! One more step towards good documentation. I promise I’ll add many more steps when there are no more fires to put out.
Also, for the future (in case you didn’t know) – to display a more in-depth description when calling pijul help [subcmd], you just need to add a blank doc comment line after the short description, and then start the long description on the next line. https://docs.rs/structopt/0.3.20/structopt/#long_help-and—help
I just updated the “reference” section in the manual to be automatically generated from this. Not everything is automated yet, since the manual still depends on the “mdbook-katex” crate, and I didn’t have the time to make a nix expression for it yet.
Here’s a Nix expression you can use for mdbook-katex (used in conjunction with callPackage):
{ rustPlatform
, fetchCrate
}:
rustPlatform.buildRustPackage rec {
pname = "mdbook-katex";
version = "0.2.4";
src = fetchCrate {
inherit pname version;
sha256 = "sha256-7cvFYNpYGyE4QQzCq67Kiv3rajOCiihjb9g+H4jJMM8=";
};
cargoSha256 = "sha256-3YaPvyhrQrjfWkazEa/v2KsaBAUKt2urNeXq2L+pOI0=";
}
What kind of trouble did you have with recompiling Pijul from its flake? If you had an issue, there’s a non-zero chance other people might have some, and I’d love to help fix / avoid that.
No serious trouble, but my deployment scripts are non-trivial (I wrote my own NixOps).
When someone runs
pijul --help, he/she only gets the list of subcommands and no help. I have put some about statements to all subcommands to add some help