pijul nest
guest [sign in]

Fixing a logical error (again) in del

[?]
May 2, 2021, 9:48 AM
77TAHKV4VZ4SWZZBEND24Y6BL7JLRXPYO33CA5FRH53WXEWSWS4QC

Dependencies

  • [2] JIQOPUYH Fixing a logical error causing a panic in some very rare cases
  • [3] Z33OHFPA Version bump
  • [4] DEKK3RUI Fixing a bug when splitting unsized pages
  • [5] W2MIZD5B Single file databases + CRC for the root pages (checking the other pages makes everything very slow)
  • [6] PUOGOIJ3 Debugging, impls and version bump
  • [7] L5CVF6UJ Debugging
  • [8] GPP7KJSF Version bump
  • [9] 7T2CCH3P Fixing a segfault (wrong offset in page_unsized::del)
  • [10] 2ZRCQBXP Version bump
  • [11] DASFQGOR Debugging
  • [12] OP6SVMOD Resetting history
  • [13] J7LJZBME Setting reverse cursor to last by default
  • [14] T73WR2BX Cleaner RC increments for keys and values containing references + more comments in `del`

Change contents

  • replacement in sanakirja-core/src/btree/del.rs at line 505
    [2.66][2.66:243]()
    // modified in the last step is the one on the left of
    // the entry, move back one step before inserting the
    // split key/value.
    [2.66]
    [2.243]
    // modified in the last step is the one on the right
    // of the current entry, move right one step before
    // inserting the split key/value.
  • edit in sanakirja-core/src/btree/del.rs at line 511
    [2.365]
    [2.365]
    //
    // We need to do this because the split key/value is
    // inserted immediately *before* the current cursor
    // position, which is incorrect if the split key/value
    // comes from the right-hand side of the current
    // cursor position.
  • replacement in sanakirja-core/src/btree/del.rs at line 519
    [4.6666][4.6666:6718]()
    P::move_prev(&mut curs.cursor);
    [4.6666]
    [4.6718]
    P::move_next(&mut curs.cursor);
  • replacement in sanakirja-core/Cargo.toml at line 3
    [4.70812][3.0:18]()
    version = "1.2.6"
    [4.70812]
    [4.70847]
    version = "1.2.7"