pijul/sanakirja - Change AOX2XQISHGWNNAFBYRN44Q6AWG7H5DPBK5YMFHK42HQNZ2TMHEJQC

Actually, with the correct functions, Unsized pages are always slower than Sized pages (especially for writing)

Created by pmeunier on February 3, 2021

AOX2XQISHGWNNAFBYRN44Q6AWG7H5DPBK5YMFHK42HQNZ2TMHEJQC

Dependencies

In channels

main

Change contents

Deletion in sanakirja-core/src/btree/page_unsized.rs at line 112 [3.2014]

B:BD[3.4814] → [3.4814:4964]

        debug!(
            "update_left_child: {:?} {:?} {:?}",
            page,
            mutable,
            header(page.as_page())
        );

Deletion in sanakirja-core/src/btree/page_unsized.rs at line 117 [3.2014]
B:BD[3.5165] → [3.5165:5204]
```
            debug!("new = {:?}", new);
```
Deletion in sanakirja-core/src/btree/page_unsized.rs at line 142 [3.2014]
∅:D[4.1340] → [3.6078:6121]
B:BD[3.6078] → [3.6078:6121]
```
        debug!("del: {:?} {:?}", page, l);
```
Deletion in sanakirja-core/src/btree/page_unsized.rs at line 397 [3.2014]
B:BD[3.15321] → [3.15321:15396]
```
            debug!("set_cursor, {:?} lookup = {:?}", page.offset, lookup);
```
Replacement in sanakirja-core/src/btree/page_unsized.rs at line 588 [3.2014]
B:BD[3.21429] → [3.21429:21467]
```
            debug!("clone: {:?}", s);
```
[3.21429]
[3.21467]
```
            debug!("clone: {:?} {:?}", s, s.len());
```
Deletion in sanakirja-core/src/btree/page_unsized.rs at line 594 [3.2014]
B:BD[3.21704] → [3.21704:21784]
```
                    debug!("ptr = {:?}", core::slice::from_raw_parts(ptr, 24));
```

Insertion in sanakirja-core/src/btree/page_unsized/put.rs at line 57 [3.27023]

[3.28946]


        {
            let hdr = header(new.0.as_page());
            assert_eq!(hdr.n() as u64 * 16, hdr.left_page() & 0xfff);
        }

Replacement in sanakirja-core/src/btree/page_unsized/put.rs at line 108 [3.27023]

B:BD[3.30106] → [3.30106:30168]

            page.data.as_ptr().add(HDR) as *const LeafOffset,

[3.30106]

[3.30168]

            page.data.as_ptr().add(HDR) as *const L::Offset,

Insertion in sanakirja-core/src/btree/page_unsized/put.rs at line 115 [3.27023]

[3.30307]


        if uu == u {
            if let Some((k1, v1)) = k1v1 {
                alloc::<K, V, L>(current_page, k0, v0, 0, l0, &mut n);
                total += alloc_size(k0, v0) + L::extra_size();
                alloc::<K, V, L>(current_page, k1, v1, 0, r0, &mut n);
                total += alloc_size(k1, v1) + L::extra_size();
            } else {
                alloc::<K, V, L>(current_page, k0, v0, l0, r0, &mut n);
                total += alloc_size(k0, v0) + L::extra_size();
            }
        }

Insertion in sanakirja-core/src/btree/page_unsized/put.rs at line 129 [3.27023]

[3.30357]

        debug!("{:?} {:?} {:?} {:?}", r, off, is_left, total);
        assert_ne!(off, 0);

Replacement in sanakirja-core/src/btree/page_unsized/put.rs at line 152 [3.27023]

B:BD[3.31208] → [3.31208:31343]

B:BD[3.31343] → [4.2685:2748]

∅:D[4.2748] → [3.31414:31485]

B:BD[3.31414] → [3.31414:31485]

B:BD[3.31485] → [4.2749:2812]

∅:D[4.2812] → [3.31556:31649]

B:BD[3.31556] → [3.31556:31649]

B:BD[3.31649] → [4.2813:2876]

∅:D[4.2876] → [3.31720:31734]

B:BD[3.31720] → [3.31720:31734]

        if uu == u {
            if let Some((k1, v1)) = k1v1 {
                alloc::<K, V, L>(current_page, k0, v0, 0, l0, &mut n);
                total += alloc_size(k0, v0) + L::extra_size();
                alloc::<K, V, L>(current_page, k1, v1, 0, r0, &mut n);
                total += alloc_size(k1, v1) + L::extra_size();
            } else {
                alloc::<K, V, L>(current_page, k0, v0, l0, r0, &mut n);
                total += alloc_size(k0, v0) + L::extra_size();
            }

[3.31208]

[3.31734]

    }
    if u == s.len() {
        if let Some((k1, v1)) = k1v1 {
            alloc::<K, V, L>(current_page, k0, v0, 0, l0, &mut n);
            alloc::<K, V, L>(current_page, k1, v1, 0, r0, &mut n);
        } else {
            alloc::<K, V, L>(current_page, k0, v0, l0, r0, &mut n);

Insertion in sanakirja-core/src/btree/page_unsized/put.rs at line 160 [3.27023]

[3.31744]

    }
    {
        let hdr = header(left.0.as_page());
        assert_eq!(hdr.n() as u64 * 16, hdr.left_page() & 0xfff);
    }
    {
        let hdr = header(right.0.as_page());
        assert_eq!(hdr.n() as u64 * 16, hdr.left_page() & 0xfff);

Insertion in sanakirja-core/src/btree/page_unsized/put.rs at line 169 [3.27023]
[3.31750]
[3.31750]

Replacement in sanakirja-core/src/btree/page_unsized/alloc.rs at line 65 [3.33822]

B:BD[4.3236] → [4.3236:3317]

        (HDR as usize) + (hdr.n() as usize) * 2 + 2 + size < hdr.data() as usize

[4.3236]

[3.36212]

        debug!(
            "can_alloc, leaf: {:?} {:?} {:?} {:?}",
            HDR,
            hdr.n() * 2,
            hdr.data(),
            size
        );
        (HDR as usize) + (hdr.n() as usize) * 2 + 2 + size <= hdr.data() as usize

Replacement in sanakirja-core/src/btree/page_unsized/alloc.rs at line 76 [3.33822]
B:BD[4.3390] → [4.3390:3443]
```
            "can_compact, internal: {:?} {:?} {:?}",
```
[4.3390]
[4.3443]
```
            "can_compact, leaf: {:?} {:?} {:?}",
```

Insertion in sanakirja-core/src/btree/page_unsized/alloc.rs at line 81 [3.33822]

[4.3525]

        assert_eq!(hdr.n() as u64 * 16, hdr.left_page() & 0xfff); // Just for the test with (u64, u64).

Insertion in sanakirja-core/src/btree/page_unsized/alloc.rs at line 113 [3.33822]
[4.4008]
[4.4008]
```
        assert!(HDR + hdr.n() as usize * 2 + 2 + size < data as usize);
```

Replacement in sanakirja-core/src/btree/page_unsized/alloc.rs at line 180 [3.33822]

∅:D[4.4260] → [3.39861:39942]

B:BD[3.39861] → [3.39861:39942]

        (HDR as usize) + (hdr.n() as usize) * 8 + 8 + size < hdr.data() as usize

[4.4260]

[3.39942]

        debug!(
            "can_alloc, internal: {:?} {:?} {:?} {:?}",
            HDR,
            hdr.n() * 8,
            hdr.data(),
            size
        );
        (HDR as usize) + (hdr.n() as usize) * 8 + 8 + size <= hdr.data() as usize

Insertion in sanakirja-core/src/btree/page_unsized/alloc.rs at line 236 [3.33822]
[4.4826]
[4.4826]
```
        assert!(HDR + hdr.n() as usize * 8 + 8 + size <= data as usize);
```
Insertion in sanakirja-core/src/btree/page_unsized/alloc.rs at line 284 [3.33822]
[3.43162]
[3.43162]
```
        debug!("internal page {:?} {:?}", page, hdr.n());
```
Deletion in sanakirja-core/src/btree/page.rs at line 431 [7.8623]
B:BD[5.9111] → [6.634:709]
```
            debug!("set_cursor, {:?} lookup = {:?}", page.offset, lookup);
```

Replacement in sanakirja/src/tests.rs at line 333 [8.11]

B:BD[4.12041] → [4.12041:12090]

        put(&mut txn, &mut db, &i, &i).unwrap();

[4.12041]

[4.12090]

        assert!(put(&mut txn, &mut db, &i, &i).unwrap());

Replacement in sanakirja/src/tests.rs at line 345 [8.11]
B:BD[4.12418] → [4.12418:12437]
```
    let mut n = 0;
```
[4.12418]
[4.12437]
```
    let mut err = 0;
```
Replacement in sanakirja/src/tests.rs at line 349 [8.11]
B:BD[4.12538] → [4.12538:12557]
```
            n += 1
```
[4.12538]
[4.12557]
```
            err += 1
```

Replacement in sanakirja/src/tests.rs at line 352 [8.11]

B:BD[4.12573] → [4.12573:12595]

    assert_eq!(n, 0);

[4.12573]

[2.412]

    assert_eq!(err, 0);
    println!("sized length = {:?}", txn.length >> 12);

Deletion in sanakirja/src/tests.rs at line 357 [8.11]
B:BD[4.12738] → [2.414:441]
```
    let n = 10_000_000u64;
```
Replacement in sanakirja/src/tests.rs at line 359 [8.11]
∅:D[2.489] → [4.12782:12831]
B:BD[4.12782] → [4.12782:12831]
```
        put(&mut txn, &mut db, &i, &i).unwrap();
```
[2.489]
[4.12831]
```
        assert!(put(&mut txn, &mut db, &i, &i).unwrap());
```
Insertion in sanakirja/src/tests.rs at line 368 [8.11]
[2.760]
[4.12890]
```
    println!("unsized length = {:?}", txn.length >> 12);
```
Replacement in sanakirja/src/environment/muttxn.rs at line 16 [7.80166]
B:BD[7.80367] → [7.80367:80384]
```
    length: u64,
```
[7.80367]
[9.1290]
```
    pub(crate) length: u64,
```

Actually, with the correct functions, Unsized pages are always slower than Sized pages (especially for writing)

Dependencies

In channels

Change contents

Deletion in sanakirja-core/src/btree/page_unsized.rs at line 112 [3.2014]

Deletion in sanakirja-core/src/btree/page_unsized.rs at line 117 [3.2014]

Deletion in sanakirja-core/src/btree/page_unsized.rs at line 142 [3.2014]

Deletion in sanakirja-core/src/btree/page_unsized.rs at line 397 [3.2014]

Replacement in sanakirja-core/src/btree/page_unsized.rs at line 588 [3.2014]

Deletion in sanakirja-core/src/btree/page_unsized.rs at line 594 [3.2014]

Insertion in sanakirja-core/src/btree/page_unsized/put.rs at line 57 [3.27023]

Replacement in sanakirja-core/src/btree/page_unsized/put.rs at line 108 [3.27023]

Insertion in sanakirja-core/src/btree/page_unsized/put.rs at line 115 [3.27023]

Insertion in sanakirja-core/src/btree/page_unsized/put.rs at line 129 [3.27023]

Replacement in sanakirja-core/src/btree/page_unsized/put.rs at line 152 [3.27023]

Insertion in sanakirja-core/src/btree/page_unsized/put.rs at line 160 [3.27023]

Insertion in sanakirja-core/src/btree/page_unsized/put.rs at line 169 [3.27023]

Replacement in sanakirja-core/src/btree/page_unsized/alloc.rs at line 65 [3.33822]

Replacement in sanakirja-core/src/btree/page_unsized/alloc.rs at line 76 [3.33822]

Insertion in sanakirja-core/src/btree/page_unsized/alloc.rs at line 81 [3.33822]

Insertion in sanakirja-core/src/btree/page_unsized/alloc.rs at line 113 [3.33822]

Replacement in sanakirja-core/src/btree/page_unsized/alloc.rs at line 180 [3.33822]

Insertion in sanakirja-core/src/btree/page_unsized/alloc.rs at line 236 [3.33822]

Insertion in sanakirja-core/src/btree/page_unsized/alloc.rs at line 284 [3.33822]

Deletion in sanakirja-core/src/btree/page.rs at line 431 [7.8623]

Replacement in sanakirja/src/tests.rs at line 333 [8.11]

Replacement in sanakirja/src/tests.rs at line 345 [8.11]

Replacement in sanakirja/src/tests.rs at line 349 [8.11]

Replacement in sanakirja/src/tests.rs at line 352 [8.11]

Deletion in sanakirja/src/tests.rs at line 357 [8.11]

Replacement in sanakirja/src/tests.rs at line 359 [8.11]

Insertion in sanakirja/src/tests.rs at line 368 [8.11]

Replacement in sanakirja/src/environment/muttxn.rs at line 16 [7.80166]