pijul/sanakirja - Change WAKPPBKONQUA3G7HWH52ZKYG5PLZEAG3HFAYGIYLA4NVEPRZUQEAC

Fixing a double-free of roots after deletions (the root was freed both by handle_merge and by update_root)

Created by pmeunier on February 9, 2021

WAKPPBKONQUA3G7HWH52ZKYG5PLZEAG3HFAYGIYLA4NVEPRZUQEAC

Dependencies

In channels

main

Change contents

Insertion in sanakirja-core/src/btree/del.rs at line 393 [5.52511]

[3.37905]

[4.2311]

    debug!(
        "handle_merge for level {:?}, freed {:?}",
        cursor.pointer(),
        freed
    );

Replacement in sanakirja-core/src/btree/del.rs at line 399 [5.52511]
B:BD[4.2361] → [6.446:490]
```
        free[cursor.pointer() + 1] = freed;
```
[4.2361]
[5.62825]
```
        free[cursor.pointer()] = freed;
```
Replacement in sanakirja-core/src/btree/del.rs at line 543 [5.52511]
B:BD[3.38675] → [3.38675:38716]
B:BD[3.38716] → [6.491:535]
∅:D[6.535] → [3.38716:38748]
B:BD[3.38716] → [3.38716:38748]
B:BD[3.38748] → [2.10591:10625]
∅:D[2.10625] → [3.38775:38785]
B:BD[3.38775] → [3.38775:38785]
```
        Put::Ok(Ok { page, freed }) => {
            debug!("ok freed {:?}", freed);
            free[0][0] = freed;
            db.db = page.0.offset
        }
```
[3.38675]
[3.38785]
```
        Put::Ok(Ok { page, .. }) => db.db = page.0.offset,
```
Replacement in sanakirja-core/src/btree/del.rs at line 549 [5.52511]
B:BD[3.38891] → [3.38891:38910]
```
            freed,
```
[3.38891]
[3.38910]
```
            ..
```
Deletion in sanakirja-core/src/btree/del.rs at line 551 [5.52511]
B:BD[3.38925] → [6.536:583]
∅:D[6.583] → [3.38925:38957]
B:BD[3.38925] → [3.38925:38957]
```
            debug!("split freed {:?}", freed);
            free[0][0] = freed;
```