Clippy + rustfmt

darleybarreto

Jul 25, 2021, 6:34 PM

L7S3YSSMT6JCK4A7MCXZDMDEFBP7XJITHFRDMDKJ5L2RDVHI4AHAC

Dependencies

• [2] GKNZUJV6 Removing unecessary unsafe blocks
• [3] K6L5F26W Fixing sequential test.
• [4] SZHL3TSD Fixing tests
• [5] IB4L4N5M Fixing the lifetimes for `Seekable`
• [6] HEFGMMUM Start oxidizing 1/N
• [7] IH334Q5A Reboot

Change contents

• edit in src/lib.rs at line 583
  [3.11201]→[3.11201:11261](∅→∅)
  −

  − let buffer_ptr = (&mut self.in_buff).as_mut_ptr();
• replacement in src/lib.rs at line 589
  [3.11482]→[2.81:151](∅→∅)
  − self.in_buff.copy_within(offset..offset+to_read,pos);
  [3.11482]

  [3.11639]
  + self.in_buff.copy_within(offset..offset + to_read, pos);
• replacement in src/lib.rs at line 592
  [3.476]→[2.152:225](∅→∅)
  − handle.read(&mut self.in_buff[offset..offset+to_read])?;
  [3.476]

  [3.11896]
  + handle.read(&mut self.in_buff[offset..offset + to_read])?;
• replacement in src/lib.rs at line 602
  [3.4766]→[3.4766:4779](∅→∅)
  −
  [3.4766]

  [3.4779]
  +
• replacement in src/lib.rs at line 637
  [3.5125]→[3.5125:5180](∅→∅)
  − return Err(Error::ZSTD(dstream_init));
  [3.5125]

  [3.5180]
  + Err(Error::ZSTD(dstream_init));
• replacement in src/lib.rs at line 688
  [2.416]→[2.416:454](∅→∅),[2.454]→[3.14725:15019](∅→∅),[3.14725]→[3.14725:15019](∅→∅),[3.15019]→[2.455:505](∅→∅)
  − (ZSTD_outBuffer {

  − dst: self.out_buff.as_mut_ptr() as *mut c_void,

  − size: cmp::min(

  − SEEKABLE_BUFF_SIZE,

  − (offset - self.decompressed_offset) as size_t,

  − ),

  − pos: 0,

  − }, (&self.out_buff).as_ref())
  [2.416]

  [3.15041]
  + (

  + ZSTD_outBuffer {

  + dst: self.out_buff.as_mut_ptr() as *mut c_void,

  + size: cmp::min(

  + SEEKABLE_BUFF_SIZE,

  + (offset - self.decompressed_offset) as size_t,

  + ),

  + pos: 0,

  + },

  + (&self.out_buff).as_ref(),

  + )
• replacement in src/lib.rs at line 700
  [3.15066]→[2.506:544](∅→∅),[2.544]→[3.5472:5534](∅→∅),[3.15103]→[3.5472:5534](∅→∅),[3.5534]→[3.15152:15263](∅→∅),[3.15152]→[3.15152:15263](∅→∅),[3.15263]→[2.545:575](∅→∅)
  − (ZSTD_outBuffer {

  − dst: out.as_mut_ptr() as *mut c_void,

  − size: len,

  − pos: (self.decompressed_offset - offset) as size_t,

  − }, &*out)
  [3.15066]

  [3.15285]
  + (

  + ZSTD_outBuffer {

  + dst: out.as_mut_ptr() as *mut c_void,

  + size: len,

  + pos: (self.decompressed_offset - offset) as size_t,

  + },

  + &*out,

  + )
• replacement in src/lib.rs at line 722
  [3.15672]→[2.576:687](∅→∅)
  − self.xxh_state.write(&slice_tmp[prev_out_pos..prev_out_pos+(out_tmp.pos - prev_out_pos)]);
  [3.15672]

  [3.16075]
  + self.xxh_state.write(

  + &slice_tmp[prev_out_pos..prev_out_pos + (out_tmp.pos - prev_out_pos)],

  + );
• replacement in src/lib.rs at line 827
  [3.6764]→[3.6764:6825](∅→∅)
  − - self.seek_table.entries[frame_index].d_offset;
  [3.6764]

  [3.6825]
  + - self.seek_table.entries[frame_index].d_offset;
• replacement in src/lib.rs at line 907
  [3.21211]→[3.6999:7004](∅→∅)
  −
  [3.21211]

  [3.21212]
  +
• replacement in src/lib.rs at line 947
  [3.22109]→[2.688:792](∅→∅)
  − pub fn stwrite32(&mut self, output: &mut [u8], value: u32, offset: u32, pos: &mut usize) -> usize {
  [3.22109]

  [3.7264]
  + pub fn stwrite32(

  + &mut self,

  + output: &mut [u8],

  + value: u32,

  + offset: u32,

  + pos: &mut usize,

  + ) -> usize {
• replacement in src/lib.rs at line 960
  [3.260252]→[2.831:911](∅→∅)
  − output[*pos..*pos+len_write].copy_from_slice(&value.to_ne_bytes());
  [3.260252]

  [3.22818]
  + output[*pos..*pos + len_write].copy_from_slice(&value.to_ne_bytes());
• replacement in src/lib.rs at line 1044
  [3.8081]→[2.1570:1586](∅→∅)
  − pos
  [3.8081]

  [3.24878]
  + pos,
• replacement in src/lib.rs at line 1165
  [2.3519]→[2.3519:3605](∅→∅)
  − println!("{:?} {:?}", size, s.get_frame_decompressed_offset(frame).unwrap());
  [2.3519]

  [2.3605]
  + println!(

  + "{:?} {:?}",

  + size,

  + s.get_frame_decompressed_offset(frame).unwrap()

  + );