tetov/pijul-srv-lite - Change V77QIO7XMPRA6RRUR36ZXI5KEEPROE6BYJZB23SFDVLQRV6EOGHAC

refactor: splits out url parsing into funcs, adds tests

Created by tetov on March 1, 2026

V77QIO7XMPRA6RRUR36ZXI5KEEPROE6BYJZB23SFDVLQRV6EOGHAC

Dependencies

In channels

main

Change contents

Deletion in src/main.rs at line 44 [4.49]

B:BD[3.1217] → [3.1217:1305]

B:BD[3.1305] → [3.1305:1375]

B:BD[3.1375] → [3.1375:1376]

B:BD[3.1376] → [3.1376:1498]

B:BD[3.1498] → [3.1498:1504]


fn handle_request(url: &str, repo_path: &Path) -> Response<std::io::Cursor<Vec<u8>>> {
    let (path, query_str) = url.split_once('?').unwrap_or((url, ""));
    let path = path.trim_start_matches('/');
    if !path.starts_with(".pijul") {
        return not_found("not found");
    }

Replacement in src/main.rs at line 45 [4.49]

B:BD[3.1505] → [3.1505:1556]

    let query: HashMap<String, String> = query_str

[3.1505]

[3.1556]

fn parse_query(query_str: &str) -> HashMap<String, String> {
    query_str

Replacement in src/main.rs at line 55 [4.49]

B:BD[3.1814] → [3.1814:1834]

        .collect();

[3.1814]

[3.1834]

        .collect()
}
fn parse_url(url: &str) -> (String, HashMap<String, String>) {
    let (path, query_str) = url.split_once('?').unwrap_or((url, ""));
    let path = path.trim_start_matches('/');
    (path.into(), parse_query(query_str))
}
fn handle_request(url: &str, repo_path: &Path) -> Response<std::io::Cursor<Vec<u8>>> {
    let (path, query) = parse_url(url);
    if !path.starts_with(".pijul") {
        return not_found("not found");
    }

Replacement in src/main.rs at line 81 [4.49]

B:BD[2.64] → [2.64:118]

∅:D[2.118] → [3.2129:2196]

B:BD[3.2129] → [3.2129:2196]

        && let Some(channel) = query.get("channel") {
            return serve_changelist(repo_path, channel);
        }

[2.64]

[3.2202]

        && let Some(channel) = query.get("channel")
    {
        return serve_changelist(repo_path, channel);
    }

Replacement in src/main.rs at line 205 [4.49]

B:BD[2.149] → [2.149:214]

∅:D[2.214] → [3.5861:5956]

B:BD[3.5861] → [3.5861:5956]

                && let Ok(byte) = u8::from_str_radix(&hex, 16) {
                    result.push(byte as char);
                    continue;
                }

[2.149]

[3.5970]

                && let Ok(byte) = u8::from_str_radix(&hex, 16)
            {
                result.push(byte as char);
                continue;
            }

Insertion in src/main.rs at line 252 [4.49]

[3.7316]


#[cfg(test)]
mod tests {
    use super::*;
    #[test]
    fn test_parse_query() {
        let mut params: HashMap<String, String> = HashMap::new();
        params.insert("param1".into(), "hello".into());
        params.insert("param2".into(), "world".into());
        assert_eq!(parse_query("param1=hello&param2=world"), params);
        params.insert("param3".into(), "".into());
        assert_eq!(parse_query("param1=hello&param2=world&param3"), params);
        params.insert("param4".into(), "next param".into());
        assert_eq!(
            parse_query("param1=hello&param2=world&param3&param4=next%20param"),
            params
        );
    }
    #[test]
    fn test_parse_url() {
        let mut params: HashMap<String, String> = HashMap::new();
        assert_eq!(parse_url("/.pijul"), (".pijul".into(), params.clone()));
        params.insert("a_param".into(), "a value".into());
        assert_eq!(parse_url("/.pijul?a_param=a%20value"), (".pijul".into(), params.clone()));
    }
    #[test]
    fn test_percent_decode() {
        assert_eq!(percent_decode("Hello%20World%21"), "Hello World!");
        assert_eq!(
            percent_decode("~%20is%20where%20the%20%3C3%20is"),
            "~ is where the <3 is"
        );
        // ascii extended not allowed
        // assert_eq!(percent_decode("My%20pijul%20channel%20is%20named%20%22G%C3%B6ta+kanal%22"),"My pijul channel is named \"Göta kanal\"");
    }
}