voroskoi/exercism - Change FFZCCZ7QTJ2U6MX6BV5AUM7ARF56Z4PGXXGEMGPTJUQSWQCS24OAC

luhn: return error instead of panicing, use range in for loop with proper second initialization

Created by voroskoi on January 16, 2021

FFZCCZ7QTJ2U6MX6BV5AUM7ARF56Z4PGXXGEMGPTJUQSWQCS24OAC

Dependencies

In channels

main

Change contents

File addition: luhn_test.go (-rw-r--r--)

[3.7]

package luhn
import "testing"
func TestValid(t *testing.T) {
	for _, test := range testCases {
		if ok, _ := Valid(test.input); ok != test.ok {
			t.Fatalf("Valid(%s): %s\n\t Expected: %t\n\t Got: %t", test.input, test.description, test.ok, ok)
		}
	}
}
func BenchmarkValid(b *testing.B) {
	for i := 0; i < b.N; i++ {
		Valid("2323 2005 7766 3554")
	}
}

Replacement in go/luhn/luhn.go at line 5 [3.18]
B:BD[3.98] → [3.98:105]
```
	"log"
```
[3.98]
[3.105]
```
	"fmt"
```
Replacement in go/luhn/luhn.go at line 12 [3.18]
B:BD[3.225] → [3.225:257]
```
func Valid(input string) bool {
```
[3.225]
[3.257]
```
func Valid(input string) (bool, error) {
```
Replacement in go/luhn/luhn.go at line 15 [3.18]
B:BD[3.323] → [3.323:338]
```
		return false
```
[3.323]
[3.417]
```
		return false, fmt.Errorf("input is too short: %q", input)
```

Replacement in go/luhn/luhn.go at line 18 [3.18]

B:BD[3.494] → [3.494:551]

	var second bool
	for i := len(input) - 1; i >= 0; i-- {

[3.494]

[4.0]

	second := len(input)%2 == 0
	for i := range input {

Replacement in go/luhn/luhn.go at line 21 [3.18]

B:BD[4.40] → [2.0:16]

			return false

[4.40]

[4.52]

			return false, fmt.Errorf("input must be all digits, got: %q", input)

Replacement in go/luhn/luhn.go at line 25 [3.18]

B:BD[3.616] → [3.616:679]

			log.Panicf("error converting %q to int: %s", input[i], err)

[3.616]

[3.679]

			return false, fmt.Errorf("error converting %q to int %s", input[i], err)

Replacement in go/luhn/luhn.go at line 39 [3.18]
B:BD[3.830] → [2.17:37]
```
	return sum%10 == 0
```
[3.830]
[3.847]
```
	return sum%10 == 0, nil
```

luhn: return error instead of panicing, use range in for loop with proper second initialization

Dependencies

In channels

Change contents

File addition: luhn_test.go (-rw-r--r--)

Replacement in go/luhn/luhn.go at line 5 [3.18]

Replacement in go/luhn/luhn.go at line 12 [3.18]

Replacement in go/luhn/luhn.go at line 15 [3.18]

Replacement in go/luhn/luhn.go at line 18 [3.18]

Replacement in go/luhn/luhn.go at line 21 [3.18]

Replacement in go/luhn/luhn.go at line 25 [3.18]

Replacement in go/luhn/luhn.go at line 39 [3.18]