voroskoi/exercism - Change KCDFZVFMCAOSWY3C2AJARBC6EIWCBI76LPMASJYGVEV4M5TSB5JQC

scale_generator: cosmetics

Created by voroskoi on December 19, 2020

KCDFZVFMCAOSWY3C2AJARBC6EIWCBI76LPMASJYGVEV4M5TSB5JQC

Dependencies

In channels

main

Change contents

Insertion in go/scale-generator/scale_generator.go at line 12 [3.40]
[3.155]
[3.155]
```
// using slice here is faster than array
```

Replacement in go/scale-generator/scale_generator.go at line 14 [3.40]

B:BD[3.161] → [3.161:337]

	sharpScale = []string{"A", "A#", "B", "C", "C#", "D", "D#", "E", "F", "F#", "G", "G#"}
	flatScale  = []string{"A", "Bb", "B", "C", "Db", "D", "Eb", "E", "F", "Gb", "G", "Ab"}

[3.161]

[3.575]

	sharpScale  = []string{"A", "A#", "B", "C", "C#", "D", "D#", "E", "F", "F#", "G", "G#"}
	flatScale   = []string{"A", "Bb", "B", "C", "Db", "D", "Eb", "E", "F", "Gb", "G", "Ab"}
	selectScale = map[string][]string{"a": sharpScale, "C": sharpScale, "G": sharpScale, "D": sharpScale, "A": sharpScale, "E": sharpScale, "B": sharpScale, "F#": sharpScale, "e": sharpScale, "b": sharpScale, "f#": sharpScale, "c#": sharpScale, "g#": sharpScale, "d#": sharpScale, "F": flatScale, "Bb": flatScale, "Eb": flatScale, "Ab": flatScale, "Db": flatScale, "Gb": flatScale, "d": flatScale, "g": flatScale, "c": flatScale, "f": flatScale, "bb": flatScale, "eb": flatScale}

Deletion in go/scale-generator/scale_generator.go at line 18 [3.40]

B:BD[3.577] → [3.577:578]

B:BD[3.578] → [2.0:480]


var selectScale = map[string][]string{"a": sharpScale, "C": sharpScale, "G": sharpScale, "D": sharpScale, "A": sharpScale, "E": sharpScale, "B": sharpScale, "F#": sharpScale, "e": sharpScale, "b": sharpScale, "f#": sharpScale, "c#": sharpScale, "g#": sharpScale, "d#": sharpScale, "F": flatScale, "Bb": flatScale, "Eb": flatScale, "Ab": flatScale, "Db": flatScale, "Gb": flatScale, "d": flatScale, "g": flatScale, "c": flatScale, "f": flatScale, "bb": flatScale, "eb": flatScale}

Replacement in go/scale-generator/scale_generator.go at line 34 [3.40]

B:BD[2.900] → [2.900:984]

			for k := 0; k < len(interval)-1; k++ {
				switch {
				case interval[k] == 'm':

[2.900]

[2.984]

			for i := 0; i < len(interval)-1; i++ {
				switch { // using switch is faster than map
				case interval[i] == 'm':

Replacement in go/scale-generator/scale_generator.go at line 38 [3.40]
B:BD[2.998] → [2.998:1027]
```
				case interval[k] == 'M':
```
[2.998]
[2.1027]
```
				case interval[i] == 'M':
```
Replacement in go/scale-generator/scale_generator.go at line 40 [3.40]
B:BD[2.1041] → [2.1041:1070]
```
				case interval[k] == 'A':
```
[2.1041]
[2.1070]
```
				case interval[i] == 'A':
```