Enhance test readability by renaming couple variables

Dependencies

• [2] 2DRAL6A2 Refactoring evaluate_test
• [3] G5KXCVIL tictactoe: initial import
• [4] HSJSKGY7 Refactoring evaluate functions
• [5] TYELLGSA Rename checkDiag to checkDiagLR and add checkDiagRL. Add more tests

Change contents

• replacement in snippets/tictactoe/tictactoe.go at line 15
  [3.198]→[3.198:252](∅→∅)
  − Empty rune = '_'

  − Pl1 rune = 'x'

  − Pl2 rune = 'o'
  [3.198]

  [3.252]
  + Emp rune = '_'

  + P_1 rune = 'x'

  + P_2 rune = 'o'
• replacement in snippets/tictactoe/evaluate_test.go at line 16
  [3.2277]→[2.69:1267](∅→∅)
  − {"Nothing", tictactoe.Board{{tictactoe.Pl1, tictactoe.Pl1, tictactoe.Pl2}, {tictactoe.Empty, tictactoe.Empty, tictactoe.Empty}, {tictactoe.Empty, tictactoe.Empty, tictactoe.Empty}}, 0},

  − {"tictactoe.Pl1 row", tictactoe.Board{{tictactoe.Pl1, tictactoe.Pl1, tictactoe.Pl1}, {tictactoe.Empty, tictactoe.Empty, tictactoe.Empty}, {tictactoe.Empty, tictactoe.Empty, tictactoe.Empty}}, 10},

  − {"tictactoe.Pl2 col", tictactoe.Board{{tictactoe.Pl2, tictactoe.Empty, tictactoe.Empty}, {tictactoe.Pl2, tictactoe.Empty, tictactoe.Empty}, {tictactoe.Pl2, tictactoe.Empty, tictactoe.Empty}}, -10},

  − {"tictactoe.Pl1 last col", tictactoe.Board{{tictactoe.Empty, tictactoe.Empty, tictactoe.Pl1}, {tictactoe.Empty, tictactoe.Empty, tictactoe.Pl1}, {tictactoe.Empty, tictactoe.Empty, tictactoe.Pl1}}, 10},

  − {"tictactoe.Pl2 diag lr", tictactoe.Board{{tictactoe.Pl2, tictactoe.Empty, tictactoe.Empty}, {tictactoe.Empty, tictactoe.Pl2, tictactoe.Empty}, {tictactoe.Empty, tictactoe.Empty, tictactoe.Pl2}}, -10},

  − {"tictactoe.Pl1 diag rl", tictactoe.Board{{tictactoe.Empty, tictactoe.Empty, tictactoe.Pl1}, {tictactoe.Empty, tictactoe.Pl1, tictactoe.Empty}, {tictactoe.Pl1, tictactoe.Empty, tictactoe.Empty}}, 10},
  [3.2277]

  [3.2638]
  + {"Nothing", tictactoe.Board{

  + {tictactoe.P_1, tictactoe.P_1, tictactoe.P_2},

  + {tictactoe.Emp, tictactoe.Emp, tictactoe.Emp},

  + {tictactoe.Emp, tictactoe.Emp, tictactoe.Emp}},

  + 0},

  + {"tictactoe.P_1 row", tictactoe.Board{

  + {tictactoe.P_1, tictactoe.P_1, tictactoe.P_1},

  + {tictactoe.Emp, tictactoe.Emp, tictactoe.Emp},

  + {tictactoe.Emp, tictactoe.Emp, tictactoe.Emp}},

  + 10},

  + {"tictactoe.P_2 col", tictactoe.Board{

  + {tictactoe.P_2, tictactoe.Emp, tictactoe.Emp},

  + {tictactoe.P_2, tictactoe.Emp, tictactoe.Emp},

  + {tictactoe.P_2, tictactoe.Emp, tictactoe.Emp}},

  + -10},

  + {"tictactoe.P_1 last col", tictactoe.Board{

  + {tictactoe.Emp, tictactoe.Emp, tictactoe.P_1},

  + {tictactoe.Emp, tictactoe.Emp, tictactoe.P_1},

  + {tictactoe.Emp, tictactoe.Emp, tictactoe.P_1}},

  + 10},

  + {"tictactoe.P_2 diag lr", tictactoe.Board{

  + {tictactoe.P_2, tictactoe.Emp, tictactoe.Emp},

  + {tictactoe.Emp, tictactoe.P_2, tictactoe.Emp},

  + {tictactoe.Emp, tictactoe.Emp, tictactoe.P_2}},

  + -10},

  + {"tictactoe.P_1 diag rl", tictactoe.Board{

  + {tictactoe.Emp, tictactoe.Emp, tictactoe.P_1},

  + {tictactoe.Emp, tictactoe.P_1, tictactoe.Emp},

  + {tictactoe.P_1, tictactoe.Emp, tictactoe.Emp}},

  + 10},
• replacement in snippets/tictactoe/evaluate.go at line 7
  [3.228]→[3.228:282](∅→∅)
  − if b.checkRow(row, col, WinSize, Pl1) == WinSize {
  [3.228]

  [3.2979]
  + // Skip empty!

  + // Skip when remaining length < winsize, so no way to win

  + if b.checkRow(row, col, WinSize, P_1) == WinSize {
• replacement in snippets/tictactoe/evaluate.go at line 11
  [3.2994]→[3.283:344](∅→∅)
  − } else if b.checkRow(row, col, WinSize, Pl2) == WinSize {
  [3.2994]

  [3.3060]
  + } else if b.checkRow(row, col, WinSize, P_2) == WinSize {
• replacement in snippets/tictactoe/evaluate.go at line 14
  [3.3080]→[3.345:399](∅→∅)
  − if b.checkCol(row, col, WinSize, Pl1) == WinSize {
  [3.3080]

  [3.3139]
  + if b.checkCol(row, col, WinSize, P_1) == WinSize {
• replacement in snippets/tictactoe/evaluate.go at line 16
  [3.3154]→[3.400:461](∅→∅)
  − } else if b.checkCol(row, col, WinSize, Pl2) == WinSize {
  [3.3154]

  [3.3220]
  + } else if b.checkCol(row, col, WinSize, P_2) == WinSize {
• replacement in snippets/tictactoe/evaluate.go at line 19
  [3.3240]→[3.462:519](∅→∅)
  − if b.checkDiagLR(row, col, WinSize, Pl1) == WinSize {
  [3.3240]

  [3.446]
  + if b.checkDiagLR(row, col, WinSize, P_1) == WinSize {
• replacement in snippets/tictactoe/evaluate.go at line 21
  [3.461]→[3.520:584](∅→∅)
  − } else if b.checkDiagLR(row, col, WinSize, Pl2) == WinSize {
  [3.461]

  [3.530]
  + } else if b.checkDiagLR(row, col, WinSize, P_2) == WinSize {
• replacement in snippets/tictactoe/evaluate.go at line 24
  [3.550]→[3.585:642](∅→∅)
  − if b.checkDiagRL(row, col, WinSize, Pl1) == WinSize {
  [3.550]

  [3.3300]
  + if b.checkDiagRL(row, col, WinSize, P_1) == WinSize {
• replacement in snippets/tictactoe/evaluate.go at line 26
  [3.3315]→[3.643:707](∅→∅)
  − } else if b.checkDiagRL(row, col, WinSize, Pl2) == WinSize {
  [3.3315]

  [3.3382]
  + } else if b.checkDiagRL(row, col, WinSize, P_2) == WinSize {