voroskoi/pistike - Change 4B26P4BBEABLLGDY4IQS7QK6OW67EROEIQMHS36D2Z4TWDEK5Z2AC

Rework search init() code, try incremental eval, but does not work

Created by voroskoi on January 29, 2023

4B26P4BBEABLLGDY4IQS7QK6OW67EROEIQMHS36D2Z4TWDEK5Z2AC

Dependencies

In channels

main

Change contents

Replacement in src/uci.zig at line 16 [4.32]
B:BD[3.242] → [3.242:277]
```
    var search = Search.init(&gs);
```
[3.242]
[3.277]
```
    var search: ?Search = null;
```

Replacement in src/uci.zig at line 41 [4.32]

B:BD[3.1036] → [3.1036:1123]

            @atomicStore(bool, &search.stop, true, std.builtin.AtomicOrder.Unordered);

[3.1036]

[3.1123]

            @atomicStore(bool, &search.?.stop, true, std.builtin.AtomicOrder.Unordered);

Replacement in src/uci.zig at line 45 [4.32]

B:BD[3.1187] → [3.1187:1269]

        if (std.mem.eql(u8, input, "isready")) _ = try stdout.write("readyok\n");

[3.1187]

[3.1269]

        if (std.mem.eql(u8, input, "isready")) {
            if (search == null) {
                search = Search.init(&gs) catch {
                    std.log.err("Unable to initialize Search interface, quitting...", .{});
                    std.os.exit(1);
                };
            }
            _ = try stdout.write("readyok\n");
        }

Insertion in src/uci.zig at line 75 [4.32]

[3.1922]

                if (search == null) {
                    std.log.err("search is not initialized, call isready first!", .{});
                    continue;
                }

Replacement in src/uci.zig at line 82 [4.32]

B:BD[3.2048] → [3.2048:2089]

                    .{ &search, input },

[3.2048]

[3.2089]

                    .{ &search.?, input },

Insertion in src/nnue.zig at line 48 [5.33]

[5.1701]


// var data: [3]nnue.NNUEdata = .{nnue.NNUEdata{
//     .accumulator = nnue.Accumulator{
//         .accumulation = [_][256]i16{[_]i16{0} ** 256} ** 2,
//         .computedAccumulation = 0,
//     },
//     .dirtyPiece = nnue.DirtyPiece{
//         .dirtyNum = 0,
//         .pc = [_]c_int{0} ** 3,
//         .from = [_]c_int{0} ** 3,
//         .to = [_]c_int{0} ** 3,
//     },
// }} ** 3;

Insertion in src/nnue.zig at line 64 [5.33]
[5.1795]
[5.1795]

Replacement in src/nnue.zig at line 100 [5.33]

B:BD[5.3076] → [5.3076:3140]

B:BD[5.3140] → [2.0:174]

∅:D[2.174] → [5.3140:3173]

∅:D[6.332] → [5.3140:3173]

B:BD[5.3140] → [5.3140:3173]

    if (!nnue_initialized) {
        nnue.nnue_init(NNUE_FILE);
        if (@as(c_int, 57) !=
            nnue.nnue_evaluate_fen("rnbqkbnr/pppppppp/8/8/8/8/PPPPPPPP/RNBQKBNR w KQkq - 0 1"))
        {
            std.os.exit(1);
        }
        nnue_initialized = true;

[5.3076]

[5.3173]

    // return @intCast(isize, nnue.nnue_evaluate_incremental(
    //     @enumToInt(gs.side),
    //     &sf_pieces,
    //     &sf_squares,
    //     @ptrCast([*c][*c]nnue.NNUEdata, &data),
    // ));
    return @intCast(isize, nnue.nnue_evaluate(@enumToInt(gs.side), &sf_pieces, &sf_squares));
}
pub fn init() !void {
    nnue.nnue_init(NNUE_FILE);
    if (@as(c_int, 57) !=
        nnue.nnue_evaluate_fen("rnbqkbnr/pppppppp/8/8/8/8/PPPPPPPP/RNBQKBNR w KQkq - 0 1"))
    {
        return error.FailedToInitNNUE;

Deletion in src/nnue.zig at line 116 [5.33]

B:BD[5.3179] → [5.3179:3274]


    return @intCast(isize, nnue.nnue_evaluate(@enumToInt(gs.side), &sf_pieces, &sf_squares));

Replacement in src/main.zig at line 24 [7.50]

B:BD[3.3181] → [3.3181:3220]

        var search = Search.init(&gs);

[3.3181]

[8.1530]

        var search = try Search.init(&gs);

Insertion in src/Search.zig at line 38 [10.35]
[3.3544]
[9.218]
```
    const CHECK_STOP = 0x7ff; // 2047
```

Replacement in src/Search.zig at line 56 [10.35]

B:BD[10.629] → [3.3914:3956]

    pub fn init(gs: *GameState) @This() {

[10.629]

[3.3956]

    pub fn init(gs: *GameState) !@This() {
        if (build_options.nnue) {
            try nnue.init();
        }

Replacement in src/Search.zig at line 134 [10.35]

B:BD[3.6036] → [3.6036:6077]

        if (self.stopSearch()) return 0;

[3.6036]

[11.858]

        if (nodes & CHECK_STOP == 0 and self.stopSearch()) return 0;

Replacement in src/Search.zig at line 305 [10.35]

B:BD[3.12019] → [3.12019:12060]

        if (self.stopSearch()) return 0;

[3.12019]

[10.3786]

        if (nodes & CHECK_STOP == 0 and self.stopSearch()) return 0;

Replacement in src/Search.zig at line 363 [10.35]

B:BD[9.2752] → [3.13295:13362]

    fn print_info(self: @This(), scr: isize, depth: usize) !void {

[9.2752]

[3.13362]

    fn print_info(self: *@This(), scr: isize, depth: usize) !void {

Insertion in src/Search.zig at line 367 [10.35]

[9.3090]

[3.13455]

        const time = @intToFloat(f32, self.timer.read()) / std.time.ns_per_ms;

Replacement in src/Search.zig at line 370 [10.35]

B:BD[3.13534] → [3.13534:13627]

            "info score cp {d} depth {d} nodes {d} pv ",
            .{ scr, depth, nodes },

[3.13534]

[3.13627]

            "info score cp {d} depth {d} nodes {d} time {d:.0} nps {d:.0} pv ",
            .{ scr, depth, nodes, time, (@intToFloat(f32, nodes) / time) * std.time.ms_per_s },