{"header":{"message":"Fix UB when accessing errors with large alignment\n","description":null,"timestamp":"2019-10-10T00:46:09Z","authors":[{"email":"john.ips.schug@gmail.com","name":"John Schug"}]},"hash":"4SNDY6U7TDCVRCARTEQ7JLATJFDMUMEFV2GSLKMQJY7RFNPU5HDQC","authors":[],"deps":{"hashes":[["4SNDY6U7TDCVRCARTEQ7JLATJFDMUMEFV2GSLKMQJY7RFNPU5HDQC","Fix UB when accessing errors with large alignment\n"],["AA",null],["O557J2CNZMAHKGGCT3Y7LH5XORK63D2YOUCALWYB76CHVLJRSDBQC","Simplify downcast_ref and downcast_mut\n"],["Z4YYQXEE4OQPF22I4LD7RVQIBKK67AHCYR6C35MANUCIC4P3EPYQC","Deallocate with the right Layout during downcast\n"],["UEO5OKN446XCE2FHS6GFXYYL2D3YNJD6NI6QLMWO2QZAZKUCL2XQC","Add test of drop after downcast\n"],["DFDCD3LPJCYCNINXBXGFAYD4CT2SBI4RBITE7OK5D5QPTIWWMQKAC","Fill in StdError methods for ErrorImpl\n"],["3LI5FAF5ULXOWBMTG4XCUOMUPVROSFDY6FWGE574OH4JGPMOPNVAC","Import std::error::Error as StdError\n\nTo avoid name collisions when renaming Exception to Error.\n"],["RIKD63GT7RFV3UAV4BYD57GFXKXALWUP6J7AAHB3M6JVAZ3WFTXAC","Add conversion from Error to Box\n"],["CITEDKPB6MKVZUEYEDE5ZKTNVY35HCOAXKDPYG7YLLEOVFNMSRXQC","Import implementation from fehler 1.0.0-alpha.1\n"],["5LAG4UYS7ZP6FMYK55JWFGSFW6ESA6UYALQW64KPEFPM7JKJVQ7AC","Specify generic params on every transmute\n"],["GZZOJ7ZUSBPI3HXIV5UCFNMCDAMZPPLISY2UDV73FDN74HZ3AWJAC","Format with rustfmt 2019-09-08\n"],["AEVUCD3O343GYQLS7EO5ULPGVTGXSOXDKU3RVENI3ZJ3MFYTZ2ZAC","Rename source to object in vtable\n\nSince these function pointers have nothing to do with Error::source.\n"],["LX7EZ6TKJCQI3K7SV56WMTPFY672WN5UOBGXKKXQI7S73GMWNNXAC","Change Error::construct to unsafe fn because TypeId must be correct\n"],["ZA66LGSAXNKRWKA7QLKM5UGSZE3KTGTRL6MNGA426YYW65HYIDPAC","No need for object_raw, object_mut_raw to be unsafe\n"],["NPOFDGQF4CE72IZBT5Y7KPIBHWPPNOEPBYD5RTUHSVUJ2W4XFRVQC","Deallocate ErrorImpl with the right Layout\n"],["EXRAFG37562NH775A4LDPP5FNKXLPLIZSJ3FCOBINUDKRFBJHCXAC","Move trait bounds to where-clauses\n\nI find it more readable how this appears in rustdoc.\n"],["F5MLEQJFOB443KKN22TYYJN2TR52653MD4VXSEYZQBNWWJYES5VQC","Update vtable function names to match the implementation names\n"],["ZDN7BJ3JA3VL4AYWX3SV24GHP6NCAETJVAKAXKMIZTLHTWLUNMOQC","Detect nightly and only expose backtrace if available\n"],["UR5XDZ3SS7QXSUFAYQDYUXX4QDROIYVXUH3Z24F6PAWJDNODAZYAC","Rename InnerException to ErrorImpl\n"],["T64LKJ2RTUDFYSJQI7KF4WHZYXZHNEGNOS7ZMMCRIQZ4YN5LOOMAC","Fix potential UB by removing reliance on trait object layout\n\nAdds a raw vtable object (similar to `RawWakerVTable`) that is manually\ncreated and has methods to dynamically cast to `dyn StdError`.\n"],["WJWASFHAXBNMWHEXMKR53FLXPVUFVT44F2WKSJSA57V2UOZVSOJQC","Organize test files\n"]],"deps":["O557J2CNZMAHKGGCT3Y7LH5XORK63D2YOUCALWYB76CHVLJRSDBQC","Z4YYQXEE4OQPF22I4LD7RVQIBKK67AHCYR6C35MANUCIC4P3EPYQC","UEO5OKN446XCE2FHS6GFXYYL2D3YNJD6NI6QLMWO2QZAZKUCL2XQC","DFDCD3LPJCYCNINXBXGFAYD4CT2SBI4RBITE7OK5D5QPTIWWMQKAC"],"known":["CITEDKPB6MKVZUEYEDE5ZKTNVY35HCOAXKDPYG7YLLEOVFNMSRXQC","GZZOJ7ZUSBPI3HXIV5UCFNMCDAMZPPLISY2UDV73FDN74HZ3AWJAC","3LI5FAF5ULXOWBMTG4XCUOMUPVROSFDY6FWGE574OH4JGPMOPNVAC","UR5XDZ3SS7QXSUFAYQDYUXX4QDROIYVXUH3Z24F6PAWJDNODAZYAC","EXRAFG37562NH775A4LDPP5FNKXLPLIZSJ3FCOBINUDKRFBJHCXAC","5LAG4UYS7ZP6FMYK55JWFGSFW6ESA6UYALQW64KPEFPM7JKJVQ7AC","ZDN7BJ3JA3VL4AYWX3SV24GHP6NCAETJVAKAXKMIZTLHTWLUNMOQC","T64LKJ2RTUDFYSJQI7KF4WHZYXZHNEGNOS7ZMMCRIQZ4YN5LOOMAC","AEVUCD3O343GYQLS7EO5ULPGVTGXSOXDKU3RVENI3ZJ3MFYTZ2ZAC","LX7EZ6TKJCQI3K7SV56WMTPFY672WN5UOBGXKKXQI7S73GMWNNXAC","ZA66LGSAXNKRWKA7QLKM5UGSZE3KTGTRL6MNGA426YYW65HYIDPAC","F5MLEQJFOB443KKN22TYYJN2TR52653MD4VXSEYZQBNWWJYES5VQC","NPOFDGQF4CE72IZBT5Y7KPIBHWPPNOEPBYD5RTUHSVUJ2W4XFRVQC","RIKD63GT7RFV3UAV4BYD57GFXKXALWUP6J7AAHB3M6JVAZ3WFTXAC"]},"hunks":[{"Replacement":{"inode":{"change":6,"pos":3238},"path":"src/error.rs","line":94,"ins":{"up_context":[{"change":6,"pos":941}],"down_context":[{"change":6,"pos":960}],"flag":"BLOCK","start":0,"end":27,"inode":{"change":6,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":6,"pos":941},"to":{"change":6,"start":941,"end":960},"introduced_by":6}],"inode":{"change":6,"pos":3238}},"ins_contents":[{"Add":" _error: error,"}],"del_contents":[{"Del":" error,\n"}]}},{"Replacement":{"inode":{"change":6,"pos":3238},"path":"src/error.rs","line":236,"ins":{"up_context":[{"change":6,"pos":6676}],"down_context":[{"change":3,"pos":218}],"flag":"BLOCK","start":28,"end":112,"inode":{"change":6,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":6,"pos":6676},"to":{"change":3,"start":134,"end":218},"introduced_by":3}],"inode":{"change":6,"pos":3238}},"ins_contents":[{"Add":" let error = ptr::read(outer.inner.error() as *const _ as *const E);"}],"del_contents":[{"Del":" let error = ptr::read(&outer.inner.error as *const () as *const E);\n"}]}},{"Replacement":{"inode":{"change":6,"pos":3238},"path":"src/error.rs","line":288,"ins":{"up_context":[{"change":6,"pos":7064}],"down_context":[{"change":6,"pos":1380}],"flag":"BLOCK","start":113,"end":189,"inode":{"change":6,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":6,"pos":7064},"to":{"change":2,"start":0,"end":76},"introduced_by":2}],"inode":{"change":6,"pos":3238}},"ins_contents":[{"Add":" Some(unsafe { &*(self.inner.error() as *const _ as *const E) })"}],"del_contents":[{"Del":" Some(unsafe { &*(&self.inner.error as *const () as *const E) })\n"}]}},{"Replacement":{"inode":{"change":6,"pos":3238},"path":"src/error.rs","line":300,"ins":{"up_context":[{"change":6,"pos":7360}],"down_context":[{"change":6,"pos":1425}],"flag":"BLOCK","start":190,"end":270,"inode":{"change":6,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":6,"pos":7360},"to":{"change":2,"start":77,"end":157},"introduced_by":2}],"inode":{"change":6,"pos":3238}},"ins_contents":[{"Add":" Some(unsafe { &mut *(self.inner.error_mut() as *mut _ as *mut E) })"}],"del_contents":[{"Del":" Some(unsafe { &mut *(&mut self.inner.error as *mut () as *mut E) })\n"}]}},{"Replacement":{"inode":{"change":6,"pos":3238},"path":"src/error.rs","line":359,"ins":{"up_context":[{"change":3,"pos":447}],"down_context":[{"change":6,"pos":210}],"flag":"BLOCK","start":271,"end":455,"inode":{"change":6,"pos":3238}},"del":{"edges":[{"previous":"","flag":"DELETED","from":{"change":3,"pos":447},"to":{"change":6,"start":91,"end":251},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":6,"pos":519},"to":{"change":6,"start":91,"end":251},"introduced_by":6},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":6,"pos":195},"to":{"change":6,"start":91,"end":251},"introduced_by":6}],"inode":{"change":6,"pos":3238}},"ins_contents":[{"Add":" object_raw: unsafe fn(&ErrorImpl<()>) -> &(dyn StdError + Send + Sync + 'static),"},{"Add":" object_mut_raw: unsafe fn(&mut ErrorImpl<()>) -> &mut (dyn StdError + Send + Sync + 'static),"}],"del_contents":[{"Del":" object_raw: fn(*const ()) -> *const (dyn StdError + Send + Sync + 'static),\n object_mut_raw: fn(*mut ()) -> *mut (dyn StdError + Send + Sync + 'static),\n"}]}},{"Replacement":{"inode":{"change":6,"pos":3238},"path":"src/error.rs","line":379,"ins":{"up_context":[{"change":6,"pos":364}],"down_context":[{"change":6,"pos":451}],"flag":"BLOCK","start":456,"end":542,"inode":{"change":6,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":6,"pos":364},"to":{"change":6,"start":153,"end":233},"introduced_by":6}],"inode":{"change":6,"pos":3238}},"ins_contents":[{"Add":"unsafe fn object_raw(e: &ErrorImpl<()>) -> &(dyn StdError + Send + Sync + 'static)"}],"del_contents":[{"Del":"fn object_raw(e: *const ()) -> *const (dyn StdError + Send + Sync + 'static)\n"}]}},{"Replacement":{"inode":{"change":6,"pos":3238},"path":"src/error.rs","line":383,"ins":{"up_context":[{"change":6,"pos":500}],"down_context":[{"change":6,"pos":9174}],"flag":"BLOCK","start":543,"end":609,"inode":{"change":6,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":6,"pos":500},"to":{"change":6,"start":500,"end":518},"introduced_by":6}],"inode":{"change":6,"pos":3238}},"ins_contents":[{"Add":" &(*(e as *const ErrorImpl<()> as *const ErrorImpl))._error"}],"del_contents":[{"Del":" e as *const E\n"}]}},{"Replacement":{"inode":{"change":6,"pos":3238},"path":"src/error.rs","line":386,"ins":{"up_context":[{"change":6,"pos":9177}],"down_context":[{"change":6,"pos":606}],"flag":"BLOCK","start":610,"end":708,"inode":{"change":6,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":6,"pos":9177},"to":{"change":6,"start":234,"end":314},"introduced_by":6}],"inode":{"change":6,"pos":3238}},"ins_contents":[{"Add":"unsafe fn object_mut_raw(e: &mut ErrorImpl<()>) -> &mut (dyn StdError + Send + Sync + 'static)"}],"del_contents":[{"Del":"fn object_mut_raw(e: *mut ()) -> *mut (dyn StdError + Send + Sync + 'static)\n"}]}},{"Replacement":{"inode":{"change":6,"pos":3238},"path":"src/error.rs","line":390,"ins":{"up_context":[{"change":6,"pos":655}],"down_context":[{"change":6,"pos":305}],"flag":"BLOCK","start":709,"end":775,"inode":{"change":6,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":6,"pos":655},"to":{"change":6,"start":655,"end":671},"introduced_by":6}],"inode":{"change":6,"pos":3238}},"ins_contents":[{"Add":" &mut (*(e as *mut ErrorImpl<()> as *mut ErrorImpl))._error"}],"del_contents":[{"Del":" e as *mut E\n"}]}},{"Replacement":{"inode":{"change":6,"pos":3238},"path":"src/error.rs","line":406,"ins":{"up_context":[{"change":6,"pos":9352}],"down_context":[{"change":6,"pos":9366}],"flag":"BLOCK","start":776,"end":891,"inode":{"change":6,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":6,"pos":9352},"to":{"change":6,"start":9352,"end":9366},"introduced_by":6}],"inode":{"change":6,"pos":3238}},"ins_contents":[{"Add":" // NOTE: Don't use directly. Use only through vtable. Erased type may have different alignment."},{"Add":" _error: E,"}],"del_contents":[{"Del":" error: E,\n"}]}},{"Replacement":{"inode":{"change":6,"pos":3238},"path":"src/error.rs","line":464,"ins":{"up_context":[{"change":6,"pos":1693}],"down_context":[{"change":6,"pos":10195}],"flag":"BLOCK","start":892,"end":944,"inode":{"change":6,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":6,"pos":1693},"to":{"change":6,"start":252,"end":311},"introduced_by":6}],"inode":{"change":6,"pos":3238}},"ins_contents":[{"Add":" unsafe { &*(self.vtable.object_raw)(self) }"}],"del_contents":[{"Del":" unsafe { &*(self.vtable.object_raw)(&self.error) }\n"}]}},{"Replacement":{"inode":{"change":6,"pos":3238},"path":"src/error.rs","line":468,"ins":{"up_context":[{"change":6,"pos":1771}],"down_context":[{"change":6,"pos":515}],"flag":"BLOCK","start":945,"end":1005,"inode":{"change":6,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":6,"pos":1771},"to":{"change":6,"start":312,"end":383},"introduced_by":6}],"inode":{"change":6,"pos":3238}},"ins_contents":[{"Add":" unsafe { &mut *(self.vtable.object_mut_raw)(self) }"}],"del_contents":[{"Del":" unsafe { &mut *(self.vtable.object_mut_raw)(&mut self.error) }\n"}]}},{"Replacement":{"inode":{"change":6,"pos":3238},"path":"src/error.rs","line":536,"ins":{"up_context":[{"change":5,"pos":383}],"down_context":[{"change":5,"pos":411}],"flag":"BLOCK","start":1006,"end":1044,"inode":{"change":6,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":383},"to":{"change":5,"start":383,"end":411},"introduced_by":5}],"inode":{"change":6,"pos":3238}},"ins_contents":[{"Add":" self.erase().error().source()"}],"del_contents":[{"Del":" self.error.source()\n"}]}},{"Replacement":{"inode":{"change":6,"pos":3238},"path":"src/error.rs","line":554,"ins":{"up_context":[{"change":6,"pos":2589}],"down_context":[{"change":6,"pos":2634}],"flag":"BLOCK","start":1045,"end":1100,"inode":{"change":6,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":6,"pos":2589},"to":{"change":6,"start":2589,"end":2634},"introduced_by":6}],"inode":{"change":6,"pos":3238}},"ins_contents":[{"Add":" Display::fmt(&self.erase().error(), formatter)"}],"del_contents":[{"Del":" Display::fmt(&self.error, formatter)\n"}]}},{"Edit":{"inode":{"change":21,"pos":311},"path":"tests/test_downcast.rs","line":7,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":58}],"down_context":[{"change":21,"pos":346}],"flag":"BLOCK","start":1101,"end":1167,"inode":{"change":21,"pos":311}}},"contents":[{"Add":"use std::error::Error as StdError;"},{"Add":"use std::fmt::{self, Display};"}]}},{"Edit":{"inode":{"change":21,"pos":311},"path":"tests/test_downcast.rs","line":80,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":389}],"down_context":[{"change":21,"pos":772}],"flag":"BLOCK","start":1168,"end":1630,"inode":{"change":21,"pos":311}}},"contents":[{"Add":"}"},{"Add":""},{"Add":"#[test]"},{"Add":"fn test_large_alignment() {"},{"Add":" #[repr(align(64))]"},{"Add":" #[derive(Debug)]"},{"Add":" struct LargeAlignedError(&'static str);"},{"Add":""},{"Add":" impl Display for LargeAlignedError {"},{"Add":" fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {"},{"Add":" f.write_str(self.0)"},{"Add":" }"},{"Add":" }"},{"Add":""},{"Add":" impl StdError for LargeAlignedError {}"},{"Add":""},{"Add":" let error = Error::new(LargeAlignedError(\"oh no!\"));"},{"Add":" assert_eq!(\"oh no!\", error.downcast_ref::().unwrap().0);"}]}}],"owner":"yaahc","repo":"eyre","token":"gFKW5JncVbkV3rzjrwRJK1qhSBKIGZOELwBVmlHfQM4=","login":null}

…

Dependencies

Change contents