{"header":{"message":"Remove unneeded object_is vtable method\n","description":null,"timestamp":"2019-10-28T01:23:32Z","authors":[{"email":"dtolnay@gmail.com","name":"David Tolnay"}]},"hash":"KQE34I2L7O32GTKV4NNWIEVIQ4WR2ZV4F6MCFNSWPDAAAVYZFEJQC","authors":[],"deps":{"hashes":[["KQE34I2L7O32GTKV4NNWIEVIQ4WR2ZV4F6MCFNSWPDAAAVYZFEJQC","Remove unneeded object_is vtable method\n"],["AA",null],["ZEYYSYM7QBZG4Q67AN3CHYZQWO2DVVHXRAK6NX44UQD6VO3JTK3AC","Rename the ErrorImpl tail to _object\n\nAvoids _error.error repetition when manipulation ErrorImpl,\nand works well with object_ref / object_mut naming in the vtable.\n"],["T64LKJ2RTUDFYSJQI7KF4WHZYXZHNEGNOS7ZMMCRIQZ4YN5LOOMAC","Fix potential UB by removing reliance on trait object layout\n\nAdds a raw vtable object (similar to `RawWakerVTable`) that is manually\ncreated and has methods to dynamically cast to `dyn StdError`.\n"],["CITEDKPB6MKVZUEYEDE5ZKTNVY35HCOAXKDPYG7YLLEOVFNMSRXQC","Import implementation from fehler 1.0.0-alpha.1\n"],["CZP5PD5NYLDULLW43VOL6V75CH6DDEJO7H6JSGQSIV2WNSQF4A6QC","Rename vtable object ref and mut methods that are no longer raw ptr\n"],["TOXJRHV7ZUPHWXCA4TAG3YRBTIPUZQ5BNX34D3VD2JAIYLRN6XSAC","Move TypeId out of the Box allocation\n"],["RIKD63GT7RFV3UAV4BYD57GFXKXALWUP6J7AAHB3M6JVAZ3WFTXAC","Add conversion from Error to Box\n"],["W5YRNIBZIMTQLOKIBWBF7CHCIOLKXVHV7Y2AIKMKG7GCQSAVZKBAC","Support downcasting ContextError to C and E\n"],["NPOFDGQF4CE72IZBT5Y7KPIBHWPPNOEPBYD5RTUHSVUJ2W4XFRVQC","Deallocate ErrorImpl with the right Layout\n"],["VWTWVVRECX62JABUZYFCTCPWTXXT3DB4635RIAGCKIQMGJ7VXRGAC","Move downcasting into vtable\n"],["W655S25G7CGI4XOZ2PKITKTH26VJ4QMZFRV2RPYNI4KIUJOIGVMAC","Change all remaining exception related wording\n"],["4SNDY6U7TDCVRCARTEQ7JLATJFDMUMEFV2GSLKMQJY7RFNPU5HDQC","Fix UB when accessing errors with large alignment\n"],["BA4YE6QGRTYONATHUP347OFUBUCWXQPNZ6Q5DIQ2DLJLRZJ6AC4AC","Eliminate backtrace_if_absent in Error::context\n\nThis avoids stepping through the list of causes when adding context to\nthe anyhow::Error type which is known to already hold a backtrace.\n\nReduces the release-mode time of the following loop from 4 seconds to 4\nmilliseconds.\n\n let mut err = anyhow!(\"...\");\n for _ in 0..25000 {\n err = err.context(\"...\");\n }\n"],["LR3QQRO4ZFYYIY4JJ7LJIO4VUK3EWESPIAPLPPIP4W7N75PSVQHQC","Support downcasting ContextError to C and cause\n"],["EXRAFG37562NH775A4LDPP5FNKXLPLIZSJ3FCOBINUDKRFBJHCXAC","Move trait bounds to where-clauses\n\nI find it more readable how this appears in rustdoc.\n"],["F5MLEQJFOB443KKN22TYYJN2TR52653MD4VXSEYZQBNWWJYES5VQC","Update vtable function names to match the implementation names\n"],["RFSCYZWH7VQUGHAM374YUDGZGM5S4KT6NXWDMHXL4767SCRSL2DQC","Expand ContextError vtable to prepare for extending downcast support\n"]],"deps":["ZEYYSYM7QBZG4Q67AN3CHYZQWO2DVVHXRAK6NX44UQD6VO3JTK3AC"],"known":["CITEDKPB6MKVZUEYEDE5ZKTNVY35HCOAXKDPYG7YLLEOVFNMSRXQC","W655S25G7CGI4XOZ2PKITKTH26VJ4QMZFRV2RPYNI4KIUJOIGVMAC","EXRAFG37562NH775A4LDPP5FNKXLPLIZSJ3FCOBINUDKRFBJHCXAC","T64LKJ2RTUDFYSJQI7KF4WHZYXZHNEGNOS7ZMMCRIQZ4YN5LOOMAC","F5MLEQJFOB443KKN22TYYJN2TR52653MD4VXSEYZQBNWWJYES5VQC","NPOFDGQF4CE72IZBT5Y7KPIBHWPPNOEPBYD5RTUHSVUJ2W4XFRVQC","RIKD63GT7RFV3UAV4BYD57GFXKXALWUP6J7AAHB3M6JVAZ3WFTXAC","4SNDY6U7TDCVRCARTEQ7JLATJFDMUMEFV2GSLKMQJY7RFNPU5HDQC","CZP5PD5NYLDULLW43VOL6V75CH6DDEJO7H6JSGQSIV2WNSQF4A6QC","TOXJRHV7ZUPHWXCA4TAG3YRBTIPUZQ5BNX34D3VD2JAIYLRN6XSAC","BA4YE6QGRTYONATHUP347OFUBUCWXQPNZ6Q5DIQ2DLJLRZJ6AC4AC","RFSCYZWH7VQUGHAM374YUDGZGM5S4KT6NXWDMHXL4767SCRSL2DQC","VWTWVVRECX62JABUZYFCTCPWTXXT3DB4635RIAGCKIQMGJ7VXRGAC","W5YRNIBZIMTQLOKIBWBF7CHCIOLKXVHV7Y2AIKMKG7GCQSAVZKBAC","LR3QQRO4ZFYYIY4JJ7LJIO4VUK3EWESPIAPLPPIP4W7N75PSVQHQC"]},"hunks":[{"Edit":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":35,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":261},"to":{"change":3,"start":261,"end":300},"introduced_by":3}],"inode":{"change":3,"pos":3238}}},"contents":[{"Del":" object_is: object_is::,\n"}]}},{"Edit":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":53,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":775},"to":{"change":3,"start":775,"end":814},"introduced_by":3}],"inode":{"change":3,"pos":3238}}},"contents":[{"Del":" object_is: object_is::,\n"}]}},{"Edit":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":72,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1356},"to":{"change":3,"start":1356,"end":1395},"introduced_by":3}],"inode":{"change":3,"pos":3238}}},"contents":[{"Del":" object_is: object_is::,\n"}]}},{"Edit":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":93,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":633},"to":{"change":3,"start":165,"end":208},"introduced_by":3}],"inode":{"change":3,"pos":3238}}},"contents":[{"Del":" object_is: context_is::,\n"}]}},{"Edit":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":192,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":414},"to":{"change":3,"start":0,"end":46},"introduced_by":3}],"inode":{"change":3,"pos":3238}}},"contents":[{"Del":" object_is: context_chain_is::,\n"}]}},{"Replacement":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":263,"ins":{"up_context":[{"change":3,"pos":918}],"down_context":[{"change":3,"pos":6434}],"flag":"BLOCK","start":0,"end":43,"inode":{"change":3,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":918},"to":{"change":3,"start":1847,"end":1887},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1887},"to":{"change":3,"start":165,"end":235},"introduced_by":3}],"inode":{"change":3,"pos":3238}},"ins_contents":[{"Add":" self.downcast_ref::().is_some()"}],"del_contents":[{"Del":" let target = TypeId::of::();\n"},{"Del":" unsafe { (self.inner.vtable.object_is)(&self.inner, target) }\n"}]}},{"Edit":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":400,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":304},"to":{"change":3,"start":236,"end":294},"introduced_by":3}],"inode":{"change":3,"pos":3238}}},"contents":[{"Del":" object_is: unsafe fn(&ErrorImpl<()>, TypeId) -> bool,\n"}]}},{"Edit":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":439,"atom":{"EdgeMap":{"edges":[{"previous":"","flag":"DELETED","from":{"change":3,"pos":514},"to":{"change":3,"start":671,"end":674},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":671},"to":{"change":3,"start":671,"end":674},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":674},"to":{"change":3,"start":295,"end":361},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":361},"to":{"change":3,"start":1319,"end":1343},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1319},"to":{"change":3,"start":1319,"end":1343},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1343},"to":{"change":3,"start":362,"end":377},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":377},"to":{"change":3,"start":1343,"end":1375},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1343},"to":{"change":3,"start":1343,"end":1375},"introduced_by":3}],"inode":{"change":3,"pos":3238}}},"contents":[{"Del":"}\n\n"},{"Del":"unsafe fn object_is(e: &ErrorImpl<()>, target: TypeId) -> bool\n"},{"Del":"where\n E: 'static,\n{\n"},{"Del":" let _ = e;\n"},{"Del":" TypeId::of::() == target\n"}]}},{"Edit":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":454,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":619},"to":{"change":3,"start":378,"end":448},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":448},"to":{"change":3,"start":670,"end":710},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":670},"to":{"change":3,"start":670,"end":710},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":710},"to":{"change":3,"start":449,"end":464},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":464},"to":{"change":3,"start":710,"end":773},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":710},"to":{"change":3,"start":710,"end":773},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":773},"to":{"change":3,"start":2091,"end":2094},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":1731},"to":{"change":3,"start":2091,"end":2094},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":2091},"to":{"change":3,"start":2091,"end":2094},"introduced_by":3}],"inode":{"change":3,"pos":3238}}},"contents":[{"Del":"unsafe fn context_is(e: &ErrorImpl<()>, target: TypeId) -> bool\n"},{"Del":"where\n C: 'static,\n E: 'static,\n{\n"},{"Del":" let _ = e;\n"},{"Del":" TypeId::of::() == target || TypeId::of::() == target\n"},{"Del":"}\n\n"}]}},{"Edit":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":494,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":512},"to":{"change":3,"start":512,"end":766},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":766},"to":{"change":2,"start":374,"end":423},"introduced_by":2},{"previous":"","flag":"DELETED","from":{"change":2,"pos":423},"to":{"change":3,"start":814,"end":886},"introduced_by":2},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":814},"to":{"change":3,"start":814,"end":886},"introduced_by":3}],"inode":{"change":3,"pos":3238}}},"contents":[{"Del":"unsafe fn context_chain_is(e: &ErrorImpl<()>, target: TypeId) -> bool\nwhere\n C: 'static,\n{\n if TypeId::of::() == target {\n true\n } else {\n let unerased = e as *const ErrorImpl<()> as *const ErrorImpl>;\n"},{"Del":" let source = &(*unerased)._object.error;\n"},{"Del":" (source.inner.vtable.object_is)(&source.inner, target)\n }\n}\n\n"}]}}],"owner":"yaahc","repo":"eyre","token":"Dg4bGB8xCrKSF5dWjdFHyedjdUUB3yha25TmhaNv/70=","login":null}

…

Dependencies

Change contents