{"header":{"message":"Support downcasting ContextError to C and cause\n","description":null,"timestamp":"2019-10-28T01:01:39Z","authors":[{"email":"dtolnay@gmail.com","name":"David Tolnay"}]},"hash":"LR3QQRO4ZFYYIY4JJ7LJIO4VUK3EWESPIAPLPPIP4W7N75PSVQHQC","authors":[],"deps":{"hashes":[["LR3QQRO4ZFYYIY4JJ7LJIO4VUK3EWESPIAPLPPIP4W7N75PSVQHQC","Support downcasting ContextError to C and cause\n"],["AA",null],["W5YRNIBZIMTQLOKIBWBF7CHCIOLKXVHV7Y2AIKMKG7GCQSAVZKBAC","Support downcasting ContextError to C and E\n"],["TOXJRHV7ZUPHWXCA4TAG3YRBTIPUZQ5BNX34D3VD2JAIYLRN6XSAC","Move TypeId out of the Box allocation\n"],["4SNDY6U7TDCVRCARTEQ7JLATJFDMUMEFV2GSLKMQJY7RFNPU5HDQC","Fix UB when accessing errors with large alignment\n"],["CITEDKPB6MKVZUEYEDE5ZKTNVY35HCOAXKDPYG7YLLEOVFNMSRXQC","Import implementation from fehler 1.0.0-alpha.1\n"],["EXRAFG37562NH775A4LDPP5FNKXLPLIZSJ3FCOBINUDKRFBJHCXAC","Move trait bounds to where-clauses\n\nI find it more readable how this appears in rustdoc.\n"],["RIKD63GT7RFV3UAV4BYD57GFXKXALWUP6J7AAHB3M6JVAZ3WFTXAC","Add conversion from Error to Box\n"],["BA4YE6QGRTYONATHUP347OFUBUCWXQPNZ6Q5DIQ2DLJLRZJ6AC4AC","Eliminate backtrace_if_absent in Error::context\n\nThis avoids stepping through the list of causes when adding context to\nthe anyhow::Error type which is known to already hold a backtrace.\n\nReduces the release-mode time of the following loop from 4 seconds to 4\nmilliseconds.\n\n let mut err = anyhow!(\"...\");\n for _ in 0..25000 {\n err = err.context(\"...\");\n }\n"],["NPOFDGQF4CE72IZBT5Y7KPIBHWPPNOEPBYD5RTUHSVUJ2W4XFRVQC","Deallocate ErrorImpl with the right Layout\n"],["CZP5PD5NYLDULLW43VOL6V75CH6DDEJO7H6JSGQSIV2WNSQF4A6QC","Rename vtable object ref and mut methods that are no longer raw ptr\n"],["T64LKJ2RTUDFYSJQI7KF4WHZYXZHNEGNOS7ZMMCRIQZ4YN5LOOMAC","Fix potential UB by removing reliance on trait object layout\n\nAdds a raw vtable object (similar to `RawWakerVTable`) that is manually\ncreated and has methods to dynamically cast to `dyn StdError`.\n"],["F5MLEQJFOB443KKN22TYYJN2TR52653MD4VXSEYZQBNWWJYES5VQC","Update vtable function names to match the implementation names\n"],["VWTWVVRECX62JABUZYFCTCPWTXXT3DB4635RIAGCKIQMGJ7VXRGAC","Move downcasting into vtable\n"]],"deps":["W5YRNIBZIMTQLOKIBWBF7CHCIOLKXVHV7Y2AIKMKG7GCQSAVZKBAC"],"known":["CITEDKPB6MKVZUEYEDE5ZKTNVY35HCOAXKDPYG7YLLEOVFNMSRXQC","EXRAFG37562NH775A4LDPP5FNKXLPLIZSJ3FCOBINUDKRFBJHCXAC","T64LKJ2RTUDFYSJQI7KF4WHZYXZHNEGNOS7ZMMCRIQZ4YN5LOOMAC","F5MLEQJFOB443KKN22TYYJN2TR52653MD4VXSEYZQBNWWJYES5VQC","NPOFDGQF4CE72IZBT5Y7KPIBHWPPNOEPBYD5RTUHSVUJ2W4XFRVQC","RIKD63GT7RFV3UAV4BYD57GFXKXALWUP6J7AAHB3M6JVAZ3WFTXAC","4SNDY6U7TDCVRCARTEQ7JLATJFDMUMEFV2GSLKMQJY7RFNPU5HDQC","CZP5PD5NYLDULLW43VOL6V75CH6DDEJO7H6JSGQSIV2WNSQF4A6QC","TOXJRHV7ZUPHWXCA4TAG3YRBTIPUZQ5BNX34D3VD2JAIYLRN6XSAC","BA4YE6QGRTYONATHUP347OFUBUCWXQPNZ6Q5DIQ2DLJLRZJ6AC4AC","VWTWVVRECX62JABUZYFCTCPWTXXT3DB4635RIAGCKIQMGJ7VXRGAC"]},"hunks":[{"Replacement":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":196,"ins":{"up_context":[{"change":3,"pos":414}],"down_context":[{"change":3,"pos":474}],"flag":"BLOCK","start":0,"end":164,"inode":{"change":3,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":414},"to":{"change":3,"start":414,"end":474},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":474},"to":{"change":3,"start":257,"end":329},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":329},"to":{"change":2,"start":321,"end":396},"introduced_by":2}],"inode":{"change":3,"pos":3238}},"ins_contents":[{"Add":" object_is: context_chain_is::,"},{"Add":" object_downcast: context_chain_downcast::,"},{"Add":" object_drop_rest: context_chain_drop_rest::,"}],"del_contents":[{"Del":" object_is: object_is::>,\n"},{"Del":" object_downcast: object_downcast::>,\n"},{"Del":" object_drop_rest: object_drop_front::>,\n"}]}},{"Replacement":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":269,"ins":{"up_context":[{"change":3,"pos":1887}],"down_context":[{"change":3,"pos":6434}],"flag":"BLOCK","start":165,"end":235,"inode":{"change":3,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1887},"to":{"change":3,"start":1887,"end":1944},"introduced_by":3}],"inode":{"change":3,"pos":3238}},"ins_contents":[{"Add":" unsafe { (self.inner.vtable.object_is)(&self.inner, target) }"}],"del_contents":[{"Del":" unsafe { (self.inner.vtable.object_is)(target) }\n"}]}},{"Replacement":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":406,"ins":{"up_context":[{"change":3,"pos":304}],"down_context":[{"change":3,"pos":1192}],"flag":"BLOCK","start":236,"end":294,"inode":{"change":3,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":304},"to":{"change":3,"start":1945,"end":1987},"introduced_by":3}],"inode":{"change":3,"pos":3238}},"ins_contents":[{"Add":" object_is: unsafe fn(&ErrorImpl<()>, TypeId) -> bool,"}],"del_contents":[{"Del":" object_is: unsafe fn(TypeId) -> bool,\n"}]}},{"Replacement":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":448,"ins":{"up_context":[{"change":3,"pos":674}],"down_context":[{"change":3,"pos":1319}],"flag":"BLOCK","start":295,"end":361,"inode":{"change":3,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":674},"to":{"change":3,"start":1272,"end":1319},"introduced_by":3}],"inode":{"change":3,"pos":3238}},"ins_contents":[{"Add":"unsafe fn object_is(e: &ErrorImpl<()>, target: TypeId) -> bool"}],"del_contents":[{"Del":"unsafe fn object_is(target: TypeId) -> bool\n"}]}},{"Edit":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":452,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":1343}],"down_context":[{"change":3,"pos":1343}],"flag":"BLOCK","start":362,"end":377,"inode":{"change":3,"pos":3238}}},"contents":[{"Add":" let _ = e;"}]}},{"Replacement":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":469,"ins":{"up_context":[{"change":2,"pos":619}],"down_context":[{"change":2,"pos":670}],"flag":"BLOCK","start":378,"end":448,"inode":{"change":3,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":619},"to":{"change":2,"start":619,"end":670},"introduced_by":2}],"inode":{"change":3,"pos":3238}},"ins_contents":[{"Add":"unsafe fn context_is(e: &ErrorImpl<()>, target: TypeId) -> bool"}],"del_contents":[{"Del":"unsafe fn context_is(target: TypeId) -> bool\n"}]}},{"Edit":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":474,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":710}],"down_context":[{"change":2,"pos":710}],"flag":"BLOCK","start":449,"end":464,"inode":{"change":3,"pos":3238}}},"contents":[{"Add":" let _ = e;"}]}},{"Edit":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":513,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":2026}],"down_context":[{"change":2,"pos":2026}],"flag":"BLOCK","start":465,"end":1898,"inode":{"change":3,"pos":3238}}},"contents":[{"Add":" >(e);"},{"Add":" drop(unerased);"},{"Add":" }"},{"Add":"}"},{"Add":""},{"Add":"unsafe fn context_chain_is(e: &ErrorImpl<()>, target: TypeId) -> bool"},{"Add":"where"},{"Add":" C: 'static,"},{"Add":"{"},{"Add":" if TypeId::of::() == target {"},{"Add":" true"},{"Add":" } else {"},{"Add":" let unerased = e as *const ErrorImpl<()> as *const ErrorImpl>;"},{"Add":" let source = &(*unerased)._error.error;"},{"Add":" (source.inner.vtable.object_is)(&source.inner, target)"},{"Add":" }"},{"Add":"}"},{"Add":""},{"Add":"unsafe fn context_chain_downcast(e: &ErrorImpl<()>, target: TypeId) -> Option>"},{"Add":"where"},{"Add":" C: 'static,"},{"Add":"{"},{"Add":" if TypeId::of::() == target {"},{"Add":" let unerased = e as *const ErrorImpl<()> as *const ErrorImpl>;"},{"Add":" let addr = &(*unerased)._error.context as *const C as *mut ();"},{"Add":" Some(NonNull::new_unchecked(addr))"},{"Add":" } else {"},{"Add":" let unerased = e as *const ErrorImpl<()> as *const ErrorImpl>;"},{"Add":" let source = &(*unerased)._error.error;"},{"Add":" (source.inner.vtable.object_downcast)(&source.inner, target)"},{"Add":" }"},{"Add":"}"},{"Add":""},{"Add":"unsafe fn context_chain_drop_rest(e: Box>, target: TypeId)"},{"Add":"where"},{"Add":" C: 'static,"},{"Add":"{"},{"Add":" // Called after downcasting by value to either the C or one of the causes"},{"Add":" // and doing a ptr::read to take ownership of that value."},{"Add":" if TypeId::of::() == target {"},{"Add":" let unerased = mem::transmute::<"},{"Add":" Box>,"},{"Add":" Box, Error>>>,"}]}},{"Edit":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":558,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":2064}],"down_context":[{"change":2,"pos":2064}],"flag":"BLOCK","start":1899,"end":2262,"inode":{"change":3,"pos":3238}}},"contents":[{"Add":" } else {"},{"Add":" let unerased = mem::transmute::<"},{"Add":" Box>,"},{"Add":" Box>>>,"},{"Add":" >(e);"},{"Add":" let inner = ptr::read(&unerased._error.error.inner);"},{"Add":" drop(unerased);"},{"Add":" let erased = ManuallyDrop::into_inner(inner);"},{"Add":" (erased.vtable.object_drop_rest)(erased, target);"}]}}],"owner":"yaahc","repo":"eyre","token":"jBwwQBh5oJ5Gkmeof7rpvKz/oypehXnv8uprvFWb+gM=","login":null}

…

Dependencies

Change contents