{"header":{"message":"Deallocate ErrorImpl with the right Layout\n","description":null,"timestamp":"2019-10-08T16:00:13Z","authors":[{"email":"dtolnay@gmail.com","name":"David Tolnay"}]},"hash":"NPOFDGQF4CE72IZBT5Y7KPIBHWPPNOEPBYD5RTUHSVUJ2W4XFRVQC","authors":[],"deps":{"hashes":[["NPOFDGQF4CE72IZBT5Y7KPIBHWPPNOEPBYD5RTUHSVUJ2W4XFRVQC","Deallocate ErrorImpl with the right Layout\n"],["AA",null],["F5MLEQJFOB443KKN22TYYJN2TR52653MD4VXSEYZQBNWWJYES5VQC","Update vtable function names to match the implementation names\n"],["CITEDKPB6MKVZUEYEDE5ZKTNVY35HCOAXKDPYG7YLLEOVFNMSRXQC","Import implementation from fehler 1.0.0-alpha.1\n"],["RQSDP2B2OVRFRJ33OZCVB4TYCQMSR3JZYG7FNA6TQ3HFABTGOGMQC","Add context method to Error\n"],["T64LKJ2RTUDFYSJQI7KF4WHZYXZHNEGNOS7ZMMCRIQZ4YN5LOOMAC","Fix potential UB by removing reliance on trait object layout\n\nAdds a raw vtable object (similar to `RawWakerVTable`) that is manually\ncreated and has methods to dynamically cast to `dyn StdError`.\n"],["UR5XDZ3SS7QXSUFAYQDYUXX4QDROIYVXUH3Z24F6PAWJDNODAZYAC","Rename InnerException to ErrorImpl\n"],["ZDN7BJ3JA3VL4AYWX3SV24GHP6NCAETJVAKAXKMIZTLHTWLUNMOQC","Detect nightly and only expose backtrace if available\n"],["LX7EZ6TKJCQI3K7SV56WMTPFY672WN5UOBGXKKXQI7S73GMWNNXAC","Change Error::construct to unsafe fn because TypeId must be correct\n"],["3LI5FAF5ULXOWBMTG4XCUOMUPVROSFDY6FWGE574OH4JGPMOPNVAC","Import std::error::Error as StdError\n\nTo avoid name collisions when renaming Exception to Error.\n"],["45AUHCDJX5A54AYFMJRGDHKMBQ3WYBIPAVPDPY7TCLK5WN5TSROQC","Move backtrace capture to backtrace module and macro\n"],["32VE6LJUU6QHHAF5MRMDMSS75XMSDU4GF3FWE3XTTMRG2UINVKRQC","Touch up documentation on Error struct\n"],["UM7DFUYLW4HSMBUDZY3R6ZNJRSX2E75C4DYV3MJAU57EUCGE6JLAC","Rename Exception to Error\n"],["ZRCBNUBSB3NEPBPRIRZTRPEKFNAFIRH2AXG2CLXRIYASUXA2QH6AC","Remove as_dyn_error methods from Error\n\nThe underlying `dyn StdError + Send + Sync + 'static` is still available\nthrough Deref and DerefMut.\n"],["5LAG4UYS7ZP6FMYK55JWFGSFW6ESA6UYALQW64KPEFPM7JKJVQ7AC","Specify generic params on every transmute\n"],["GZZOJ7ZUSBPI3HXIV5UCFNMCDAMZPPLISY2UDV73FDN74HZ3AWJAC","Format with rustfmt 2019-09-08\n"]],"deps":["F5MLEQJFOB443KKN22TYYJN2TR52653MD4VXSEYZQBNWWJYES5VQC"],"known":["CITEDKPB6MKVZUEYEDE5ZKTNVY35HCOAXKDPYG7YLLEOVFNMSRXQC","GZZOJ7ZUSBPI3HXIV5UCFNMCDAMZPPLISY2UDV73FDN74HZ3AWJAC","3LI5FAF5ULXOWBMTG4XCUOMUPVROSFDY6FWGE574OH4JGPMOPNVAC","UM7DFUYLW4HSMBUDZY3R6ZNJRSX2E75C4DYV3MJAU57EUCGE6JLAC","UR5XDZ3SS7QXSUFAYQDYUXX4QDROIYVXUH3Z24F6PAWJDNODAZYAC","RQSDP2B2OVRFRJ33OZCVB4TYCQMSR3JZYG7FNA6TQ3HFABTGOGMQC","5LAG4UYS7ZP6FMYK55JWFGSFW6ESA6UYALQW64KPEFPM7JKJVQ7AC","ZDN7BJ3JA3VL4AYWX3SV24GHP6NCAETJVAKAXKMIZTLHTWLUNMOQC","ZRCBNUBSB3NEPBPRIRZTRPEKFNAFIRH2AXG2CLXRIYASUXA2QH6AC","32VE6LJUU6QHHAF5MRMDMSS75XMSDU4GF3FWE3XTTMRG2UINVKRQC","T64LKJ2RTUDFYSJQI7KF4WHZYXZHNEGNOS7ZMMCRIQZ4YN5LOOMAC","45AUHCDJX5A54AYFMJRGDHKMBQ3WYBIPAVPDPY7TCLK5WN5TSROQC","LX7EZ6TKJCQI3K7SV56WMTPFY672WN5UOBGXKKXQI7S73GMWNNXAC"]},"hunks":[{"Replacement":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":6,"ins":{"up_context":[{"change":3,"pos":3372}],"down_context":[{"change":3,"pos":3386}],"flag":"BLOCK","start":0,"end":36,"inode":{"change":3,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3372},"to":{"change":3,"start":3372,"end":3386},"introduced_by":3}],"inode":{"change":3,"pos":3238}},"ins_contents":[{"Add":"use std::mem::{self, ManuallyDrop};"}],"del_contents":[{"Del":"use std::mem;\n"}]}},{"Replacement":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":21,"ins":{"up_context":[{"change":3,"pos":1280}],"down_context":[{"change":3,"pos":3929}],"flag":"BLOCK","start":37,"end":82,"inode":{"change":3,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1280},"to":{"change":3,"start":0,"end":31},"introduced_by":3}],"inode":{"change":3,"pos":3238}},"ins_contents":[{"Add":" inner: ManuallyDrop>>,"}],"del_contents":[{"Del":" inner: Box>,\n"}]}},{"Edit":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":84,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":743}],"down_context":[{"change":2,"pos":0}],"flag":"BLOCK","start":83,"end":126,"inode":{"change":3,"pos":3238}}},"contents":[{"Add":" object_drop: object_drop::,"}]}},{"Replacement":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":94,"ins":{"up_context":[{"change":3,"pos":972}],"down_context":[{"change":3,"pos":390}],"flag":"BLOCK","start":127,"end":283,"inode":{"change":3,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":972},"to":{"change":3,"start":972,"end":1071},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":1071},"to":{"change":3,"start":5181,"end":5191},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":5181},"to":{"change":3,"start":5181,"end":5191},"introduced_by":3}],"inode":{"change":3,"pos":3238}},"ins_contents":[{"Add":" let erased = mem::transmute::>, Box>>(inner);"},{"Add":" let inner = ManuallyDrop::new(erased);"},{"Add":" Error { inner }"}],"del_contents":[{"Del":" Error {\n inner: mem::transmute::>, Box>>(inner),\n"},{"Del":" }\n"}]}},{"Replacement":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":386,"ins":{"up_context":[{"change":3,"pos":9106}],"down_context":[{"change":3,"pos":9168}],"flag":"BLOCK","start":284,"end":470,"inode":{"change":3,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":9106},"to":{"change":3,"start":9106,"end":9168},"introduced_by":3}],"inode":{"change":3,"pos":3238}},"ins_contents":[{"Add":" unsafe {"},{"Add":" let inner = ptr::read(&mut self.inner);"},{"Add":" let erased = ManuallyDrop::into_inner(inner);"},{"Add":" (erased.vtable.object_drop)(erased);"},{"Add":" }"}],"del_contents":[{"Del":" unsafe { ptr::drop_in_place(self.inner.error_mut()) }\n"}]}},{"Edit":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":395,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":195}],"down_context":[{"change":2,"pos":91}],"flag":"BLOCK","start":471,"end":519,"inode":{"change":3,"pos":3238}}},"contents":[{"Add":" object_drop: unsafe fn(Box>),"}]}},{"Edit":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":398,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":251}],"down_context":[{"change":3,"pos":361}],"flag":"BLOCK","start":520,"end":794,"inode":{"change":3,"pos":3238}}},"contents":[{"Add":"}"},{"Add":""},{"Add":"unsafe fn object_drop(e: Box>) {"},{"Add":" // Cast back to ErrorImpl so that the allocator receives the correct"},{"Add":" // Layout to deallocate the Box's memory."},{"Add":" let unerased = mem::transmute::>, Box>>(e);"},{"Add":" drop(unerased);"}]}}],"owner":"yaahc","repo":"eyre","token":"/neChRnh7gfTxX2MTK7o0sGzCiyqNc+zpUHpUgnPOiY=","login":null}

…

Dependencies

Change contents