{"header":{"message":"Move TypeId out of the Box allocation\n","description":null,"timestamp":"2019-10-27T22:18:49Z","authors":[{"email":"dtolnay@gmail.com","name":"David Tolnay"}]},"hash":"TOXJRHV7ZUPHWXCA4TAG3YRBTIPUZQ5BNX34D3VD2JAIYLRN6XSAC","authors":[],"deps":{"hashes":[["TOXJRHV7ZUPHWXCA4TAG3YRBTIPUZQ5BNX34D3VD2JAIYLRN6XSAC","Move TypeId out of the Box allocation\n"],["AA",null],["UPPVYBGC7MQBUCAAB6KW3R5KWHGASFTTXVUHEWRNP27SK3CI7UHQC","Introduce safe from_std and matching from_adhoc\n"],["CZP5PD5NYLDULLW43VOL6V75CH6DDEJO7H6JSGQSIV2WNSQF4A6QC","Rename vtable object ref and mut methods that are no longer raw ptr\n"],["ZKAEZKAMMQWPQIV6X2CFQUUOG7RBJOE3MNXLBH4J3ZASUYTCZJAQC","Move ContextError to error.rs in preparation for refactor\n"],["T64LKJ2RTUDFYSJQI7KF4WHZYXZHNEGNOS7ZMMCRIQZ4YN5LOOMAC","Fix potential UB by removing reliance on trait object layout\n\nAdds a raw vtable object (similar to `RawWakerVTable`) that is manually\ncreated and has methods to dynamically cast to `dyn StdError`.\n"],["ZDN7BJ3JA3VL4AYWX3SV24GHP6NCAETJVAKAXKMIZTLHTWLUNMOQC","Detect nightly and only expose backtrace if available\n"],["LX7EZ6TKJCQI3K7SV56WMTPFY672WN5UOBGXKKXQI7S73GMWNNXAC","Change Error::construct to unsafe fn because TypeId must be correct\n"],["UM7DFUYLW4HSMBUDZY3R6ZNJRSX2E75C4DYV3MJAU57EUCGE6JLAC","Rename Exception to Error\n"],["EXRAFG37562NH775A4LDPP5FNKXLPLIZSJ3FCOBINUDKRFBJHCXAC","Move trait bounds to where-clauses\n\nI find it more readable how this appears in rustdoc.\n"],["54BF5IRL5TKLYRGI6G4LSYEQZ24XRHVST6VIYGGDP6CCJDWO7ZQAC","Unconditionally store Option\n"],["CITEDKPB6MKVZUEYEDE5ZKTNVY35HCOAXKDPYG7YLLEOVFNMSRXQC","Import implementation from fehler 1.0.0-alpha.1\n"],["GZZOJ7ZUSBPI3HXIV5UCFNMCDAMZPPLISY2UDV73FDN74HZ3AWJAC","Format with rustfmt 2019-09-08\n"],["UV757IN647TV4DBKTK2QYSGVFPM7W7M6MBU3CDDGIOICNNWK33GQC","Format with rustfmt 2019-09-08\n"],["F5MLEQJFOB443KKN22TYYJN2TR52653MD4VXSEYZQBNWWJYES5VQC","Update vtable function names to match the implementation names\n"],["NPOFDGQF4CE72IZBT5Y7KPIBHWPPNOEPBYD5RTUHSVUJ2W4XFRVQC","Deallocate ErrorImpl with the right Layout\n"],["Z4YYQXEE4OQPF22I4LD7RVQIBKK67AHCYR6C35MANUCIC4P3EPYQC","Deallocate with the right Layout during downcast\n"],["7JZIPWVKXY3QA5QMTP24WPR7KKMMVXIHAQ4EGHNGCE7H4CRKROCAC","Remove a layer of wrapping from debug mode backtraces\n"],["RIKD63GT7RFV3UAV4BYD57GFXKXALWUP6J7AAHB3M6JVAZ3WFTXAC","Add conversion from Error to Box\n"],["4WK6FVX6HW5QUQOJ7K6MCHGXZJ4WCP5BFHWKXEGIH4ANR42SRD7QC","Remove use of attributes on function parameters\n\nThis has been stabilized in nightly but has not yet reached a stable\nchannel release yet.\n"],["UR5XDZ3SS7QXSUFAYQDYUXX4QDROIYVXUH3Z24F6PAWJDNODAZYAC","Rename InnerException to ErrorImpl\n"],["CI66AAY6BN4S65RNWUAZWSVGRUDZ6C3P2KVGXETUS342L5KGPRHQC","Shrink backtrace capture unsafe block\n"],["3LI5FAF5ULXOWBMTG4XCUOMUPVROSFDY6FWGE574OH4JGPMOPNVAC","Import std::error::Error as StdError\n\nTo avoid name collisions when renaming Exception to Error.\n"],["KCOCFOS6KMCTVS6K3WE6KOQSWC3QNWN2E36ASHQPP3Z3H4BHR3NQC","Support context on Option\n"],["4SNDY6U7TDCVRCARTEQ7JLATJFDMUMEFV2GSLKMQJY7RFNPU5HDQC","Fix UB when accessing errors with large alignment\n"],["T7TIYYVIKIUTGJZQDO47KN4643XSYSGC4LDE2FJDQ47GG5GCVWPAC","Move Error::new backtrace capture to backtrace_if_absent macro\n"],["VSLQNAQBAGOJC2IV55V3W755UIPN47J4RTCCLCABRFFFUU5LT2JQC","Also move Error and Chain to get usable paths in diagnostics\n"],["W655S25G7CGI4XOZ2PKITKTH26VJ4QMZFRV2RPYNI4KIUJOIGVMAC","Change all remaining exception related wording\n"]],"deps":["UPPVYBGC7MQBUCAAB6KW3R5KWHGASFTTXVUHEWRNP27SK3CI7UHQC","CZP5PD5NYLDULLW43VOL6V75CH6DDEJO7H6JSGQSIV2WNSQF4A6QC","ZKAEZKAMMQWPQIV6X2CFQUUOG7RBJOE3MNXLBH4J3ZASUYTCZJAQC"],"known":["CITEDKPB6MKVZUEYEDE5ZKTNVY35HCOAXKDPYG7YLLEOVFNMSRXQC","GZZOJ7ZUSBPI3HXIV5UCFNMCDAMZPPLISY2UDV73FDN74HZ3AWJAC","3LI5FAF5ULXOWBMTG4XCUOMUPVROSFDY6FWGE574OH4JGPMOPNVAC","UM7DFUYLW4HSMBUDZY3R6ZNJRSX2E75C4DYV3MJAU57EUCGE6JLAC","UR5XDZ3SS7QXSUFAYQDYUXX4QDROIYVXUH3Z24F6PAWJDNODAZYAC","W655S25G7CGI4XOZ2PKITKTH26VJ4QMZFRV2RPYNI4KIUJOIGVMAC","EXRAFG37562NH775A4LDPP5FNKXLPLIZSJ3FCOBINUDKRFBJHCXAC","CI66AAY6BN4S65RNWUAZWSVGRUDZ6C3P2KVGXETUS342L5KGPRHQC","ZDN7BJ3JA3VL4AYWX3SV24GHP6NCAETJVAKAXKMIZTLHTWLUNMOQC","7JZIPWVKXY3QA5QMTP24WPR7KKMMVXIHAQ4EGHNGCE7H4CRKROCAC","4WK6FVX6HW5QUQOJ7K6MCHGXZJ4WCP5BFHWKXEGIH4ANR42SRD7QC","54BF5IRL5TKLYRGI6G4LSYEQZ24XRHVST6VIYGGDP6CCJDWO7ZQAC","T64LKJ2RTUDFYSJQI7KF4WHZYXZHNEGNOS7ZMMCRIQZ4YN5LOOMAC","T7TIYYVIKIUTGJZQDO47KN4643XSYSGC4LDE2FJDQ47GG5GCVWPAC","LX7EZ6TKJCQI3K7SV56WMTPFY672WN5UOBGXKKXQI7S73GMWNNXAC","UV757IN647TV4DBKTK2QYSGVFPM7W7M6MBU3CDDGIOICNNWK33GQC","KCOCFOS6KMCTVS6K3WE6KOQSWC3QNWN2E36ASHQPP3Z3H4BHR3NQC","F5MLEQJFOB443KKN22TYYJN2TR52653MD4VXSEYZQBNWWJYES5VQC","NPOFDGQF4CE72IZBT5Y7KPIBHWPPNOEPBYD5RTUHSVUJ2W4XFRVQC","Z4YYQXEE4OQPF22I4LD7RVQIBKK67AHCYR6C35MANUCIC4P3EPYQC","RIKD63GT7RFV3UAV4BYD57GFXKXALWUP6J7AAHB3M6JVAZ3WFTXAC","4SNDY6U7TDCVRCARTEQ7JLATJFDMUMEFV2GSLKMQJY7RFNPU5HDQC","VSLQNAQBAGOJC2IV55V3W755UIPN47J4RTCCLCABRFFFUU5LT2JQC"]},"hunks":[{"Replacement":{"inode":{"change":5,"pos":3238},"path":"src/error.rs","line":30,"ins":{"up_context":[{"change":2,"pos":241}],"down_context":[{"change":5,"pos":42}],"flag":"BLOCK","start":0,"end":311,"inode":{"change":5,"pos":3238}},"del":{"edges":[{"previous":"","flag":"DELETED","from":{"change":2,"pos":241},"to":{"change":5,"start":0,"end":41},"introduced_by":2},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":4341},"to":{"change":5,"start":0,"end":41},"introduced_by":5}],"inode":{"change":5,"pos":3238}},"ins_contents":[{"Add":" let vtable = &ErrorVTable {"},{"Add":" object_drop: object_drop::,"},{"Add":" object_drop_front: object_drop_front::,"},{"Add":" object_ref: object_ref::,"},{"Add":" object_mut: object_mut::,"},{"Add":" object_boxed: object_boxed::,"},{"Add":" object_is: object_is::,"},{"Add":" };"}],"del_contents":[{"Del":" let type_id = TypeId::of::();\n"}]}},{"Replacement":{"inode":{"change":5,"pos":3238},"path":"src/error.rs","line":39,"ins":{"up_context":[{"change":5,"pos":43}],"down_context":[{"change":5,"pos":4396}],"flag":"BLOCK","start":312,"end":443,"inode":{"change":5,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":43},"to":{"change":5,"start":43,"end":98},"introduced_by":5},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":98},"to":{"change":5,"start":0,"end":63},"introduced_by":5}],"inode":{"change":5,"pos":3238}},"ins_contents":[{"Add":" // Safety: passing vtable that operates on the right type E."},{"Add":" unsafe { Error::construct(error, vtable, backtrace) }"}],"del_contents":[{"Del":" // Safety: passing typeid of the right type E.\n"},{"Del":" unsafe { Error::construct(error, type_id, backtrace) }\n"}]}},{"Replacement":{"inode":{"change":5,"pos":3238},"path":"src/error.rs","line":48,"ins":{"up_context":[{"change":5,"pos":225}],"down_context":[{"change":5,"pos":266}],"flag":"BLOCK","start":444,"end":825,"inode":{"change":5,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":225},"to":{"change":5,"start":225,"end":266},"introduced_by":5}],"inode":{"change":5,"pos":3238}},"ins_contents":[{"Add":" let vtable = &ErrorVTable {"},{"Add":" object_drop: object_drop::>,"},{"Add":" object_drop_front: object_drop_front::>,"},{"Add":" object_ref: object_ref::>,"},{"Add":" object_mut: object_mut::>,"},{"Add":" object_boxed: object_boxed::>,"},{"Add":" object_is: object_is::,"},{"Add":" };"}],"del_contents":[{"Del":" let type_id = TypeId::of::();\n"}]}},{"Replacement":{"inode":{"change":5,"pos":3238},"path":"src/error.rs","line":57,"ins":{"up_context":[{"change":5,"pos":267}],"down_context":[{"change":5,"pos":1044}],"flag":"BLOCK","start":826,"end":1024,"inode":{"change":5,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":267},"to":{"change":5,"start":267,"end":347},"introduced_by":5},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":347},"to":{"change":5,"start":933,"end":1044},"introduced_by":5}],"inode":{"change":5,"pos":3238}},"ins_contents":[{"Add":" // Safety: MessageError is repr(transparent) so it is okay for the"},{"Add":" // vtable to allow casting the MessageError to M."},{"Add":" unsafe { Error::construct(error, vtable, backtrace) }"}],"del_contents":[{"Del":" // Safety: MessageError is repr(transparent) so MessageError has the\n"},{"Del":" // same layout as the typeid specifies.\n unsafe { Error::construct(error, type_id, backtrace) }\n"}]}},{"Replacement":{"inode":{"change":5,"pos":3238},"path":"src/error.rs","line":67,"ins":{"up_context":[{"change":5,"pos":1238}],"down_context":[{"change":5,"pos":1279}],"flag":"BLOCK","start":1025,"end":1406,"inode":{"change":5,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":1238},"to":{"change":5,"start":1238,"end":1279},"introduced_by":5}],"inode":{"change":5,"pos":3238}},"ins_contents":[{"Add":" let vtable = &ErrorVTable {"},{"Add":" object_drop: object_drop::>,"},{"Add":" object_drop_front: object_drop_front::>,"},{"Add":" object_ref: object_ref::>,"},{"Add":" object_mut: object_mut::>,"},{"Add":" object_boxed: object_boxed::>,"},{"Add":" object_is: object_is::,"},{"Add":" };"}],"del_contents":[{"Del":" let type_id = TypeId::of::();\n"}]}},{"Replacement":{"inode":{"change":5,"pos":3238},"path":"src/error.rs","line":76,"ins":{"up_context":[{"change":5,"pos":1280}],"down_context":[{"change":4,"pos":81}],"flag":"BLOCK","start":1407,"end":1605,"inode":{"change":5,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":1280},"to":{"change":5,"start":1280,"end":1360},"introduced_by":5},{"previous":"","flag":"DELETED","from":{"change":5,"pos":1360},"to":{"change":5,"start":347,"end":395},"introduced_by":5},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":347},"to":{"change":5,"start":347,"end":395},"introduced_by":5},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":395},"to":{"change":5,"start":64,"end":127},"introduced_by":5}],"inode":{"change":5,"pos":3238}},"ins_contents":[{"Add":" // Safety: DisplayError is repr(transparent) so it is okay for the"},{"Add":" // vtable to allow casting the DisplayError to M."},{"Add":" unsafe { Error::construct(error, vtable, backtrace) }"}],"del_contents":[{"Del":" // Safety: DisplayError is repr(transparent) so DisplayError has the\n"},{"Del":" // same layout as the typeid specifies.\n"},{"Del":" unsafe { Error::construct(error, type_id, backtrace) }\n"}]}},{"Replacement":{"inode":{"change":5,"pos":3238},"path":"src/error.rs","line":92,"ins":{"up_context":[{"change":5,"pos":486}],"down_context":[{"change":5,"pos":910}],"flag":"BLOCK","start":1606,"end":1846,"inode":{"change":5,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":486},"to":{"change":5,"start":486,"end":706},"introduced_by":5}],"inode":{"change":5,"pos":3238}},"ins_contents":[{"Add":" // Unsafe because the given vtable must have sensible behavior on the error"},{"Add":" // value of type E."},{"Add":" unsafe fn construct("},{"Add":" error: E,"},{"Add":" vtable: &'static ErrorVTable,"},{"Add":" backtrace: Option,"},{"Add":" ) -> Self"}],"del_contents":[{"Del":" // Unsafe because the type represented by type_id must have the same layout\n // as E or else we allow invalid downcasts.\n unsafe fn construct(error: E, type_id: TypeId, backtrace: Option) -> Self\n"}]}},{"Edit":{"inode":{"change":5,"pos":3238},"path":"src/error.rs","line":102,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":4726},"to":{"change":5,"start":707,"end":743},"introduced_by":5},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":743},"to":{"change":5,"start":83,"end":126},"introduced_by":5},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":126},"to":{"change":5,"start":0,"end":55},"introduced_by":5},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":55},"to":{"change":3,"start":0,"end":82},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":82},"to":{"change":5,"start":0,"end":45},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":90},"to":{"change":5,"start":0,"end":45},"introduced_by":5},{"previous":"","flag":"DELETED","from":{"change":5,"pos":45},"to":{"change":5,"start":825,"end":836},"introduced_by":5},{"previous":"","flag":"DELETED","from":{"change":5,"pos":90},"to":{"change":5,"start":825,"end":836},"introduced_by":5},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":825},"to":{"change":5,"start":825,"end":836},"introduced_by":5}],"inode":{"change":5,"pos":3238}}},"contents":[{"Del":" let vtable = &ErrorVTable {\n"},{"Del":" object_drop: object_drop::,\n"},{"Del":" object_drop_front: object_drop_front::,\n"},{"Del":" object_ref: object_ref::,\n object_mut: object_mut::,\n"},{"Del":" object_boxed: object_boxed::,\n"},{"Del":" };\n"}]}},{"Edit":{"inode":{"change":5,"pos":3238},"path":"src/error.rs","line":104,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":897},"to":{"change":5,"start":897,"end":918},"introduced_by":5}],"inode":{"change":5,"pos":3238}}},"contents":[{"Del":" type_id,\n"}]}},{"Replacement":{"inode":{"change":5,"pos":3238},"path":"src/error.rs","line":236,"ins":{"up_context":[{"change":5,"pos":918}],"down_context":[{"change":5,"pos":6434}],"flag":"BLOCK","start":1847,"end":1944,"inode":{"change":5,"pos":3238}},"del":{"edges":[{"previous":"","flag":"DELETED","from":{"change":5,"pos":918},"to":{"change":5,"start":6386,"end":6434},"introduced_by":5},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":6386},"to":{"change":5,"start":6386,"end":6434},"introduced_by":5}],"inode":{"change":5,"pos":3238}},"ins_contents":[{"Add":" let target = TypeId::of::();"},{"Add":" unsafe { (self.inner.vtable.object_is)(target) }"}],"del_contents":[{"Del":" TypeId::of::() == self.inner.type_id\n"}]}},{"Edit":{"inode":{"change":5,"pos":3238},"path":"src/error.rs","line":380,"atom":{"NewVertex":{"up_context":[{"change":5,"pos":304}],"down_context":[{"change":5,"pos":520}],"flag":"BLOCK","start":1945,"end":1987,"inode":{"change":5,"pos":3238}}},"contents":[{"Add":" object_is: unsafe fn(TypeId) -> bool,"}]}},{"Edit":{"inode":{"change":5,"pos":3238},"path":"src/error.rs","line":419,"atom":{"NewVertex":{"up_context":[{"change":5,"pos":674}],"down_context":[{"change":5,"pos":9177}],"flag":"BLOCK","start":1988,"end":2094,"inode":{"change":5,"pos":3238}}},"contents":[{"Add":"unsafe fn object_is(target: TypeId) -> bool"},{"Add":"where"},{"Add":" T: 'static,"},{"Add":"{"},{"Add":" TypeId::of::() == target"},{"Add":"}"},{"Add":""}]}},{"Edit":{"inode":{"change":5,"pos":3238},"path":"src/error.rs","line":430,"atom":{"EdgeMap":{"edges":[{"previous":"","flag":"DELETED","from":{"change":5,"pos":709},"to":{"change":5,"start":9297,"end":9318},"introduced_by":5},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":9297},"to":{"change":5,"start":9297,"end":9318},"introduced_by":5}],"inode":{"change":5,"pos":3238}}},"contents":[{"Del":" type_id: TypeId,\n"}]}}],"owner":"yaahc","repo":"eyre","token":"RMgAJN0ftUG1ulJMgeXsLZafeXexVS0FwfkTkRYmj4c=","login":null}

…

Dependencies

Change contents