{"header":{"message":"Deallocate with the right Layout during downcast\n","description":null,"timestamp":"2019-10-08T16:13:29Z","authors":[{"email":"dtolnay@gmail.com","name":"David Tolnay"}]},"hash":"Z4YYQXEE4OQPF22I4LD7RVQIBKK67AHCYR6C35MANUCIC4P3EPYQC","authors":[],"deps":{"hashes":[["Z4YYQXEE4OQPF22I4LD7RVQIBKK67AHCYR6C35MANUCIC4P3EPYQC","Deallocate with the right Layout during downcast\n"],["AA",null],["NPOFDGQF4CE72IZBT5Y7KPIBHWPPNOEPBYD5RTUHSVUJ2W4XFRVQC","Deallocate ErrorImpl with the right Layout\n"],["CITEDKPB6MKVZUEYEDE5ZKTNVY35HCOAXKDPYG7YLLEOVFNMSRXQC","Import implementation from fehler 1.0.0-alpha.1\n"],["SZMWAJGIDYMGTPMWSW22NLZ3VRXA2BATFUTMSWOGH337EFYBTWQAC","Use Self in signatures of Error constructors\n"],["EXRAFG37562NH775A4LDPP5FNKXLPLIZSJ3FCOBINUDKRFBJHCXAC","Move trait bounds to where-clauses\n\nI find it more readable how this appears in rustdoc.\n"],["W655S25G7CGI4XOZ2PKITKTH26VJ4QMZFRV2RPYNI4KIUJOIGVMAC","Change all remaining exception related wording\n"],["UM7DFUYLW4HSMBUDZY3R6ZNJRSX2E75C4DYV3MJAU57EUCGE6JLAC","Rename Exception to Error\n"],["F5MLEQJFOB443KKN22TYYJN2TR52653MD4VXSEYZQBNWWJYES5VQC","Update vtable function names to match the implementation names\n"]],"deps":["NPOFDGQF4CE72IZBT5Y7KPIBHWPPNOEPBYD5RTUHSVUJ2W4XFRVQC"],"known":["CITEDKPB6MKVZUEYEDE5ZKTNVY35HCOAXKDPYG7YLLEOVFNMSRXQC","UM7DFUYLW4HSMBUDZY3R6ZNJRSX2E75C4DYV3MJAU57EUCGE6JLAC","W655S25G7CGI4XOZ2PKITKTH26VJ4QMZFRV2RPYNI4KIUJOIGVMAC","EXRAFG37562NH775A4LDPP5FNKXLPLIZSJ3FCOBINUDKRFBJHCXAC","SZMWAJGIDYMGTPMWSW22NLZ3VRXA2BATFUTMSWOGH337EFYBTWQAC"]},"hunks":[{"Edit":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":85,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":126}],"down_context":[{"change":9,"pos":0}],"flag":"BLOCK","start":0,"end":55,"inode":{"change":3,"pos":3238}}},"contents":[{"Add":" object_drop_front: object_drop_front::,"}]}},{"Replacement":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":241,"ins":{"up_context":[{"change":3,"pos":1036}],"down_context":[{"change":3,"pos":6655}],"flag":"BLOCK","start":56,"end":133,"inode":{"change":3,"pos":3238}},"del":{"edges":[{"previous":"","flag":"DELETED","from":{"change":3,"pos":1036},"to":{"change":3,"start":6599,"end":6655},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":1863},"to":{"change":3,"start":6599,"end":6655},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":6599},"to":{"change":3,"start":6599,"end":6655},"introduced_by":3}],"inode":{"change":3,"pos":3238}},"ins_contents":[{"Add":" if self.is::() {"},{"Add":" let outer = ManuallyDrop::new(self);"}],"del_contents":[{"Del":" if let Some(error) = self.downcast_ref::() {\n"}]}},{"Replacement":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":244,"ins":{"up_context":[{"change":3,"pos":6676}],"down_context":[{"change":3,"pos":6803}],"flag":"BLOCK","start":134,"end":392,"inode":{"change":3,"pos":3238}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":6676},"to":{"change":3,"start":6676,"end":6803},"introduced_by":3}],"inode":{"change":3,"pos":3238}},"ins_contents":[{"Add":" let error = ptr::read(&outer.inner.error as *const () as *const E);"},{"Add":" let inner = ptr::read(&outer.inner);"},{"Add":" let erased = ManuallyDrop::into_inner(inner);"},{"Add":" (erased.vtable.object_drop_front)(erased);"}],"del_contents":[{"Del":" let error = ptr::read(error);\n drop(ptr::read(&self.inner));\n mem::forget(self);\n"}]}},{"Edit":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":399,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":519}],"down_context":[{"change":9,"pos":91}],"flag":"BLOCK","start":393,"end":447,"inode":{"change":3,"pos":3238}}},"contents":[{"Add":" object_drop_front: unsafe fn(Box>),"}]}},{"Edit":{"inode":{"change":3,"pos":3238},"path":"src/error.rs","line":408,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":774}],"down_context":[{"change":2,"pos":774}],"flag":"BLOCK","start":448,"end":818,"inode":{"change":3,"pos":3238}}},"contents":[{"Add":" drop(unerased);"},{"Add":"}"},{"Add":""},{"Add":"unsafe fn object_drop_front(e: Box>) {"},{"Add":" // Drop the fields of ErrorImpl other than E as well as the Box allocation,"},{"Add":" // without dropping E itself. This is used by downcast after doing a"},{"Add":" // ptr::read to take ownership of the E."},{"Add":" let unerased = mem::transmute::>, Box>>>(e);"}]}}],"owner":"yaahc","repo":"eyre","token":"pzLQ95OQQfLDRtHOFKdlDDuhEaEB1rLOJabHLd6MBEw=","login":null}

…

Dependencies

Change contents