{"header":{"message":"rocket: User sign up guard forwards over failures\n\nWhen no user can be found, the User implementation of FromRequest was failing,\nwhich is a mistake. This meant that no other routes were tried and thus assigning\npolicies to routes failed. This changes fixes that by forwarding instead. To be\nfrank, this is over forwarding, and can still be improved on.\n","description":null,"timestamp":"2021-10-07T14:35:03.431743Z","authors":[{}]},"hash":"Y52KSJEFIX7KIL3MWH65WKHKXIX34T3VUSBVH2SBJ4ZJHM767J4AC","authors":[{"login":"zj","key":"HJTTxR4pkDDL4TSRKMxQ3hWM2wopn7HM1y1hFeYKuzA2"}],"deps":{"hashes":[["Y52KSJEFIX7KIL3MWH65WKHKXIX34T3VUSBVH2SBJ4ZJHM767J4AC","rocket: User sign up guard forwards over failures\n\nWhen no user can be found, the User implementation of FromRequest was failing,\nwhich is a mistake. This meant that no other routes were tried and thus assigning\npolicies to routes failed. This changes fixes that by forwarding instead. To be\nfrank, this is over forwarding, and can still be improved on.\n"],["AA",null],["E4OBIIUBGNDXK577XK573TLN4DYLS32GJGXY6J7TOWFHESTEZZNAC","templates: Fix navigation mocks\n\nCleans up the directory structure for templates and fixes the navigation bugs in\nthe applications too. \n\nIncludes a context! macro which is lifted from upstream, but is currently\nunreleased. When rocket_dyn_templates is updates, it could be DRY'ed out.\n"],["KFVJ3KMWXEGILN4NWIWPPX7AU65M4H4UEAUIAQL2QSXOW3B5RFGQC","frontend: Introduce navigation bar\n\nMinor changes to the front-end mostly, to allow users to\nregister, sign in, and sign out. The sign out route is changed\nto a GET endpoint, as links in HTML cannot DELETE.\n"],["RJ75MX6YMJSXYKW2YK6ZJNG2SQMPCPKICMESMC4ZD4EB2SCVJ2KAC","routes: Move user routes to controllers module\n\nThe last routes to move, the src directory now only has a main.rs file and\ndirectories.\n"]],"deps":["E4OBIIUBGNDXK577XK573TLN4DYLS32GJGXY6J7TOWFHESTEZZNAC"],"known":["KFVJ3KMWXEGILN4NWIWPPX7AU65M4H4UEAUIAQL2QSXOW3B5RFGQC","RJ75MX6YMJSXYKW2YK6ZJNG2SQMPCPKICMESMC4ZD4EB2SCVJ2KAC"]},"hunks":[{"Replacement":{"inode":{"change":3,"pos":1622},"path":"templates/landing.html.tera","line":11,"ins":{"up_context":[{"change":2,"pos":2713}],"down_context":[{"change":2,"pos":2814}],"flag":"BLOCK","start":0,"end":97,"inode":{"change":3,"pos":1622}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":2713},"to":{"change":2,"start":2713,"end":2814},"introduced_by":2}],"inode":{"change":3,"pos":1622}},"ins_contents":[{"Add":{"text":" Sign up","pos":"Y52KSJEFIX7KIL3MWH65WKHKXIX34T3VUSBVH2SBJ4ZJHM767J4AC:96"}}],"del_contents":[{"Del":{"text":" Sign up","pos":"E4OBIIUBGNDXK577XK573TLN4DYLS32GJGXY6J7TOWFHESTEZZNAC:2813"}}]}},{"Edit":{"inode":{"change":3,"pos":33},"path":"src/controllers/users.rs","line":13,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":327},"to":{"change":3,"start":327,"end":362},"introduced_by":3}],"inode":{"change":3,"pos":33}}},"contents":[{"Del":{"text":"","pos":"RJ75MX6YMJSXYKW2YK6ZJNG2SQMPCPKICMESMC4ZD4EB2SCVJ2KAC:327"}},{"Del":{"text":"use rocket::outcome::try_outcome;","pos":"RJ75MX6YMJSXYKW2YK6ZJNG2SQMPCPKICMESMC4ZD4EB2SCVJ2KAC:361"}}]}},{"Replacement":{"inode":{"change":3,"pos":33},"path":"src/controllers/users.rs","line":20,"ins":{"up_context":[{"change":3,"pos":518}],"down_context":[{"change":3,"pos":735}],"flag":"BLOCK","start":98,"end":368,"inode":{"change":3,"pos":33}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":518},"to":{"change":3,"start":518,"end":735},"introduced_by":3}],"inode":{"change":3,"pos":33}},"ins_contents":[{"Add":{"text":" async fn from_request(request: &'r Request<'_>) -> request::Outcome {","pos":"Y52KSJEFIX7KIL3MWH65WKHKXIX34T3VUSBVH2SBJ4ZJHM767J4AC:181"}},{"Add":{"text":" let db: &State = match request.guard().await {","pos":"Y52KSJEFIX7KIL3MWH65WKHKXIX34T3VUSBVH2SBJ4ZJHM767J4AC:246"}},{"Add":{"text":" Outcome::Success(db) => db,","pos":"Y52KSJEFIX7KIL3MWH65WKHKXIX34T3VUSBVH2SBJ4ZJHM767J4AC:286"}},{"Add":{"text":" _ => return Outcome::Failure((Status::Unauthorized, ())),","pos":"Y52KSJEFIX7KIL3MWH65WKHKXIX34T3VUSBVH2SBJ4ZJHM767J4AC:356"}},{"Add":{"text":" };","pos":"Y52KSJEFIX7KIL3MWH65WKHKXIX34T3VUSBVH2SBJ4ZJHM767J4AC:367"}}],"del_contents":[{"Del":{"text":" async fn from_request(request: &'r Request<'_>) -> request::Outcome {","pos":"RJ75MX6YMJSXYKW2YK6ZJNG2SQMPCPKICMESMC4ZD4EB2SCVJ2KAC:610"}},{"Del":{"text":" let db = try_outcome!(request.guard::<&State>().await);","pos":"RJ75MX6YMJSXYKW2YK6ZJNG2SQMPCPKICMESMC4ZD4EB2SCVJ2KAC:684"}},{"Del":{"text":" // &State>().await);","pos":"RJ75MX6YMJSXYKW2YK6ZJNG2SQMPCPKICMESMC4ZD4EB2SCVJ2KAC:734"}}]}},{"Replacement":{"inode":{"change":3,"pos":33},"path":"src/controllers/users.rs","line":29,"ins":{"up_context":[{"change":3,"pos":868}],"down_context":[{"change":3,"pos":941}],"flag":"BLOCK","start":369,"end":418,"inode":{"change":3,"pos":33}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":868},"to":{"change":3,"start":868,"end":941},"introduced_by":3}],"inode":{"change":3,"pos":33}},"ins_contents":[{"Add":{"text":" None => return Outcome::Forward(()),","pos":"Y52KSJEFIX7KIL3MWH65WKHKXIX34T3VUSBVH2SBJ4ZJHM767J4AC:417"}}],"del_contents":[{"Del":{"text":" None => return Outcome::Failure((Status::Unauthorized, ())),","pos":"RJ75MX6YMJSXYKW2YK6ZJNG2SQMPCPKICMESMC4ZD4EB2SCVJ2KAC:940"}}]}},{"Replacement":{"inode":{"change":3,"pos":33},"path":"src/controllers/users.rs","line":34,"ins":{"up_context":[{"change":3,"pos":1041}],"down_context":[{"change":3,"pos":1110}],"flag":"BLOCK","start":419,"end":490,"inode":{"change":3,"pos":33}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1041},"to":{"change":3,"start":1041,"end":1110},"introduced_by":3}],"inode":{"change":3,"pos":33}},"ins_contents":[{"Add":{"text":" Err(_e) => Outcome::Forward(()), // TODO this is a failure","pos":"Y52KSJEFIX7KIL3MWH65WKHKXIX34T3VUSBVH2SBJ4ZJHM767J4AC:489"}}],"del_contents":[{"Del":{"text":" Err(_e) => Outcome::Failure((Status::Unauthorized, ())),","pos":"RJ75MX6YMJSXYKW2YK6ZJNG2SQMPCPKICMESMC4ZD4EB2SCVJ2KAC:1109"}}]}},{"Edit":{"inode":{"change":3,"pos":33},"path":"src/controllers/users.rs","line":39,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":1129}],"down_context":[{"change":3,"pos":1129}],"flag":"BLOCK","start":491,"end":594,"inode":{"change":3,"pos":33}}},"contents":[{"Add":{"text":"#[get(\"/users/new\", rank = 1)]","pos":"Y52KSJEFIX7KIL3MWH65WKHKXIX34T3VUSBVH2SBJ4ZJHM767J4AC:521"}},{"Add":{"text":"fn new_already_user(_user: User) -> Redirect {","pos":"Y52KSJEFIX7KIL3MWH65WKHKXIX34T3VUSBVH2SBJ4ZJHM767J4AC:568"}},{"Add":{"text":" Redirect::to(\"/\")","pos":"Y52KSJEFIX7KIL3MWH65WKHKXIX34T3VUSBVH2SBJ4ZJHM767J4AC:590"}},{"Add":{"text":"}","pos":"Y52KSJEFIX7KIL3MWH65WKHKXIX34T3VUSBVH2SBJ4ZJHM767J4AC:592"}},{"Add":{"text":"","pos":"Y52KSJEFIX7KIL3MWH65WKHKXIX34T3VUSBVH2SBJ4ZJHM767J4AC:593"}}]}},{"Edit":{"inode":{"change":3,"pos":33},"path":"src/controllers/users.rs","line":47,"atom":{"EdgeMap":{"edges":[{"previous":"","flag":"DELETED","from":{"change":2,"pos":4280},"to":{"change":3,"start":1237,"end":1340},"introduced_by":2},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1237},"to":{"change":3,"start":1237,"end":1340},"introduced_by":3}],"inode":{"change":3,"pos":33}}},"contents":[{"Del":{"text":"}","pos":"RJ75MX6YMJSXYKW2YK6ZJNG2SQMPCPKICMESMC4ZD4EB2SCVJ2KAC:1238"}},{"Del":{"text":"","pos":"RJ75MX6YMJSXYKW2YK6ZJNG2SQMPCPKICMESMC4ZD4EB2SCVJ2KAC:1239"}},{"Del":{"text":"#[get(\"/users/new\", rank = 1)]","pos":"RJ75MX6YMJSXYKW2YK6ZJNG2SQMPCPKICMESMC4ZD4EB2SCVJ2KAC:1270"}},{"Del":{"text":"fn new_already_user(_user: User) -> Redirect {","pos":"RJ75MX6YMJSXYKW2YK6ZJNG2SQMPCPKICMESMC4ZD4EB2SCVJ2KAC:1317"}},{"Del":{"text":" Redirect::to(\"/\")","pos":"RJ75MX6YMJSXYKW2YK6ZJNG2SQMPCPKICMESMC4ZD4EB2SCVJ2KAC:1339"}}]}}],"owner":"zj","repo":"nidobyte","token":"/N5v5J7gby7cuRsJ45iWK2V9dHuFAXVrB0CPaOUo68k=","login":null}

…

Dependencies

Change contents

Review