Sivecano/dwl - Change ERBETXYU7NGSWW5LHQ3NSJA2N27JNMDDYMZ74B6IVQTEQMLRP6PAC

macroize event handlers

This was a prime candidate for reducing the verbosity of some of our code

Created by Devin J. Pohly on December 27, 2020

ERBETXYU7NGSWW5LHQ3NSJA2N27JNMDDYMZ74B6IVQTEQMLRP6PAC

Dependencies

In channels

main

Change contents

Insertion in dwl.c at line 61 [7.4]

[6.52]

[7.814]

#define LISTEN(E, L, H)         wl_signal_add((E), ((L)->notify = (H), (L)))

Replacement in dwl.c at line 799 [7.4]

B:BD[8.5237] → [9.130:321]

B:BD[9.321] → [3.291:385]

	kb->modifiers.notify = keypressmod;
	wl_signal_add(&device->keyboard->events.modifiers, &kb->modifiers);
	kb->key.notify = keypress;
	wl_signal_add(&device->keyboard->events.key, &kb->key);
	kb->destroy.notify = cleanupkeyboard;
	wl_signal_add(&device->events.destroy, &kb->destroy);

[8.5237]

[8.5452]

	LISTEN(&device->keyboard->events.modifiers, &kb->modifiers, keypressmod);
	LISTEN(&device->keyboard->events.key, &kb->key, keypress);
	LISTEN(&device->events.destroy, &kb->destroy, cleanupkeyboard);

Replacement in dwl.c at line 847 [7.4]

∅:D[10.309] → [11.1819:1903]

B:BD[8.8027] → [11.1819:1903]

B:BD[12.887] → [10.310:401]

	m->frame.notify = rendermon;
	wl_signal_add(&wlr_output->events.frame, &m->frame);
	m->destroy.notify = cleanupmon;
	wl_signal_add(&wlr_output->events.destroy, &m->destroy);

[10.309]

[13.1]

	LISTEN(&wlr_output->events.frame, &m->frame, rendermon);
	LISTEN(&wlr_output->events.destroy, &m->destroy, cleanupmon);

Deletion in dwl.c at line 919 [7.4]

∅:D[14.114] → [15.612:661]

∅:D[16.143] → [15.612:661]

∅:D[12.1017] → [15.612:661]

B:BD[15.612] → [15.612:661]

B:BD[15.661] → [17.334:434]

B:BD[17.434] → [18.70:98]

∅:D[18.98] → [15.690:923]

B:BD[15.690] → [15.690:923]


	/* Listen to the various events it can emit */
	c->commit.notify = commitnotify;
	wl_signal_add(&xdg_surface->surface->events.commit, &c->commit);
	c->map.notify = mapnotify;
	wl_signal_add(&xdg_surface->events.map, &c->map);
	c->unmap.notify = unmapnotify;
	wl_signal_add(&xdg_surface->events.unmap, &c->unmap);
	c->destroy.notify = destroynotify;
	wl_signal_add(&xdg_surface->events.destroy, &c->destroy);

Replacement in dwl.c at line 920 [7.4]

B:BD[19.4] → [19.4:129]

	c->fullscreen.notify = fullscreennotify;
	wl_signal_add(&xdg_surface->toplevel->events.request_fullscreen, &c->fullscreen);

[19.4]

[19.129]

	LISTEN(&xdg_surface->surface->events.commit, &c->commit, commitnotify);
	LISTEN(&xdg_surface->events.map, &c->map, mapnotify);
	LISTEN(&xdg_surface->events.unmap, &c->unmap, unmapnotify);
	LISTEN(&xdg_surface->events.destroy, &c->destroy, destroynotify);
	LISTEN(&xdg_surface->toplevel->events.request_fullscreen, &c->fullscreen,
			fullscreennotify);

Replacement in dwl.c at line 942 [7.4]

∅:D[5.2890] → [20.674:739]

B:BD[21.23695] → [20.674:739]

∅:D[20.739] → [22.1517:1610]

B:BD[22.1517] → [22.1517:1610]

B:BD[21.23829] → [20.740:799]

∅:D[20.799] → [22.1663:1739]

B:BD[22.1663] → [22.1663:1739]

B:BD[22.1739] → [20.800:851]

∅:D[20.851] → [22.1783:1851]

B:BD[22.1783] → [22.1783:1851]

B:BD[22.1851] → [20.852:907]

∅:D[20.907] → [22.1899:1971]

B:BD[22.1899] → [22.1899:1971]

	layersurface->surface_commit.notify = commitlayersurfacenotify;
	wl_signal_add(&wlr_layer_surface->surface->events.commit,
		&layersurface->surface_commit);
	layersurface->destroy.notify = destroylayersurfacenotify;
	wl_signal_add(&wlr_layer_surface->events.destroy, &layersurface->destroy);
	layersurface->map.notify = maplayersurfacenotify;
	wl_signal_add(&wlr_layer_surface->events.map, &layersurface->map);
	layersurface->unmap.notify = unmaplayersurfacenotify;
	wl_signal_add(&wlr_layer_surface->events.unmap, &layersurface->unmap);

[5.2890]

[21.24135]

	LISTEN(&wlr_layer_surface->surface->events.commit,
		&layersurface->surface_commit, commitlayersurfacenotify);
	LISTEN(&wlr_layer_surface->events.destroy, &layersurface->destroy,
			destroylayersurfacenotify);
	LISTEN(&wlr_layer_surface->events.map, &layersurface->map,
			maplayersurfacenotify);
	LISTEN(&wlr_layer_surface->events.unmap, &layersurface->unmap,
			unmaplayersurfacenotify);

Replacement in dwl.c at line 993 [7.4]

B:BD[23.653] → [23.653:850]

	wl_signal_add(&wlr_deco->events.request_mode, &d->request_mode);
	d->request_mode.notify = getxdecomode;
	wl_signal_add(&wlr_deco->events.destroy, &d->destroy);
	d->destroy.notify = destroyxdeco;

[23.608]

[2.59]

	LISTEN(&wlr_deco->events.request_mode, &d->request_mode, getxdecomode);
	LISTEN(&wlr_deco->events.destroy, &d->destroy, destroyxdeco);

Replacement in dwl.c at line 2107 [7.4]

B:BD[24.4278] → [24.4278:4355]

	wl_signal_add(&cursor->events.motion_absolute,
			&cursor_motion_absolute);

[24.4229]

[24.4392]

	wl_signal_add(&cursor->events.motion_absolute, &cursor_motion_absolute);

Insertion in dwl.c at line 2461 [7.4]
[25.2126]
[25.2126]
```
	c->isfullscreen = 0;
```

Replacement in dwl.c at line 2464 [7.4]

B:BD[25.2175] → [18.152:180]

∅:D[18.180] → [25.2204:2461]

B:BD[25.2204] → [25.2204:2461]

B:BD[25.2461] → [4.391:504]

∅:D[4.504] → [25.2461:2561]

B:BD[25.2461] → [25.2461:2561]

B:BD[25.2561] → [26.181:182]

B:BD[26.182] → [27.177:219]

∅:D[27.219] → [26.226:304]

∅:D[28.458] → [26.226:304]

B:BD[26.226] → [26.226:304]

B:BD[26.304] → [29.105:127]

	c->map.notify = mapnotify;
	wl_signal_add(&xwayland_surface->events.map, &c->map);
	c->unmap.notify = unmapnotify;
	wl_signal_add(&xwayland_surface->events.unmap, &c->unmap);
	c->activate.notify = activatex11;
	wl_signal_add(&xwayland_surface->events.request_activate, &c->activate);
	c->configure.notify = configurex11;
	wl_signal_add(&xwayland_surface->events.request_configure, &c->configure);
	c->destroy.notify = destroynotify;
	wl_signal_add(&xwayland_surface->events.destroy, &c->destroy);
	c->fullscreen.notify = fullscreennotify;
	wl_signal_add(&xwayland_surface->events.request_fullscreen, &c->fullscreen);
	c->isfullscreen = 0;

[25.2175]

[30.3221]

	LISTEN(&xwayland_surface->events.map, &c->map, mapnotify);
	LISTEN(&xwayland_surface->events.unmap, &c->unmap, unmapnotify);
	LISTEN(&xwayland_surface->events.request_activate, &c->activate,
			activatex11);
	LISTEN(&xwayland_surface->events.request_configure, &c->configure,
			configurex11);
	LISTEN(&xwayland_surface->events.destroy, &c->destroy, destroynotify);
	LISTEN(&xwayland_surface->events.request_fullscreen, &c->fullscreen,
			fullscreennotify);