akkartik/broadsheet.love - Change JOLUCIT6HFXFKYQ6PNGSNBF4GBYDA6ATVOITT2SYGJH7HBURTDDAC

consistently save/restore state when running tests

It's not obvious, but this is a refactoring. There should be no behavior changes.

Created by Kartik K. Agaram on January 23, 2023

JOLUCIT6HFXFKYQ6PNGSNBF4GBYDA6ATVOITT2SYGJH7HBURTDDAC

Dependencies

In channels

main

Change contents

Deletion in live.lua at line 282 [5.722]

B:BD[4.30] → [4.30:82]

B:BD[4.82] → [3.9:112]

    local globals = live.shallow_copy_all_globals()
    local current_font = love.graphics.getFont()
    love.graphics.setFont(Love_snapshot.initial_font)

Deletion in live.lua at line 285 [5.722]

B:BD[6.59] → [3.113:153]

∅:D[6.59] → [4.83:121]

∅:D[3.153] → [4.83:121]

B:BD[7.100] → [4.83:121]

B:BD[8.39] → [4.122:481]

    love.graphics.setFont(current_font)
    live.restore_all_globals(globals)
  end
end
function live.shallow_copy_all_globals()
  local result = {}
  for k,v in pairs(_G) do
    result[k] = v
  end
  return result
end
function live.restore_all_globals(x)
  -- delete extra bindings
  for k,v in pairs(_G) do
    if x[k] == nil then
      _G[k] = nil
    end
  end
  -- restore previous bindings
  for k,v in pairs(x) do
    _G[k] = v

Replacement in app.lua at line 431 [11.2]
B:BD[9.8001] → [10.1935:1959]
```
  local saved_app = App
```
[9.8001]
[10.1959]
```
  local globals = App.shallow_copy_all_globals()
```

Insertion in app.lua at line 433 [11.2]

[10.1981]

[9.8001]

  local saved_font = love.graphics.getFont()
  love.graphics.setFont(Love_snapshot.initial_font)

Replacement in app.lua at line 440 [11.2]

B:BD[12.7554] → [13.18:36]

  App = saved_app

[12.7554]

[13.36]

  love.graphics.setFont(saved_font)
  -- restore all global state except Test_errors
  local test_errors = Test_errors
  App.restore_all_globals(globals)
  Test_errors = test_errors

Replacement in app.lua at line 448 [11.2]
∅:D[2.63] → [13.69:93]
B:BD[13.69] → [13.69:93]
```
  local saved_app = App
```
[2.63]
[13.93]
```
  local globals = App.shallow_copy_all_globals()
```

Replacement in app.lua at line 450 [11.2]

B:BD[13.115] → [13.115:143]

B:BD[13.143] → [2.64:123]

∅:D[2.123] → [10.2065:2083]

∅:D[14.175] → [10.2065:2083]

∅:D[15.187] → [10.2065:2083]

∅:D[13.221] → [10.2065:2083]

B:BD[12.7564] → [10.2065:2083]

  App.initialize_for_test()
  xpcall(test, function(err) record_error_fn('', err) end)
  App = saved_app

[13.115]

[12.7564]

  local saved_font = love.graphics.getFont()
  love.graphics.setFont(Love_snapshot.initial_font)
    App.initialize_for_test()
    xpcall(test, function(err) record_error_fn('', err) end)
  love.graphics.setFont(saved_font)
  -- restore all global state except Test_errors
  local test_errors = Test_errors
  App.restore_all_globals(globals)
  Test_errors = test_errors
end
function App.shallow_copy_all_globals()
  local result = {}
  for k,v in pairs(_G) do
    result[k] = v
  end
  return result
end
function App.restore_all_globals(x)
  -- delete extra bindings
  for k,v in pairs(_G) do
    if x[k] == nil then
      _G[k] = nil
    end
  end
  -- restore previous bindings
  for k,v in pairs(x) do
    _G[k] = v
  end