akkartik/pensieve.love - Change AOVGO4PFCRRXU3JPQIVW36UPY6HAGMAH3HHA3E3J7QYZGDYA4B6QC

snapshot: tracking down a gnarly bug

scenario: press and hold the down arrow key

Observed behavior: as the surface scrolls down there are flickers of panes appearing and disappearing in strange places. Going back up a bit and scrolling back down doesn't cause them to reappear. Scrolling slowly doesn't cause them.

One thing I notice here is that my complicated overlap checks have gone out of sync between App.draw and update_pane_bounds pretty early on (commit 184266ad). Still doesn't fix it, though.

Created by Kartik K. Agaram on August 6, 2022

AOVGO4PFCRRXU3JPQIVW36UPY6HAGMAH3HHA3E3J7QYZGDYA4B6QC

Dependencies

In channels

main

Change contents

Insertion in main.lua at line 222 [6.2]
[5.252]
[3.540]
```
--?   print('load pane from file')
```
Insertion in main.lua at line 245 [6.2]
[7.44]
[7.44]
```
--?   print('update metadata')
```

Insertion in main.lua at line 319 [6.2]

[8.1667]

[2.8]

          if pane.left == 0 and pane.top == 0 then
            print('update pane bounds', pane.id)
          end

Replacement in main.lua at line 369 [6.2]

B:BD[9.251] → [10.55:172]

    if overlap(sx, sx+Display_settings.column_width, Display_settings.x, Display_settings.x + App.screen.width) then

[9.251]

[11.5399]

    if overlap(sx-Margin_left, sx+Display_settings.column_width+Margin_right, Display_settings.x, Display_settings.x + App.screen.width) then

Insertion in main.lua at line 382 [6.2]

[12.889]

[11.5876]

          if pane.top == 0 and pane.left == 0 then
            print('draw', pane.id)
          end

Insertion in main.lua at line 719 [6.2]

[4.396]

[13.930]

--?     for _,column in ipairs(Surface) do
--?       for _,pane in ipairs(column) do
--?         if pane.top == 0 and pane.left == 0 then
--?           print(pane.id, Display_settings.show_palette, Display_settings.mode, chord)
--?         end
--?       end
--?     end