akkartik/pensieve.love - Change EGS44RTAG7JVLLEA4KH63MBZAD4O5HNRSJQIOC6SRKHUG3G56R6QC

switch to love.filesystem for file operations

It's safer, ensures I can't accidentally access anything outside the app's directory.

Created by Kartik K. Agaram on July 24, 2022

EGS44RTAG7JVLLEA4KH63MBZAD4O5HNRSJQIOC6SRKHUG3G56R6QC

Dependencies

In channels

main

Change contents

Replacement in main.lua at line 74 [7.2]

B:BD[6.119] → [3.8:101]

  Cursor_pane = {col=1, row=1}  -- surface column and row index, along with some cached data

[6.119]

[8.8]

  Cursor_pane = {col=0, row=1}  -- surface column and row index, along with some cached data

Deletion in main.lua at line 112 [7.2]
∅:D[9.58] → [10.8:9]
∅:D[11.336] → [10.8:9]
∅:D[12.2893] → [10.8:9]
∅:D[13.85928] → [10.8:9]
B:BD[14.746] → [10.8:9]
B:BD[10.9] → [12.2894:2909]
B:BD[12.2909] → [8.188:396]
B:BD[8.396] → [15.8:113]
∅:D[15.113] → [12.3003:3061]
∅:D[16.196] → [12.3003:3061]
∅:D[8.396] → [12.3003:3061]
B:BD[12.3003] → [12.3003:3061]
∅:D[12.3061] → [10.82:88]
B:BD[10.82] → [10.82:88]
```
  -- test data
  Cache['foo'] = {lines=load_from_disk(Directory..'foo'), left=0, right=Display_settings.column_width}
  Cache['foo2'] = {lines=load_from_disk(Directory..'foo2'), left=0, right=Display_settings.column_width}
  Cache['foo3'] = {lines=load_from_disk(Directory..'foo3'), left=0, right=Display_settings.column_width}
  for _,file in pairs(Cache) do
    initialize_file(file)
  end
```

Replacement in main.lua at line 113 [7.2]

B:BD[17.9] → [12.3062:3171]

B:BD[12.3171] → [4.8:89]

∅:D[4.89] → [12.3248:3325]

∅:D[15.191] → [12.3248:3325]

B:BD[12.3248] → [12.3248:3325]

B:BD[12.3401] → [12.3401:3863]

  -- initialize surface with unique editor objects for each pane
  local column = {name='recently modified'}
--?   table.insert(column, initialize_pane_with_placeholder_coordinates('foo3'))
  table.insert(column, initialize_pane_with_placeholder_coordinates('foo2'))
  table.insert(Surface, column)
  column = {name='2022/07'}
  table.insert(column, initialize_pane_with_placeholder_coordinates('foo'))
  table.insert(Surface, column)
  column = {name='search: foo'}
  table.insert(column, initialize_pane_with_placeholder_coordinates('foo2'))
  table.insert(column, initialize_pane_with_placeholder_coordinates('foo2'))
  table.insert(column, initialize_pane_with_placeholder_coordinates('foo'))
  table.insert(Surface, column)

[17.9]

[18.152]

  -- initialize surface with a single column
  command.recently_modified()

Replacement in main.lua at line 144 [7.2]
B:BD[19.7] → [12.3865:3896]
```
function initialize_file(file)
```
[19.7]
[20.98]
```
function initialize_file_metadata(file)
```

Replacement in main.lua at line 167 [7.2]

B:BD[21.8] → [12.4631:4689]

function initialize_pane_with_placeholder_coordinates(id)

[21.8]

[12.4689]

function load_pane_from_file(id)
  if Cache[id] == nil then
    Cache[id] = {lines=load_from_disk('data/'..id), left=0, right=Display_settings.column_width}
    initialize_file_metadata(Cache[id])
  end

Replacement in main.lua at line 174 [7.2]
B:BD[12.4849] → [8.397:431]
```
  result.filename = Directory..id
```
[12.4849]
[16.578]
```
  result.filename = 'data/'..id
```

Insertion in main.lua at line 328 [7.2]

[22.1042]

[3.187]

--?   print(#Surface, Cursor_pane.col, Surface[Cursor_pane.col], Cursor_pane.row)

Insertion in main.lua at line 413 [7.2]
[22.1893]
[22.1893]
```
--?   print('app mouse pressed')
```
Insertion in main.lua at line 435 [7.2]
[22.2266]
[22.2266]
```
--?   print('app mouse released')
```

Replacement in file.lua at line 38 [23.15083]

B:BD[23.16169] → [2.14:51]

      outfile:write(line.data, '\n')

[23.16169]

[23.16206]

      outfile:write(line.data)
      outfile:write('\n')

Replacement in file.lua at line 87 [23.15083]

B:BD[23.17287] → [2.52:98]

      outfile:write(json.encode(shape), '\n')

[23.17287]

[23.17333]

      outfile:write(json.encode(shape))
      outfile:write('\n')

Replacement in file.lua at line 91 [23.15083]

B:BD[23.17507] → [2.99:131]

      outfile:write(line, '\n')

[23.17507]

[24.289]

      outfile:write(line)
      outfile:write('\n')

Replacement in file.lua at line 99 [23.15083]

B:BD[23.17771] → [2.132:164]

      outfile:write(line, '\n')

[23.17771]

[23.17803]

      outfile:write(line)
      outfile:write('\n')

Replacement in file.lua at line 102 [23.15083]

B:BD[23.17842] → [2.165:281]

      outfile:write(json.encode({mode=shape.mode, center=drawing.points[shape.center], radius=shape.radius}), '\n')

[23.17842]

[23.17958]

      outfile:write(json.encode({mode=shape.mode, center=drawing.points[shape.center], radius=shape.radius}))
      outfile:write('\n')

Replacement in file.lua at line 105 [23.15083]

B:BD[23.17994] → [2.282:456]

      outfile:write(json.encode({mode=shape.mode, center=drawing.points[shape.center], radius=shape.radius, start_angle=shape.start_angle, end_angle=shape.end_angle}), '\n')

[23.17994]

[25.67]

      outfile:write(json.encode({mode=shape.mode, center=drawing.points[shape.center], radius=shape.radius, start_angle=shape.start_angle, end_angle=shape.end_angle}))
      outfile:write('\n')

Insertion in edit.lua at line 193 [26.413]
[26.6692]
[27.4415]
```
--?   print('edit.quit')
```
Insertion in edit.lua at line 195 [26.413]
[27.4441]
[27.4441]
```
--?     print('next save', State.id)
```
Insertion in edit.lua at line 241 [26.413]
[27.5299]
[27.5299]
```
--?   print('edit mouse released')
```
Insertion in edit.lua at line 246 [26.413]
[28.68]
[29.420]
```
--?     print('scheduling save', State.id)
```

Replacement in commands.lua at line 183 [30.39]

B:BD[5.365] → [5.365:439]

      local pane = initialize_pane_with_placeholder_coordinates(filename)

[5.365]

[5.439]

--?       print('loading', filename)
      local pane = load_pane_from_file(filename)

Insertion in commands.lua at line 189 [30.39]
[5.537]
[5.537]
```
  Cursor_pane.col = Cursor_pane.col+1
```

Replacement in app.lua at line 300 [33.2]

B:BD[31.2493] → [32.1208:1403]

    write = function(self, ...)
              local args = {...}
              for i,s in ipairs(args) do
                App.filesystem[filename] = App.filesystem[filename]..s
              end

[31.2493]

[32.1403]

    write = function(self, s)
              App.filesystem[filename] = App.filesystem[filename]..s

Replacement in app.lua at line 369 [33.2]

B:BD[34.8162] → [32.1614:1692]

∅:D[32.1692] → [31.2713:2791]

B:BD[34.8162] → [31.2713:2791]

  App.open_for_reading = function(filename) return io.open(filename, 'r') end
  App.open_for_writing = function(filename) return io.open(filename, 'w') end

[34.8162]

[35.1742]

  App.open_for_reading =
      function(filename)
        local result = love.filesystem.newFile(filename)
        result:open('r')
        return result
      end
  App.open_for_writing =
      function(filename)
        local result = love.filesystem.newFile(filename)
        result:open('w')
        return result
      end

switch to love.filesystem for file operations

Dependencies

In channels

Change contents

Replacement in main.lua at line 74 [7.2]

Deletion in main.lua at line 112 [7.2]

Replacement in main.lua at line 113 [7.2]

Replacement in main.lua at line 144 [7.2]

Replacement in main.lua at line 167 [7.2]

Replacement in main.lua at line 174 [7.2]

Insertion in main.lua at line 328 [7.2]

Insertion in main.lua at line 413 [7.2]

Insertion in main.lua at line 435 [7.2]

Replacement in file.lua at line 38 [23.15083]

Replacement in file.lua at line 87 [23.15083]

Replacement in file.lua at line 91 [23.15083]

Replacement in file.lua at line 99 [23.15083]

Replacement in file.lua at line 102 [23.15083]

Replacement in file.lua at line 105 [23.15083]

Insertion in edit.lua at line 193 [26.413]

Insertion in edit.lua at line 195 [26.413]

Insertion in edit.lua at line 241 [26.413]

Insertion in edit.lua at line 246 [26.413]

Replacement in commands.lua at line 183 [30.39]

Insertion in commands.lua at line 189 [30.39]

Replacement in app.lua at line 300 [33.2]

Replacement in app.lua at line 369 [33.2]