akkartik/pensieve.love - Change BFH7KNF6DPOCKLCSTY52MMD4LKDNL4EYFJA7LZTMRW6IXZHIDNSAC

no, the previous commit caused a regression

Hitting down arrow no longer keeps the cursor on screen.

This is a sign I need to automate my tests. The place to make changes is starting to grow less obvious. This is the second major issue (after the maximize bug; commit 4c672c9769 and before) that has implemented a feature wrong.

Created by Kartik K. Agaram on August 16, 2022

BFH7KNF6DPOCKLCSTY52MMD4LKDNL4EYFJA7LZTMRW6IXZHIDNSAC

Dependencies

In channels

main

Change contents

Insertion in Manual_tests.md at line 52 [6.1]
[4.137]
[5.339]
```
Height computations:
```

Deletion in Manual_tests.md at line 55 [6.1]

B:BD[5.532] → [3.500:688]

* select a pane that extends past the bottom of the viewport. hit ctrl+e. Position cursor at final point in viewport. Start typing. Viewport pans to keep cursor in view as the line wraps.

Insertion in Manual_tests.md at line 72 [6.1]
[7.1252]
[2.889]
```
Cursor management:
```

Replacement in Manual_tests.md at line 75 [6.1]

B:BD[8.2157] → [2.1031:1138]

* select a pane, hit ctrl+e, hit pagedown, hit up arrow a few times. cursor continues to remain on screen.

[8.2157]

[8.2264]

* select a pane that extends past bottom of viewport, hit ctrl+e, position cursor near bottom of pane, hit down arrow a few times.
* select a pane, hit ctrl+e, hit pagedown, hit up arrow a few times. cursor continues to remain on screen, panning surface as necessary.
* select a pane that extends past bottom of viewport. hit ctrl+e. Position cursor on pane near bottom of viewport. Start typing. cursor continues to remain on screen, panning surface as necessary.