akkartik/pensieve.love - Change IFGHOCUOIAKC722BNCIRNE2EDMGF77FBTYS57H5UWN6YXOLSZHQQC

holy fuck

The sequence of events is as follows:

down arrow is pressed
cursor is already at bottom of screen, so we compute a new screen_top
==> in doing so, we depend on pane.top <==
after setting screen_top we return
the surface calls plan_draw
==> plan_draw updates pane.top <==

Now drawing from the new pane.top no longer draws the screen line with the cursor, where the old one would have. And this can happen with just a few pixels of difference. You had x pixels of slack when you set screen_top. If plan_draw just adjusts things by more than x pixels, game over.

I should give up programming and become a hermit, for getting myself into this situation with so much promiscuously mutating global state.

Created by Kartik K. Agaram on August 16, 2022

IFGHOCUOIAKC722BNCIRNE2EDMGF77FBTYS57H5UWN6YXOLSZHQQC

Dependencies

In channels

main

Change contents

Replacement in text.lua at line 486 [6.1]

B:BD[4.5973] → [5.3:158]

  print('down', State.cursor1.line, State.cursor1.pos, State.screen_top1.line, State.screen_top1.pos, State.screen_bottom1.line, State.screen_bottom1.pos)

[4.5973]

[7.1281]

  print('down', State.screen_top1.line, State.screen_top1.pos, State.cursor1.line, State.cursor1.pos, State.screen_bottom1.line, State.screen_bottom1.pos)

Insertion in text.lua at line 500 [6.1]

[8.1321]

[4.6478]

    print('new cursor', State.cursor1.line, State.cursor1.pos)

Insertion in text.lua at line 695 [6.1]
[9.580]
[5.973]
```
  print('snap cursor', State.top)
```

Replacement in text.lua at line 702 [6.1]

B:BD[10.394] → [11.3259:3335]

    if top2.screen_line > 1 or State.lines[top2.line-1].mode == 'text' then

[10.394]

[11.3335]

    if top2.screen_line > 1 or State.lines[top2.line].mode == 'text' then
--?       print(State.lines[top2.line].data)

Replacement in text.lua at line 711 [6.1]

B:BD[10.614] → [11.3409:3466]

      assert(State.lines[top2.line-1].mode == 'drawing')

[10.614]

[10.665]

      assert(State.lines[top2.line].mode == 'drawing')

Replacement in text.lua at line 714 [6.1]

B:BD[10.767] → [12.290:387]

      local h = Drawing_padding_height + Drawing.pixels(State.lines[top2.line-1].h, State.width)

[10.767]

[13.16768]

      local h = Drawing_padding_height + Drawing.pixels(State.lines[top2.line].h, State.width)

Replacement in main.lua at line 295 [16.2]
∅:D[14.678] → [15.91:125]
B:BD[17.238] → [15.91:125]
```
--?   print('update pane bounds')
```
[14.678]
[14.679]
```
  print('update pane bounds')
```
Replacement in main.lua at line 413 [16.2]
B:BD[3.162] → [3.162:192]
```
        assert(pane.cursor_y)
```
[3.162]
[3.192]
```
--?         assert(pane.cursor_y)
```

Insertion in edit.lua at line 137 [18.413]

[18.4124]

[19.2931]

  if State.foo then
    print('edit.draw from', State.top)
  end

Replacement in edit.lua at line 142 [18.413]

B:BD[19.3030] → [5.2090:2215]

--?     if State.foo then
--?     print('draw:', line_index, y, '+', State.line_height, 'vs', App.screen.height)
--?     end

[19.3030]

[5.2215]

    if State.foo then
    print('draw:', line_index, y, '+', State.line_height, 'vs', App.screen.height)
    end

Replacement in commands.lua at line 138 [22.39]

B:BD[20.1039] → [21.1205:1407]

B:BD[21.1407] → [2.48:106]

∅:D[2.106] → [21.1407:1724]

B:BD[21.1407] → [21.1407:1724]

          if pane.cursor_x >= 0 and pane.cursor_x < App.screen.width and pane.cursor_y >= Header_height and pane.cursor_y < App.screen.height then
            add_hotkey_to_menu('ctrl+e: stop editing')
            add_hotkey_to_menu('ctrl+h on drawing: help')
            add_hotkey_to_menu('ctrl+f: find')
            add_hotkey_to_menu('alt+left alt+right: prev/next word')
            add_hotkey_to_menu('ctrl+z ctrl+y: undo/redo')
            add_hotkey_to_menu('ctrl+x ctrl+c ctrl+v: cut/copy/paste')
          else
            add_panning_hotkeys_to_menu()
          end

[20.1039]

[20.1079]

--?           if pane.cursor_x >= 0 and pane.cursor_x < App.screen.width and pane.cursor_y >= Header_height and pane.cursor_y < App.screen.height then
--?             add_hotkey_to_menu('ctrl+e: stop editing')
--?             add_hotkey_to_menu('ctrl+h on drawing: help')
--?             add_hotkey_to_menu('ctrl+f: find')
--?             add_hotkey_to_menu('alt+left alt+right: prev/next word')
--?             add_hotkey_to_menu('ctrl+z ctrl+y: undo/redo')
--?             add_hotkey_to_menu('ctrl+x ctrl+c ctrl+v: cut/copy/paste')
--?           else
--?             add_panning_hotkeys_to_menu()
--?           end