akkartik/pensieve.love - Change L32R5DALHPK75E2V7C5QGKR4AH6FVOLGTLMVKVQ36VA5ZKCID2JAC

lazily compute pane height

It requires computing every single screen line, which can be expensive for large panes. This way we only put in the work for:

panes above the viewport
in visible columns

Created by Kartik K. Agaram on August 6, 2022

L32R5DALHPK75E2V7C5QGKR4AH6FVOLGTLMVKVQ36VA5ZKCID2JAC

Dependencies

In channels

main

Change contents

Deletion in main.lua at line 202 [5.2]
∅:D[3.360] → [4.125:154]
B:BD[6.186] → [4.125:154]
```
  derive_pane_height(result)
```

Insertion in main.lua at line 208 [5.2]

[7.5052]

[8.8]

end
function height(pane)
  if pane.height == nil then
    derive_pane_height(pane)
  end
  return pane.height

Replacement in main.lua at line 220 [5.2]

B:BD[9.216] → [9.216:262]

  pane.height = pane.height + 5+Line_height+5

[9.216]

[9.262]

  pane.height = height(pane) + 5+Line_height+5

Replacement in main.lua at line 297 [5.2]

B:BD[10.1679] → [11.181:260]

        sy = sy + Margin_above + pane.height + Margin_below + Padding_vertical

[10.1679]

[10.1768]

        sy = sy + Margin_above + height(pane) + Margin_below + Padding_vertical

Replacement in main.lua at line 309 [5.2]

B:BD[2.305] → [2.305:450]

  return overlap(sy, sy + Margin_above + pane.height + Margin_below, Display_settings.y, Display_settings.y + App.screen.height - Header_height)

[2.305]

[10.1886]

  return overlap(sy, sy + Margin_above + height(pane) + Margin_below, Display_settings.y, Display_settings.y + App.screen.height - Header_height)

Replacement in main.lua at line 368 [5.2]

B:BD[7.5914] → [11.467:546]

        sy = sy + Margin_above + pane.height + Margin_below + Padding_vertical

[7.5914]

[7.5952]

        sy = sy + Margin_above + height(pane) + Margin_below + Padding_vertical

Replacement in main.lua at line 493 [5.2]

B:BD[12.1451] → [11.547:614]

        if sy < y + Margin_above + pane.height + Margin_below then

[12.1451]

[12.1519]

        if sy < y + Margin_above + height(pane) + Margin_below then

Replacement in main.lua at line 496 [5.2]

B:BD[13.581] → [11.615:692]

        y = y + Margin_above + pane.height + Margin_below + Padding_vertical

[13.581]

[13.668]

        y = y + Margin_above + height(pane) + Margin_below + Padding_vertical

Replacement in main.lua at line 517 [5.2]

B:BD[14.80] → [11.693:760]

        if sy < y + Margin_above + pane.height + Margin_below then

[12.1553]

[13.1295]

        if sy < y + Margin_above + height(pane) + Margin_below then

Replacement in main.lua at line 520 [5.2]

B:BD[13.1355] → [11.761:838]

        y = y + Margin_above + pane.height + Margin_below + Padding_vertical

[13.1355]

[12.1591]

        y = y + Margin_above + height(pane) + Margin_below + Padding_vertical

Replacement in main.lua at line 1025 [5.2]

B:BD[15.316] → [15.316:402]

    local next_sy = sy + Margin_above + pane.height + Margin_below + Padding_vertical

[15.316]

[15.402]

    local next_sy = sy + Margin_above + height(pane) + Margin_below + Padding_vertical

Replacement in main.lua at line 1038 [5.2]

B:BD[16.3645] → [11.1024:1107]

    result = result + Margin_above + pane.height + Margin_below + Padding_vertical

[16.3645]

[16.3738]

    result = result + Margin_above + height(pane) + Margin_below + Padding_vertical

Replacement in main.lua at line 1047 [5.2]

B:BD[16.3875] → [11.1108:1191]

    result = result + Margin_above + pane.height + Margin_below + Padding_vertical

[16.3875]

[16.3968]

    result = result + Margin_above + height(pane) + Margin_below + Padding_vertical

Replacement in main.lua at line 1055 [5.2]

B:BD[17.2333] → [11.1192:1275]

    result = result + Margin_above + pane.height + Margin_below + Padding_vertical

[17.2333]

[17.2426]

    result = result + Margin_above + height(pane) + Margin_below + Padding_vertical