akkartik/pensieve.love - Change P376DBJTKHBVGQ57PF7LQFZVUMBJPS4QKY2VKVN765FUCIPWL6QAC

stop tracking height in Cache

I'm getting rid of some code duplication at the cost of redundantly recomputing heights in duplicate panes.

Created by Kartik K. Agaram on August 6, 2022

P376DBJTKHBVGQ57PF7LQFZVUMBJPS4QKY2VKVN765FUCIPWL6QAC

Dependencies

In channels

main

Change contents

Deletion in main.lua at line 187 [7.2]
B:BD[5.7] → [6.8:42]
∅:D[6.42] → [8.98:112]
∅:D[9.218] → [8.98:112]
B:BD[10.3896] → [8.98:112]
B:BD[8.112] → [11.8:31]
∅:D[11.31] → [12.225:281]
B:BD[12.225] → [12.225:281]
B:BD[10.3992] → [13.11:11]
∅:D[13.11] → [14.500:532]
∅:D[15.211] → [14.500:532]
∅:D[10.3992] → [14.500:532]
∅:D[16.86772] → [14.500:532]
B:BD[14.500] → [14.500:532]
B:BD[14.532] → [17.8:38]
B:BD[10.4068] → [12.315:407]
B:BD[12.407] → [11.61:132]
B:BD[11.132] → [3.8:52]
∅:D[3.52] → [10.4222:4278]
∅:D[11.132] → [10.4222:4278]
∅:D[12.483] → [10.4222:4278]
B:BD[10.4222] → [10.4222:4278]
B:BD[10.4278] → [12.484:577]
∅:D[12.577] → [10.4278:4330]
B:BD[10.4278] → [10.4278:4330]
∅:D[18.28] → [14.554:562]
∅:D[19.802] → [14.554:562]
∅:D[10.4330] → [14.554:562]
B:BD[14.554] → [14.554:562]
∅:D[10.4395] → [14.562:568]
B:BD[14.562] → [14.562:568]
B:BD[20.43] → [2.8:126]
∅:D[2.126] → [21.268:273]
∅:D[22.150] → [21.268:273]
B:BD[8.131] → [21.268:273]
```
function derive_file_height(file)
  local y = 0
  file.line_cache = {}
  for i=1,#file.lines do
    local line = file.lines[i]
    if line.mode == 'text' then
      file.line_cache[i] = {}
      Text.compute_fragments(file, i)
      Text.populate_screen_line_starting_pos(file, i)
      y = y + Line_height*#file.line_cache[i].screen_line_starting_pos
      Text.clear_screen_line_cache(file, i)
    elseif line.mode == 'drawing' then
      -- nothing
      y = y + Drawing.pixels(line.h, Display_settings.column_width) + Drawing_padding_height
    else
      print(line.mode)
      assert(false)
    end
  end
  if file.links and not empty(file.links) then
    y = y + 5+Line_height+5  -- for crosslinks
  end
  file.height = y
end
```

Replacement in main.lua at line 189 [7.2]

B:BD[21.347] → [21.347:438]

  Cache[id] = {id=id, filename=Directory..id, left=0, right=Display_settings.column_width}

[21.347]

[21.438]

  Cache[id] = {id=id, filename=Directory..id, left=0, right=Display_settings.column_width, lines={}, line_cache={}}

Deletion in main.lua at line 192 [7.2]
B:BD[6.78] → [6.78:110]
```
  derive_file_height(Cache[id])
```
Replacement in main.lua at line 202 [7.2]
B:BD[11.186] → [23.8:43]
```
  result.height = Cache[id].height
```
[11.186]
[10.4881]
```
  derive_pane_height(result)
```
Replacement in main.lua at line 217 [7.2]
B:BD[24.267] → [6.111:147]
∅:D[6.147] → [25.44:75]
B:BD[26.44] → [25.44:75]
```
function rederive_pane_height(pane)
--?   print('update metadata')
```
[24.267]
[26.44]
```
function derive_pane_height(pane)
--?   print('derive pane height')
```

Insertion in main.lua at line 223 [7.2]

[26.227]

[17.39]

      if pane.line_cache[i] == nil then
        pane.line_cache[i] = {}
      end

Replacement in main.lua at line 586 [7.2]
B:BD[27.56] → [6.148:179]
```
    rederive_pane_height(pane)
```
[27.56]
[28.1412]
```
    derive_pane_height(pane)
```
Replacement in main.lua at line 743 [7.2]
B:BD[29.1255] → [6.180:211]
```
    rederive_pane_height(pane)
```
[29.1255]
[29.1281]
```
    derive_pane_height(pane)
```
Replacement in main.lua at line 999 [7.2]
B:BD[30.114] → [6.212:245]
```
      rederive_pane_height(pane)
```
[30.114]
[30.142]
```
      derive_pane_height(pane)
```

Replacement in commands.lua at line 804 [33.39]

B:BD[31.508] → [32.18:188]

  Cache[id] = {id=id, filename=Directory..id, lines={{mode='text', data=''}}, line_cache={{}}, left=0, right=Display_settings.column_width, links={}, height=Line_height}

[31.508]

[4.273]

  Cache[id] = {id=id, filename=Directory..id, lines={{mode='text', data=''}}, line_cache={{}}, left=0, right=Display_settings.column_width, links={}}

stop tracking height in Cache

Dependencies

In channels

Change contents

Deletion in main.lua at line 187 [7.2]

Replacement in main.lua at line 189 [7.2]

Deletion in main.lua at line 192 [7.2]

Replacement in main.lua at line 202 [7.2]

Replacement in main.lua at line 217 [7.2]

Insertion in main.lua at line 223 [7.2]

Replacement in main.lua at line 586 [7.2]

Replacement in main.lua at line 743 [7.2]

Replacement in main.lua at line 999 [7.2]

Replacement in commands.lua at line 804 [33.39]