akkartik/pensieve.love - Change NQBUJ4VZQJZP2X2J2UG27XVY5LCGNVAOE5RFZJA5BASITUQSVIUQC

maybe this fixes the regression?

Another ugly special case, but I think this is still cleaner than pre-dabb7a6c4.

Created by Kartik K. Agaram on February 10, 2023

NQBUJ4VZQJZP2X2J2UG27XVY5LCGNVAOE5RFZJA5BASITUQSVIUQC

Dependencies

In channels

main

Change contents

Deletion in run.lua at line 796 [4.178044]

B:BD[3.2753] → [2.17:134]

            log(2, 'keychord 1: '..chord..' '..tostring(pane.screen_top1.line)..' '..tostring(pane.screen_top1.pos))

Replacement in run.lua at line 798 [4.178044]

B:BD[5.1181] → [2.135:252]

∅:D[2.252] → [6.328:405]

B:BD[5.1181] → [6.328:405]

            log(2, 'keychord 2: '..chord..' '..tostring(pane.screen_top1.line)..' '..tostring(pane.screen_top1.pos))
            if chord == 'backspace' or chord == 'up' or chord == 'left' then

[5.1181]

[6.405]

            if chord == 'pagedown' then
              pan_surface_to_screen_top_of_cursor_pane()
            elseif chord == 'backspace' or chord == 'up' or chord == 'left' then

Deletion in run.lua at line 803 [4.178044]

B:BD[6.478] → [2.253:318]

              log(2, 'trying to bring cursor in view downwards')

Deletion in run.lua at line 805 [4.178044]

B:BD[6.552] → [2.319:503]

            log(2, 'keychord 3: '..chord..' '..tostring(pane.screen_top1.line)..' '..tostring(pane.screen_top1.pos)..' '..tostring(pane.cursor1.line)..' '..tostring(pane.cursor1.pos))

Deletion in run.lua at line 807 [4.178044]

B:BD[6.577] → [2.504:621]

            log(2, 'keychord 4: '..chord..' '..tostring(pane.screen_top1.line)..' '..tostring(pane.screen_top1.pos))

Insertion in run.lua at line 1055 [4.178044]

[7.39201]

function pan_surface_to_screen_top_of_cursor_pane()
  if Cursor_pane.col < 1 then
    return
  end
  local pane = Surface[Cursor_pane.col][Cursor_pane.row]
  if pane == nil then
    return
  end
  Display_settings.y = up_edge_sy(Cursor_pane.col, Cursor_pane.row) + y_of_schema1(pane, pane.screen_top1)
end

Deletion in run.lua at line 1074 [4.178044]

B:BD[7.39394] → [2.622:900]

  log(2, 'bring_in_view: viewport before: '..tostring(Display_settings.x)..','..Display_settings.y)
  log(2, 'bring_in_view: pane before: '..tostring(pane.screen_top1.line)..' '..tostring(pane.screen_top1.pos)..' '..tostring(pane.cursor1.line)..' '..tostring(pane.cursor1.pos))

Deletion in run.lua at line 1077 [4.178044]

B:BD[7.39716] → [2.901:1197]

  log(2, 'bring_in_view: pane starts at '..tostring(up_edge_sy(Cursor_pane.col, Cursor_pane.row)))
  log(2, 'bring_in_view: cursor line contains ^'..pane.lines[pane.cursor1.line].data..'$')
  log(2, 'bring_in_view: cursor is at '..tostring(y_of_schema1(pane, pane.cursor1))..' from top of pane')

Deletion in run.lua at line 1078 [4.178044]
B:BD[7.40153] → [2.1198:1260]
```
  log(2, 'bring_in_view: cursor is at '..tostring(cursor_sy))
```
Deletion in run.lua at line 1080 [4.178044]
B:BD[7.40424] → [2.1261:1310]
```
    log(2, 'bring_in_view: all well; returning')
```

Deletion in run.lua at line 1099 [4.178044]

B:BD[8.1200] → [8.1200:1500]

--?       print('=>', Display_settings.y)
--?       print('cursor now at ', cursor_sy - Display_settings.y)
--?       print('viewport height', App.screen.height)
--?       print('cursor row starts', App.screen.height - (cursor_sy-Display_settings.y), 'px above bottom of viewport')  -- totally wrong

Deletion in run.lua at line 1102 [4.178044]

B:BD[7.41665] → [7.41665:41742]

--?   print('viewport before clamp', Display_settings.x, Display_settings.y)

Deletion in run.lua at line 1104 [4.178044]
B:BD[7.41852] → [8.1501:1569]
```
--?   print('viewport now', Display_settings.x, Display_settings.y)
```