akkartik/pensieve.love - Change VUPAAFJL3JDSTGMBJMJUNT4EHFEL73Y5S4BEJZMFLNZUKNKWHGAAC

bugfix: never clobber in-memory links for a note

scenario: add note to a note in a column by itself Before this commit, the new note would seem to be added fine, but the old note's link would never be persisted.

It isn't enough just to fix run.lua, I also need to make add_note and populate_unroll_column behave more composably. Which increases the risk that this bugfix is going to introduce cascading bugs. (There must have been some reason I was erroring out when trying to unroll a note with no next link? And yet the check only occurs for the very first node in the chain?) But hopefully we're going in the right direction and any follow-on bugs will eventually damp down to 0. This seems worth doing even if it introduces bugs.

Created by Kartik K. Agaram on March 21, 2023

VUPAAFJL3JDSTGMBJMJUNT4EHFEL73Y5S4BEJZMFLNZUKNKWHGAAC

Dependencies

In channels

main

Change contents

Replacement in run.lua at line 239 [4.178044]

B:BD[3.42] → [3.42:71]

  Links[id] = load_links(id)

[3.42]

[5.11172]

  -- links are shared across all instances of an id, so never clobber them once loaded
  if Links[id] == nil then
    Links[id] = load_links(id)
  end

Deletion in file.lua at line 59 [8.15083]

B:BD[6.354] → [7.28:171]

  print_and_log('pending links before saving some links')
  for _,id in ipairs(Notes_to_log) do
    print_and_log('  '..links_state(id))
  end

Deletion in commands.lua at line 1023 [10.39]
B:BD[9.693] → [7.209:228]
```
Notes_to_log = {}
```

Insertion in commands.lua at line 1040 [10.39]

[11.167]

  end
  if #Surface[Cursor_pane.col] == 1 and not array.find(Non_unique_links, rel) then
    -- column has a single note; turn it into unroll
    Surface[Cursor_pane.col] = {name=('%s from %s'):format(rel, pane.id)}
    populate_unroll_column(Surface[Cursor_pane.col], pane.id, rel)

Deletion in commands.lua at line 1050 [10.39]
B:BD[12.1000] → [7.229:288]
```
  print_and_log('add_note/before: '..links_state(pane.id))
```

Deletion in commands.lua at line 1052 [10.39]

B:BD[13.456] → [7.289:477]

∅:D[7.477] → [13.456:539]

B:BD[13.456] → [13.456:539]

∅:D[13.539] → [14.89:216]

∅:D[12.1169] → [14.89:216]

B:BD[14.89] → [14.89:216]

B:BD[14.216] → [15.62:135]

B:BD[15.135] → [2.65:173]

  table.insert(Notes_to_log, pane.id)
  table.insert(Notes_to_log, new_pane.id)
  print_and_log('1/pane: '..links_state(pane.id))
  print_and_log('1/new_pane: '..links_state(new_pane.id))
  if #Surface[Cursor_pane.col] == 1 and not array.find(Non_unique_links, rel) then
    -- column has a single note; turn it into unroll
    Surface[Cursor_pane.col] = {name=('%s from %s'):format(rel, pane.id)}
    populate_unroll_column(Surface[Cursor_pane.col], pane.id, rel)
  end
  print_and_log('9/pane: '..links_state(pane.id))
  print_and_log('9/new_pane: '..links_state(new_pane.id))

Deletion in commands.lua at line 1386 [10.39]
B:BD[16.144] → [17.1728:1760]
∅:D[17.1760] → [18.3386:3439]
B:BD[19.703] → [18.3386:3439]
∅:D[18.3439] → [19.752:769]
B:BD[19.752] → [19.752:769]
```
  if Links[id][rel] == nil then
    add_error(('%s has no %s note'):format(id, rel))
    return
  end
```