akkartik/pensieve.love - Change Z64BQNJ7BVVPVO45GRRXEASZ7E2L3774G5ZDT2UX2RZNH565LZBAC

a bug I can't believe I didn't notice until now

Edit a pane that starts halfway down the screen. Position cursor near bottom of screen. Press down or enter.

Ideally we want the screen to just scroll the minimum amount. Currently the cursor moves all the way near top of screen.

I'm pretty sure I never ever implemented this. Certainly it's broken all the way back to commit d9a6625a8b on Aug 11.

Created by Kartik K. Agaram on September 3, 2022

Z64BQNJ7BVVPVO45GRRXEASZ7E2L3774G5ZDT2UX2RZNH565LZBAC

Dependencies

In channels

main

Change contents

Insertion in text.lua at line 359 [6.1]
[5.4463]
[3.281]
```
--?     print('text.down')
```

Replacement in text.lua at line 531 [6.1]

B:BD[7.4810] → [4.927:1084]

--?   print('=>', State.cursor1.line, State.cursor1.pos, State.screen_top1.line, State.screen_top1.pos, State.screen_bottom1.line, State.screen_bottom1.pos)

[7.4810]

[8.6091]

--?   print('=>', State.screen_top1.line, State.screen_top1.pos, State.cursor1.line, State.cursor1.pos, State.screen_bottom1.line, State.screen_bottom1.pos)

Replacement in Manual_tests.md at line 78 [9.1]

B:BD[2.755] → [2.755:852]

* select a pane that isn't topmost on column, hit ctrl+e, hit page down. Cursor remains visible.

[2.755]

[10.889]

* select a pane that isn't topmost on column, hit ctrl+e, hit pagedown. Cursor remains visible.

Replacement in Manual_tests.md at line 81 [9.1]

B:BD[11.2157] → [12.96:227]

* select a pane that extends past bottom of viewport, hit ctrl+e, position cursor near bottom of pane, hit down arrow a few times.

[11.2157]

[12.227]

* select a pane that extends past bottom of viewport, hit ctrl+e, position cursor near bottom of pane, hit down arrow a few times. cursor continues to remain on screen, panning surface as necessary.