akkartik/pong.love - Change 3LWDKR5FPZNW2ESSTTLWBBEBJ3B77UH4NEOC26PHOVG4HKOU4VQAC

load only relevant files

This also makes our testing questions less thorny. If and when Pong gets tests, they'll load and run independently of the source editor.

One remaining issue: making changes to the source editor's tests won't actually run immediately on ctrl+e. Instead, it'll only run when you ctrl+e a second time to bring back the editor.

Created by Kartik K. Agaram on September 3, 2022

3LWDKR5FPZNW2ESSTTLWBBEBJ3B77UH4NEOC26PHOVG4HKOU4VQAC

Dependencies

In channels

main

Change contents

Insertion in main.lua at line 23 [6.2]

[4.542]

[5.8]


load_file_from_source_or_save_directory('file.lua')

Insertion in main.lua at line 26 [6.2]

[5.9]

[4.543]

-- both sides require (different parts of) the logging framework

Replacement in main.lua at line 29 [6.2]

B:BD[7.243] → [4.595:647]

load_file_from_source_or_save_directory('file.lua')

[7.243]

[8.8]

-- but some files we want to only load sometimes
function App.load()
  if love.filesystem.getInfo('config') then
    Settings = json.decode(love.filesystem.read('config'))
    Current_app = Settings.current_app
  end

Replacement in main.lua at line 36 [6.2]

B:BD[8.9] → [4.648:664]

∅:D[4.664] → [9.230:284]

B:BD[8.9] → [9.230:284]

B:BD[9.284] → [10.393:451]

B:BD[10.451] → [3.11:126]

∅:D[3.126] → [4.665:1011]

∅:D[10.451] → [4.665:1011]

B:BD[9.284] → [4.665:1011]

-- file editing
load_file_from_source_or_save_directory('source.lua')
  load_file_from_source_or_save_directory('commands.lua')
  load_file_from_source_or_save_directory('edit.lua')
  load_file_from_source_or_save_directory('log_browser.lua')
  load_file_from_source_or_save_directory('text.lua')
    load_file_from_source_or_save_directory('search.lua')
    load_file_from_source_or_save_directory('select.lua')
    load_file_from_source_or_save_directory('undo.lua')
    load_file_from_source_or_save_directory('colorize.lua')
  load_file_from_source_or_save_directory('text_tests.lua')

[8.9]

[9.284]

  if Current_app == nil then
    Current_app = 'pong'
  end

Insertion in main.lua at line 40 [6.2]

[9.285]

[3.127]

  if Current_app == 'pong' then
    load_file_from_source_or_save_directory('pong.lua')
  else
    load_file_from_source_or_save_directory('source.lua')
      load_file_from_source_or_save_directory('commands.lua')
      load_file_from_source_or_save_directory('edit.lua')
      load_file_from_source_or_save_directory('log_browser.lua')
      load_file_from_source_or_save_directory('text.lua')
        load_file_from_source_or_save_directory('search.lua')
        load_file_from_source_or_save_directory('select.lua')
        load_file_from_source_or_save_directory('undo.lua')
        load_file_from_source_or_save_directory('colorize.lua')
      load_file_from_source_or_save_directory('text_tests.lua')
  end
end

Deletion in main.lua at line 56 [6.2]
∅:D[3.128] → [4.1012:1040]
B:BD[9.285] → [4.1012:1040]
∅:D[4.1040] → [9.285:338]
B:BD[9.285] → [9.285:338]
```
-- files for the app itself
load_file_from_source_or_save_directory('pong.lua')
```

Replacement in main.lua at line 57 [6.2]

B:BD[11.1566] → [9.339:562]

  pong.initialize_globals()
  source.initialize_globals()
  -- HACK: always open in editor in tests; we don't yet have any tests for pong
  -- (I have no idea how we'll run them when we get them.)
  Current_app = 'source'

[11.1566]

[12.486]

  if Current_app == 'pong' then
    pong.initialize_globals()
  elseif Current_app == 'source' then
    source.initialize_globals()
  else
    assert(false, 'unknown app "'..Current_app..'"')
  end

Deletion in main.lua at line 71 [6.2]

B:BD[13.109] → [9.563:634]

∅:D[9.634] → [14.206:348]

B:BD[13.109] → [14.206:348]

B:BD[15.169] → [15.169:175]

  -- now tests are done; open 'pong' by default
  Current_app = 'pong'
  if love.filesystem.getInfo('config') then
    Settings = json.decode(love.filesystem.read('config'))
    Current_app = Settings.current_app
  end

Insertion in app.lua at line 136 [16.2]
[2.130]
[2.130]
```
  App.load()
```