akkartik/snap.love - Change O4YV4KFWLYYWN4NVYMDM5OZOGOGYKCQ3L5VM6OKRKQZLCJGEONKAC

bugfix: text nodes always have non-nil computed width 'w'

Created by akkartik on March 19, 2025

O4YV4KFWLYYWN4NVYMDM5OZOGOGYKCQ3L5VM6OKRKQZLCJGEONKAC

Dependencies

In channels

main

Change contents

Replacement in 0026-on.draw at line 33 [5.238692]
B:BD[5.240278] → [6.360:384]
```
			if obj.w == nil then
```
[5.240278]
[7.3158]
```
			if obj.width == nil then
```

Replacement in 0021-compute_layout at line 31 [8.4307]

B:BD[8.5128] → [8.5128:5184]

		if node.editor == nil then
			initialize_editor(node)

[8.5128]

[8.5184]

		if node.width then
			if node.editor == nil then
				initialize_editor(node)
			else
				update_editor_box(node, font)
			end
			node.h = box_height(node)

Replacement in 0021-compute_layout at line 39 [8.4307]
B:BD[8.5191] → [4.313:346]
```
			update_editor_box(node, font)
```
[8.5191]
[8.5254]
```
			node.h = font:getHeight()
```
Deletion in 0021-compute_layout at line 41 [8.4307]
B:BD[8.5260] → [2.39:67]
```
		node.h = box_height(node)
```
Replacement in 0019-B at line 18 [9.6168]
B:BD[7.5046] → [7.5046:5063]
```
			if obj.w then
```
[7.5046]
[4.509]
```
			if obj.width then
```

Replacement in 0010-initialize_editor at line 2 [10.542]

B:BD[10.577] → [10.577:592]

B:BD[10.592] → [10.592:628]

B:BD[10.628] → [7.5445:5541]

B:BD[7.5541] → [3.53:213]

∅:D[3.213] → [10.859:936]

∅:D[11.1405] → [10.859:936]

∅:D[7.5676] → [10.859:936]

B:BD[10.859] → [10.859:936]

	if obj.w then
		-- use an editor to wrap the text
		local scaled_fontsize = scale(20)
		local scaled_lineheight = math.floor(scaled_fontsize*1.3)
		obj.editor = edit.initialize_state(vy(obj.y), math.floor(vx(obj.x)), math.ceil(vx(obj.x+obj.w)), love.graphics.getFont(), scaled_fontsize, scaled_lineheight)
		obj.editor.lines = load_array(obj.data)
		Text.redraw_all(obj.editor)
	end

[10.577]

[7.5677]

	-- use an editor to wrap the text
	local scaled_fontsize = scale(20)
	local scaled_lineheight = math.floor(scaled_fontsize*1.3)
	obj.editor = edit.initialize_state(vy(obj.y), math.floor(vx(obj.x)), math.ceil(vx(obj.x+obj.w)), love.graphics.getFont(), scaled_fontsize, scaled_lineheight)
	obj.editor.lines = load_array(obj.data)
	Text.redraw_all(obj.editor)

Replacement in 0007-to_text at line 3 [12.25]
B:BD[12.84] → [12.84:114]
```
		if node.type == 'text' then
```
[12.84]
[7.5733]
```
		if node.type == 'text' and node.width then
```

bugfix: text nodes always have non-nil computed width 'w'

Dependencies

In channels

Change contents

Replacement in 0026-on.draw at line 33 [5.238692]

Replacement in 0021-compute_layout at line 31 [8.4307]

Replacement in 0021-compute_layout at line 39 [8.4307]

Deletion in 0021-compute_layout at line 41 [8.4307]

Replacement in 0019-B at line 18 [9.6168]

Replacement in 0010-initialize_editor at line 2 [10.542]

Replacement in 0007-to_text at line 3 [12.25]