eschnett/cactusamrex - Change PXHMXU5HANPRQKDNFTAD4XBZXMZKU2OPGRHUSHN6B7VMFQMB2XFAC

Z4c: Set time derivativs of ADM variables correctly

Created by Erik Schnetter on April 3, 2020

PXHMXU5HANPRQKDNFTAD4XBZXMZKU2OPGRHUSHN6B7VMFQMB2XFAC

Dependencies

In channels

master

main

Change contents

Replacement in Z4c/src/adm.cxx at line 93 [3.8865]

B:BD[2.991] → [2.991:1068]

    vars.k.store(gf_kxx_, gf_kxy_, gf_kxz_, gf_kyy_, gf_kyz_, gf_kzz_, p.I);

[2.991]

[2.1068]

    vars.K.store(gf_kxx_, gf_kxy_, gf_kxz_, gf_kyy_, gf_kyz_, gf_kzz_, p.I);

Insertion in Z4c/src/adm.cxx at line 95 [3.8865]
[2.1097]
[2.1097]
```
    gf_dtalp_(p.I) = vars.dtalp;
```

Insertion in Z4c/src/adm.cxx at line 97 [3.8865]

[2.1156]

    vars.dtbeta.store(gf_dtbetax_, gf_dtbetay_, gf_dtbetaz_, p.I);

Deletion in Z4c/src/adm.cxx at line 99 [3.8865]

∅:D[4.55647] → [3.12514:12515]

∅:D[5.7975] → [3.12514:12515]

∅:D[2.1162] → [3.12514:12515]

B:BD[3.12514] → [3.12514:12515]

B:BD[3.12515] → [2.1163:1275]

∅:D[4.55933] → [3.12750:12991]

∅:D[2.1275] → [3.12750:12991]

B:BD[3.12750] → [3.12750:12991]


#warning "TODO: These are wrong!"
  loop_all<0, 0, 0>(cctkGH, [&](const PointDesc &p) { gf_dtalp_(p.I) = 0; });
  loop_all<0, 0, 0>(cctkGH, [&](const PointDesc &p) { gf_dtbetax_(p.I) = 0; });
  loop_all<0, 0, 0>(cctkGH, [&](const PointDesc &p) { gf_dtbetay_(p.I) = 0; });
  loop_all<0, 0, 0>(cctkGH, [&](const PointDesc &p) { gf_dtbetaz_(p.I) = 0; });

Insertion in Z4c/src/rhs.cxx at line 184 [3.35315]

[6.2838]

[2.3059]


    vars.K_rhs.store(gf_dtkxx_, gf_dtkxy_, gf_dtkxz_, gf_dtkyy_, gf_dtkyz_,
                     gf_dtkzz_, p.I);
    gf_dt2alp_(p.I) = vars.dtalpha_rhs;
    vars.dtbeta_rhs.store(gf_dt2betax_, gf_dt2betay_, gf_dt2betaz_, p.I);

Deletion in Z4c/src/rhs.cxx at line 254 [3.35315]

B:BD[4.84129] → [2.3066:3907]


  // ADMBase
#warning "TODO: These are wrong!"
  loop_all<0, 0, 0>(cctkGH, [&](const PointDesc &p) { gf_dtkxx_(p.I) = 0; });
  loop_all<0, 0, 0>(cctkGH, [&](const PointDesc &p) { gf_dtkxy_(p.I) = 0; });
  loop_all<0, 0, 0>(cctkGH, [&](const PointDesc &p) { gf_dtkxz_(p.I) = 0; });
  loop_all<0, 0, 0>(cctkGH, [&](const PointDesc &p) { gf_dtkyy_(p.I) = 0; });
  loop_all<0, 0, 0>(cctkGH, [&](const PointDesc &p) { gf_dtkyz_(p.I) = 0; });
  loop_all<0, 0, 0>(cctkGH, [&](const PointDesc &p) { gf_dtkzz_(p.I) = 0; });
  loop_all<0, 0, 0>(cctkGH, [&](const PointDesc &p) { gf_dt2alp_(p.I) = 0; });
  loop_all<0, 0, 0>(cctkGH, [&](const PointDesc &p) { gf_dt2betax_(p.I) = 0; });
  loop_all<0, 0, 0>(cctkGH, [&](const PointDesc &p) { gf_dt2betay_(p.I) = 0; });
  loop_all<0, 0, 0>(cctkGH, [&](const PointDesc &p) { gf_dt2betaz_(p.I) = 0; });

Replacement in Z4c/src/z4c_vars.hxx at line 43 [5.40773]

B:BD[5.41599] → [7.13705:13849]

  const mat3<T, DN, DN> g; // W = 0
  const mat3<T, DN, DN> k; // W = 0
  const T alp;             // W = 0
  const vec3<T, UP> beta;  // W = 0

[5.41599]

[5.41723]

  const mat3<T, DN, DN> g;  // W = 0
  const mat3<T, DN, DN> K;  // W = 0
  const T alp;              // W = 0
  const T dtalp;            // W = 0
  const vec3<T, UP> beta;   // W = 0
  const vec3<T, UP> dtbeta; // W = 0

Replacement in Z4c/src/z4c_vars.hxx at line 69 [5.40773]
B:BD[5.42560] → [5.42560:42590]
```
        k([&](int a, int b) {
```
[5.42560]
[5.42590]
```
        K([&](int a, int b) {
```

Replacement in Z4c/src/z4c_vars.hxx at line 73 [5.40773]

B:BD[5.42715] → [5.42715:42761]

        beta([&](int a) { return betaG(a); })

[5.42715]

[5.42761]

        // (11)
        dtalp([&] {
          const T mu_L = f_mu_L / alphaG;
          return -pow2(alphaG) * mu_L * Kh;
        }()),
        beta([&](int a) { return betaG(a); }),
        // (12)
        dtbeta([&](int a) {
          const T mu_S = f_mu_S / pow2(alphaG);
          return pow2(alphaG) * mu_S * Gamt(a) //
                 - eta * betaG(a);
        })

Replacement in Z4c/src/z4c_vars.hxx at line 181 [5.40773]
B:BD[5.46533] → [5.46533:46566]
```
  using z4c_vars_noderivs<T>::k;
```
[5.46533]
[5.46566]
```
  using z4c_vars_noderivs<T>::K;
```

Insertion in Z4c/src/z4c_vars.hxx at line 184 [5.40773]

[5.46637]

  using z4c_vars_noderivs<T>::dtalp;
  using z4c_vars_noderivs<T>::dtbeta;

Insertion in Z4c/src/z4c_vars.hxx at line 237 [5.40773]

[5.47771]

  // ADM RHS variables
  const mat3<T, DN, DN> K_rhs;
  const T dtalpha_rhs;
  const vec3<T, UP> dtbeta_rhs;

Replacement in Z4c/src/z4c_vars.hxx at line 481 [5.40773]

B:BD[5.58280] → [5.58280:58321]

        // (11)
        alphaG_rhs([&] {

[5.58280]

[5.58321]

        //
        alphaG_rhs(dtalp), betaG_rhs(dtbeta),
        //
        K_rhs([&](int a, int b) {
          return -1 / pow(chi, 2) * chi_rhs *
                     (At(a, b) + (Kh + 2 * Theta) / 3 * gammat(a, b)) +
                 1 / chi *
                     (At_rhs(a, b) +
                      (Kh_rhs + 2 * Theta_rhs) / 3 * gammat(a, b)) +
                 1 / chi * (At(a, b) + (Kh + 2 * Theta) / 3 * gammat_rhs(a, b));
        }),
        //
        dtalpha_rhs([&] {

Replacement in Z4c/src/z4c_vars.hxx at line 495 [5.40773]

B:BD[5.58363] → [5.58363:58407]

          return -pow2(alphaG) * mu_L * Kh;

[5.58363]

[5.58407]

          return -2 * alphaG * alphaG_rhs * mu_L * Kh //
                 - pow2(alphaG) * mu_L * Kh_rhs;

Replacement in Z4c/src/z4c_vars.hxx at line 498 [5.40773]

B:BD[5.58421] → [5.58421:58468]

        // (12)
        betaG_rhs([&](int a) {

[5.58421]

[5.58468]

        //
        dtbeta_rhs([&](int a) {

Replacement in Z4c/src/z4c_vars.hxx at line 501 [5.40773]

B:BD[5.58516] → [5.58516:58601]

          return pow2(alphaG) * mu_S * Gamt(a) //
                 - eta * betaG(a);

[5.58516]

[5.58601]

          return 2 * alphaG * alphaG_rhs * mu_S * Gamt(a) //
                 + pow2(alphaG) * mu_S * Gamt_rhs(a)      //
                 - eta * betaG_rhs(a);