grahamc/hydra2 - Change F3GJZVJO4M6TUSNQ65Z3EWOTZFCNZWPFN55GCJWHXRL3LKACYMMQC

SlackNotification: $build -> $topbuild, $b -> $build (perlcritic)

Created by Graham Christensen on August 20, 2021

F3GJZVJO4M6TUSNQ65Z3EWOTZFCNZWPFN55GCJWHXRL3LKACYMMQC

Dependencies

In channels

main

Change contents

Replacement in src/lib/Hydra/Plugin/SlackNotification.pm at line 80 [6.69]
B:BD[6.257] → [6.257:299]
```
    my ($self, $build, $dependents) = @_;
```
[6.257]
[6.299]
```
    my ($self, $topbuild, $dependents) = @_;
```

Replacement in src/lib/Hydra/Plugin/SlackNotification.pm at line 89 [6.69]

B:BD[6.623] → [6.623:668]

B:BD[6.668] → [4.0:81]

    foreach my $b ($build, @{$dependents}) {
        my $jobName = showJobName $b;
        my $buildStatus = $b->buildstatus;

[6.623]

[4.81]

    foreach my $build ($topbuild, @{$dependents}) {
        my $jobName = showJobName $build;
        my $buildStatus = $build->buildstatus;

Replacement in src/lib/Hydra/Plugin/SlackNotification.pm at line 94 [6.69]
∅:D[4.155] → [6.668:714]
B:BD[6.668] → [6.668:714]
```
        my $prevBuild = getPreviousBuild($b);
```
[4.155]
[4.156]
```
        my $prevBuild = getPreviousBuild($build);
```

Replacement in src/lib/Hydra/Plugin/SlackNotification.pm at line 117 [6.69]

B:BD[6.1360] → [6.1360:1422]

            push @{$channels{$channel->{url}}->{builds}}, $b;

[6.1360]

[6.1422]

            push @{$channels{$channel->{url}}->{builds}}, $build;

Replacement in src/lib/Hydra/Plugin/SlackNotification.pm at line 123 [6.69]

B:BD[6.1482] → [6.1482:1563]

    my ($authors, $nrCommits) = getResponsibleAuthors($build, $self->{plugins});

[6.1482]

[6.1563]

    my ($authors, $nrCommits) = getResponsibleAuthors($topbuild, $self->{plugins});

Replacement in src/lib/Hydra/Plugin/SlackNotification.pm at line 128 [6.69]

B:BD[6.1677] → [6.1677:1749]

        my @deps = grep { $_->id != $build->id } @{$channel->{builds}};

[6.1677]

[6.1749]

        my @deps = grep { $_->id != $topbuild->id } @{$channel->{builds}};

Replacement in src/lib/Hydra/Plugin/SlackNotification.pm at line 131 [6.69]

B:BD[6.1816] → [5.302:555]

            $build->buildstatus == 0 ? "$baseurl/static/images/checkmark_256.png" :
            $build->buildstatus == 2 ? "$baseurl/static/images/dependency_256.png" :
            $build->buildstatus == 4 ? "$baseurl/static/images/cancelled_256.png" :

[6.1816]

[5.555]

            $topbuild->buildstatus == 0 ? "$baseurl/static/images/checkmark_256.png" :
            $topbuild->buildstatus == 2 ? "$baseurl/static/images/dependency_256.png" :
            $topbuild->buildstatus == 4 ? "$baseurl/static/images/cancelled_256.png" :

Replacement in src/lib/Hydra/Plugin/SlackNotification.pm at line 137 [6.69]

B:BD[6.2138] → [6.2138:2237]

            $build->buildstatus == 0 ? "good" :
            $build->buildstatus == 4 ? "warning" :

[6.2138]

[6.2237]

            $topbuild->buildstatus == 0 ? "good" :
            $topbuild->buildstatus == 4 ? "warning" :

Replacement in src/lib/Hydra/Plugin/SlackNotification.pm at line 142 [6.69]

B:BD[6.2283] → [3.1503:1663]

        $text .= "Job <$baseurl/job/${\$build->get_column('project')}/${\$build->get_column('jobset')}/${\$build->get_column('job')}|${\showJobName($build)}>";

[6.2283]

[6.2419]

        $text .= "Job <$baseurl/job/${\$topbuild->get_column('project')}/${\$topbuild->get_column('jobset')}/${\$topbuild->get_column('job')}|${\showJobName($topbuild)}>";

Replacement in src/lib/Hydra/Plugin/SlackNotification.pm at line 144 [6.69]

B:BD[6.2490] → [2.429:543]

        $text .= ": <$baseurl/build/${\$build->id}|" . showStatus($build) . ">". " in " . renderDuration($build);

[6.2490]

[6.2571]

        $text .= ": <$baseurl/build/${\$topbuild->id}|" . showStatus($topbuild) . ">". " in " . renderDuration($topbuild);

Replacement in src/lib/Hydra/Plugin/SlackNotification.pm at line 158 [6.69]

B:BD[6.2985] → [6.2985:3100]

          [{ fallback => "Job " . showJobName($build) . " build number " . $build->id . ": " . showStatus($build),

[6.2985]

[6.3100]

          [{ fallback => "Job " . showJobName($topbuild) . " build number " . $topbuild->id . ": " . showStatus($topbuild),

Replacement in src/lib/Hydra/Plugin/SlackNotification.pm at line 162 [6.69]

B:BD[6.3187] → [6.3187:3328]

            title => "Job " . showJobName($build) . " build number " . $build->id,
            title_link => "$baseurl/build/${\$build->id}"

[6.3187]

[6.3328]

            title => "Job " . showJobName($topbuild) . " build number " . $topbuild->id,
            title_link => "$baseurl/build/${\$topbuild->id}"