grahamc/hydra2 - Change G2WXEQHE6WCBN25VLO6XF3FJAOCJLMRKYOIQLETGIWTR6ON2AIVAC

Remove the Errors page

The same info is readily available under the most recent jobset eval page.

Created by Eelco Dolstra on October 3, 2013

G2WXEQHE6WCBN25VLO6XF3FJAOCJLMRKYOIQLETGIWTR6ON2AIVAC

Dependencies

In channels

main

Change contents

Deletion in src/lib/Hydra/Base/Controller/ListBuilds.pm at line 8 [6.1]

B:BD[5.77] → [5.77:123]

B:BD[5.123] → [7.812:813]

∅:D[7.813] → [8.7:65]

B:BD[8.7] → [8.7:65]

∅:D[8.65] → [6.165:166]

∅:D[9.326] → [6.165:166]

B:BD[6.165] → [6.165:166]

B:BD[6.166] → [10.0:49]

∅:D[10.49] → [8.66:149]

B:BD[11.603] → [8.66:149]

B:BD[8.149] → [10.50:176]

∅:D[12.167] → [13.0:59]

∅:D[10.176] → [13.0:59]

B:BD[11.741] → [13.0:59]

∅:D[13.59] → [11.787:800]

B:BD[11.787] → [11.787:800]

∅:D[11.800] → [9.327:349]

B:BD[6.166] → [9.327:349]

B:BD[9.349] → [14.0:1]

∅:D[14.1] → [6.166:167]

∅:D[9.349] → [6.166:167]

B:BD[6.166] → [6.166:167]

∅:D[14.3] → [15.4:69]

B:BD[15.4] → [15.4:69]

B:BD[15.69] → [7.814:841]

∅:D[7.841] → [15.97:534]

B:BD[15.97] → [15.97:534]

B:BD[15.534] → [10.177:250]

∅:D[16.63] → [6.330:332]

∅:D[17.86] → [6.330:332]

∅:D[18.170] → [6.330:332]

∅:D[10.250] → [6.330:332]

∅:D[9.490] → [6.330:332]

∅:D[15.630] → [6.330:332]

∅:D[11.879] → [6.330:332]

B:BD[6.330] → [6.330:332]


sub getJobStatus {
    my ($self, $c) = @_;
    my $maintainer = $c->request->params->{"maintainer"};
    my $latest = $c->stash->{jobStatus}->search(
        defined $maintainer ? { maintainers => { like => "%$maintainer%" } } : {},
        { '+select' => ["me.statusChangeId", "me.statusChangeTime"]
        , '+as' => ["statusChangeId", "statusChangeTime"]
        , order_by => "coalesce(statusChangeTime, 0) desc"
        });
    return $latest;
}
# A convenient way to see all the errors - i.e. things demanding
# attention - at a glance.
sub errors : Chained('get_builds') PathPart Args(0) {
    my ($self, $c) = @_;
    $c->stash->{template} = 'errors.tt';
    $c->stash->{brokenJobsets} =
        [$c->stash->{allJobsets}->search({errormsg => {'!=' => ''}})]
        if defined $c->stash->{allJobsets};
    $c->stash->{brokenJobs} =
        [$c->stash->{allJobs}->search({errormsg => {'!=' => ''}})]
        if defined $c->stash->{allJobs};
    $c->stash->{brokenBuilds} =
        [getJobStatus($self, $c)->search({buildStatus => {'!=' => 0}})];
}

Replacement in src/lib/Hydra/Controller/Job.pm at line 43 [21.46]

B:BD[19.234] → [20.0:123]

∅:D[20.123] → [19.357:556]

B:BD[19.357] → [19.357:556]

	{ aggregate => { -in => $job->builds->search({}, { columns => ["id"], order_by => "id desc", rows => 15 })->as_query } },
	{ join => 'aggregateconstituents_constituents', 
	  columns => ['id', 'job', 'finished', 'buildstatus'],
	  +select => ['aggregateconstituents_constituents.aggregate'],
	  +as => ['aggregate']
	});

[19.234]

[19.556]

        { aggregate => { -in => $job->builds->search({}, { columns => ["id"], order_by => "id desc", rows => 15 })->as_query } },
        { join => 'aggregateconstituents_constituents', 
          columns => ['id', 'job', 'finished', 'buildstatus'],
          +select => ['aggregateconstituents_constituents.aggregate'],
          +as => ['aggregate']
        });

Replacement in src/lib/Hydra/Controller/Job.pm at line 53 [21.46]

B:BD[19.643] → [19.643:681]

B:BD[19.681] → [20.124:198]

B:BD[20.198] → [4.0:81]

∅:D[4.81] → [19.819:852]

B:BD[19.819] → [19.819:852]

	my $jobName = $b->get_column('job');
	$aggregates->{$b->get_column('aggregate')}->{constituents}->{$jobName} =
	    { id => $b->id, finished => $b->finished, buildstatus => $b->buildstatus };
	$constituentJobs{$jobName} = 1;

[19.643]

[20.199]

        my $jobName = $b->get_column('job');
        $aggregates->{$b->get_column('aggregate')}->{constituents}->{$jobName} =
            { id => $b->id, finished => $b->finished, buildstatus => $b->buildstatus };
        $constituentJobs{$jobName} = 1;

Replacement in src/lib/Hydra/Controller/Job.pm at line 60 [21.46]

B:BD[20.248] → [20.248:410]

	# FIXME: could be done in one query.
	$aggregates->{$agg}->{build} = 
	    $c->model('DB::Builds')->find({id => $agg}, {columns => [@buildListColumns]}) or die;

[20.248]

[19.852]

        # FIXME: could be done in one query.
        $aggregates->{$agg}->{build} = 
            $c->model('DB::Builds')->find({id => $agg}, {columns => [@buildListColumns]}) or die;

Deletion in src/lib/Hydra/Controller/Job.pm at line 76 [21.46]
B:BD[16.578] → [15.804:850]
```
    $c->stash->{allJobs} = $c->stash->{job_};
```

Deletion in src/lib/Hydra/Controller/Jobset.pm at line 188 [22.104]

B:BD[16.946] → [15.984:1090]

    $c->stash->{allJobsets} = $c->stash->{jobset_};
    $c->stash->{allJobs} = $c->stash->{jobset}->jobs;

Deletion in src/lib/Hydra/Controller/Project.pm at line 207 [6.1245]

B:BD[16.1267] → [15.1091:1207]

    $c->stash->{allJobsets} = $c->stash->{project}->jobsets;
    $c->stash->{allJobs} = $c->stash->{project}->jobs;

Deletion in src/lib/Hydra/Controller/Root.pm at line 154 [23.804]

B:BD[16.1491] → [15.1208:1314]

    $c->stash->{allJobsets} = $c->model('DB::Jobsets');
    $c->stash->{allJobs} = $c->model('DB::Jobs');

File deletion: errors.tt

BF:BFD[24.1486] → [15.3038:3071]

BF:BFD[15.3071] → [15.1442:1442]

B:BD[15.1442] → [15.1443:1506]

∅:D[25.7238] → [15.1523:1816]

B:BD[15.1523] → [15.1523:1816]

B:BD[15.1816] → [3.541:593]

∅:D[26.459] → [15.1854:2095]

∅:D[3.593] → [15.1854:2095]

∅:D[27.3617] → [15.1854:2095]

B:BD[15.1854] → [15.1854:2095]

B:BD[15.2095] → [28.121:186]

∅:D[28.186] → [15.2173:2342]

B:BD[15.2173] → [15.2173:2342]

B:BD[15.2342] → [3.594:646]

∅:D[26.524] → [15.2380:2633]

∅:D[3.646] → [15.2380:2633]

∅:D[27.3692] → [15.2380:2633]

B:BD[15.2380] → [15.2380:2633]

B:BD[15.2633] → [28.187:252]

∅:D[28.252] → [15.2711:2872]

B:BD[15.2711] → [15.2711:2872]

B:BD[15.2872] → [29.457:588]

∅:D[29.588] → [15.2922:3037]

∅:D[11.2564] → [15.2922:3037]

B:BD[15.2922] → [15.2922:3037]

[% WRAPPER layout.tt title="Errors" %]
[% PROCESS common.tt %]
<p>This page provides a quick way to see how FUBARed your packages
are.  It shows job expressions that don’t evaluate properly and jobs
that don’t build.</p>
[% haveErrors = 0 %]
[% IF brokenJobsets && brokenJobsets.size > 0; haveErrors = 1 %]
<h2>Evaluation errors in jobsets</h2>
<table class="table table-condensed table-striped">
  <thead>
    <tr>
      <th>Name</th>
      <th>Error</th>
    </tr>
  </thead>
  <tdata>
    [% FOREACH j IN brokenJobsets %]
      <tr>
        <td>[% INCLUDE renderFullJobsetName project=j.project.name jobset=j.name %]</td>
        <td>
          <pre class="error">[% HTML.escape(j.errormsg) %]</pre>
        </td>
      </tr>
    [% END %]
  </tdata>
</table>
[% END %]
[% IF brokenJobs && brokenJobs.size > 0; haveErrors = 1 %]
<h2>Evaluation errors in jobs</h2>
<table class="table table-condensed table-striped">
  <thead>
    <tr>
      <th>Name</th>
      <th>Error</th>
    </tr>
  </thead>
  <tdata>
    [% FOREACH j IN brokenJobs %]
      <tr>
        <td>[% INCLUDE renderFullJobName project=j.project.name jobset=j.jobset.name job=j.name %]</td>
        <td>
          <pre class="error">[% HTML.escape(j.errormsg) %]</pre>
        </td>
      </tr>
    [% END %]
  </tdata>
</table>
[% END %]
[% IF brokenBuilds && brokenBuilds.size > 0; haveErrors = 1 %]
<h2>Broken builds</h2>
[% INCLUDE renderBuildList builds=brokenBuilds showStatusChange=1 hideProjectName=project hideJobsetName=jobset hideJobName=job %]
[% END %]
[% IF !haveErrors %]
<p><strong>There are currently no problems.</strong></p>
[% END %]
[% END %]

Deletion in src/root/topbar.tt at line 36 [30.6671]

B:BD[27.11768] → [27.11768:11892]

      [% INCLUDE menuItem uri = c.uri_for(c.controller('Project').action_for('errors'), [project.name]) title = "Errors" %]

Deletion in src/root/topbar.tt at line 53 [30.6671]

B:BD[27.12981] → [2.233:259]

∅:D[2.259] → [27.13007:13133]

B:BD[27.13007] → [27.13007:13133]

      [% INCLUDE menuItem
        uri = c.uri_for(c.controller('Jobset').action_for('errors'), [project.name, jobset.name])
        title = "Errors" %]

Deletion in src/root/topbar.tt at line 67 [30.6671]

B:BD[31.281] → [2.314:340]

∅:D[2.367] → [27.14040:14173]

B:BD[27.14040] → [27.14040:14173]

      [% INCLUDE menuItem
        uri = c.uri_for(c.controller('Job').action_for('errors'), [project.name, jobset.name, job.name])
        title = "Errors" %]