grahamc/hydra2 - Change G6TPSF2746JT5XQAUREDXQ4R2G4BUYOMHIBJ4VGMRPAB4INHEP7AC

EmailNotification: $build -> $topbuild, $b -> $build (perlcritic)

Created by Graham Christensen on August 20, 2021

G6TPSF2746JT5XQAUREDXQ4R2G4BUYOMHIBJ4VGMRPAB4INHEP7AC

Dependencies

In channels

main

Change contents

Replacement in src/lib/Hydra/Plugin/EmailNotification.pm at line 49 [6.21]
B:BD[6.693] → [7.29:71]
```
    my ($self, $build, $dependents) = @_;
```
[6.693]
[4.155]
```
    my ($self, $topbuild, $dependents) = @_;
```
Replacement in src/lib/Hydra/Plugin/EmailNotification.pm at line 51 [6.21]
B:BD[6.750] → [6.750:783]
```
    die unless $build->finished;
```
[4.156]
[8.618]
```
    die unless $topbuild->finished;
```

Replacement in src/lib/Hydra/Plugin/EmailNotification.pm at line 57 [6.21]

B:BD[8.816] → [8.816:861]

B:BD[8.861] → [9.820:866]

    foreach my $b ($build, @{$dependents}) {
        my $prevBuild = getPreviousBuild($b);

[8.816]

[2.0]

    foreach my $build ($topbuild, @{$dependents}) {
        my $prevBuild = getPreviousBuild($build);

Replacement in src/lib/Hydra/Plugin/EmailNotification.pm at line 61 [6.21]

B:BD[2.99] → [2.99:148]

            next unless $b->jobset->enableemail;

[2.99]

[6.783]

            next unless $build->jobset->enableemail;

Replacement in src/lib/Hydra/Plugin/EmailNotification.pm at line 64 [6.21]

B:BD[2.216] → [2.216:282]

            next if $b->buildstatus == 4 || $b->buildstatus == 3;

[2.216]

[8.1092]

            next if $build->buildstatus == 4 || $build->buildstatus == 3;

Replacement in src/lib/Hydra/Plugin/EmailNotification.pm at line 68 [6.21]

B:BD[2.417] → [2.417:505]

            next if defined $prevBuild && ($b->buildstatus == $prevBuild->buildstatus);

[2.417]

[2.505]

            next if defined $prevBuild && ($build->buildstatus == $prevBuild->buildstatus);

Replacement in src/lib/Hydra/Plugin/EmailNotification.pm at line 71 [6.21]

B:BD[6.1175] → [2.516:612]

        my $to = $b->jobset->emailoverride ne "" ? $b->jobset->emailoverride : $b->maintainers;

[6.1175]

[6.1372]

        my $to = $build->jobset->emailoverride ne "" ? $build->jobset->emailoverride : $build->maintainers;

Replacement in src/lib/Hydra/Plugin/EmailNotification.pm at line 77 [6.21]

B:BD[8.1700] → [8.1700:1756]

            push @{$addresses{$address}->{builds}}, $b;

[8.1700]

[8.1756]

            push @{$addresses{$address}->{builds}}, $build;

Replacement in src/lib/Hydra/Plugin/EmailNotification.pm at line 81 [6.21]

B:BD[10.147] → [11.581:682]

    my ($authors, $nrCommits, $emailable_authors) = getResponsibleAuthors($build, $self->{plugins});

[10.147]

[10.228]

    my ($authors, $nrCommits, $emailable_authors) = getResponsibleAuthors($topbuild, $self->{plugins});

Replacement in src/lib/Hydra/Plugin/EmailNotification.pm at line 83 [6.21]
B:BD[10.248] → [3.0:46]
```
    my $prevBuild = getPreviousBuild($build);
```
[10.248]
[3.46]
```
    my $prevBuild = getPreviousBuild($topbuild);
```

Replacement in src/lib/Hydra/Plugin/EmailNotification.pm at line 85 [6.21]

B:BD[3.85] → [3.85:172]

        ((!defined $prevBuild) || ($build->buildstatus != $prevBuild->buildstatus))) {

[3.85]

[10.286]

        ((!defined $prevBuild) || ($topbuild->buildstatus != $prevBuild->buildstatus))) {

Replacement in src/lib/Hydra/Plugin/EmailNotification.pm at line 88 [6.21]

∅:D[12.138] → [11.683:766]

B:BD[10.454] → [11.683:766]

        $addresses{$_} = { builds => [ $build ] } foreach (@{$emailable_authors});

[12.138]

[6.1725]

        $addresses{$_} = { builds => [ $topbuild ] } foreach (@{$emailable_authors});

Replacement in src/lib/Hydra/Plugin/EmailNotification.pm at line 99 [6.21]

B:BD[13.1209] → [9.867:936]

∅:D[9.936] → [13.1281:1349]

B:BD[13.1281] → [13.1281:1349]

            { build => $build, prevBuild => getPreviousBuild($build)
            , dependents => [grep { $_->id != $build->id } @builds]

[13.1209]

[14.1794]

            { build => $topbuild, prevBuild => getPreviousBuild($topbuild)
            , dependents => [grep { $_->id != $topbuild->id } @builds]

Replacement in src/lib/Hydra/Plugin/EmailNotification.pm at line 103 [6.21]

B:BD[13.1502] → [5.746:829]

            , showSystem => index($build->get_column('job'), $build->system) == -1

[13.1502]

[10.455]

            , showSystem => index($topbuild->get_column('job'), $topbuild->system) == -1

Replacement in src/lib/Hydra/Plugin/EmailNotification.pm at line 116 [6.21]

B:BD[14.1870] → [14.1870:2007]

            showStatus($build) . ": Hydra job " . showJobName($build)
            . ($vars->{showSystem} ? " on " . $build->system : "")

[14.1870]

[14.2007]

            showStatus($topbuild) . ": Hydra job " . showJobName($topbuild)
            . ($vars->{showSystem} ? " on " . $topbuild->system : "")

Replacement in src/lib/Hydra/Plugin/EmailNotification.pm at line 122 [6.21]

B:BD[14.2190] → [5.830:1026]

∅:D[5.1026] → [14.2362:2413]

B:BD[14.2362] → [14.2362:2413]

            [ 'X-Hydra-Project'  => $build->get_column('project'),
            , 'X-Hydra-Jobset'   => $build->get_column('jobset'),
            , 'X-Hydra-Job'      => $build->get_column('job'),
            , 'X-Hydra-System'   => $build->system

[14.2190]

[14.2413]

            [ 'X-Hydra-Project'  => $topbuild->get_column('project'),
            , 'X-Hydra-Jobset'   => $topbuild->get_column('jobset'),
            , 'X-Hydra-Job'      => $topbuild->get_column('job'),
            , 'X-Hydra-System'   => $topbuild->system