grahamc/hydra2 - Change M4FPGVN4YPWIRHA6CPRT2ZZKIGR6BDQ7LJ4SDSZLZLSLMPJBNGWQC

perlcritic: make all open() calls three-argument

Two-argument calls end up parsing the second argument to guess what should happen, three-arg parses … less?

Created by Graham Christensen on October 19, 2021

M4FPGVN4YPWIRHA6CPRT2ZZKIGR6BDQ7LJ4SDSZLZLSLMPJBNGWQC

Dependencies

In channels

main

Change contents

Replacement in src/lib/Hydra/Helper/Nix.pm at line 144 [6.436]

B:BD[4.24] → [5.0:79]

    open my $root, ">$link" or die "cannot create GC root `$link' to `$path'";

[4.24]

[5.79]

    open(my $root, ">", $link) or die "cannot create GC root `$link' to `$path'";

Replacement in src/lib/Hydra/Helper/Nix.pm at line 345 [6.436]

B:BD[7.2084] → [5.97:145]

        open my $conf, "<$machinesFile" or die;

[7.2084]

[3.0]

        open(my $conf, "<", $machinesFile) or die;

Replacement in src/lib/Hydra/View/NixClosure.pm at line 17 [6.714]

∅:D[8.3103] → [9.5:78]

B:BD[9.5] → [9.5:78]

    open $fh, "nix-store --export `nix-store -qR @storePaths` | gzip |";

[8.3103]

[6.1248]

    open($fh, "-|", "nix-store --export `nix-store -qR @storePaths` | gzip");

Replacement in src/lib/Hydra/View/NixLog.pm at line 20 [10.527]

B:BD[10.824] → [11.1488:1605]

        my $doTail = $tail ? " tail -n '$tail' |" : "";
        open $fh, "bzip2 -dc < '$logPath' | $doTail" or die;

[10.824]

[10.877]

        my $doTail = $tail ? "| tail -n '$tail'" : "";
        open($fh, "-|", "bzip2 -dc < '$logPath' $doTail") or die;

Replacement in src/lib/Hydra/View/NixLog.pm at line 24 [10.527]

B:BD[11.1627] → [11.1627:1688]

            open $fh, "tail -n '$tail' '$logPath' |" or die;

[11.1627]

[11.1688]

            open($fh, "-|", "tail -n '$tail' '$logPath'") or die;

Replacement in src/lib/Hydra/View/NixLog.pm at line 26 [10.527]
B:BD[11.1705] → [11.1705:1747]
```
            open $fh, "<$logPath" or die;
```
[11.1705]
[11.1747]
```
            open($fh, "<", $logPath) or die;
```

Replacement in src/lib/Hydra/View/NixNAR.pm at line 19 [13.484]

B:BD[8.3115] → [12.309:376]

    open $fh, "nix-store --dump '$storePath' | pixz -0 $pParam |";

[8.3115]

[13.866]

    open($fh, "-|", "nix-store --dump '$storePath' | pixz -0 $pParam");

Replacement in t/plugins/gitea.t at line 63 [2.1497]

B:BD[2.3498] → [2.3498:3552]

open my $fh, $filename or die ("Can't open(): $!\n");

[2.3498]

[2.3552]

open(my $fh, "<", $filename) or die ("Can't open(): $!\n");