itai.sharim/TagFight - Change L4TF5YRRHYUPEAF72DU2GO3PBK5CXXHPYZB5SX3NRCUN6AQELH2QC

Use SerializeReference to edit specific effect in editor

Created by itai.sharim on October 17, 2022

L4TF5YRRHYUPEAF72DU2GO3PBK5CXXHPYZB5SX3NRCUN6AQELH2QC

Dependencies

In channels

main

Change contents

Replacement in Assets/Scripts/Combat/Runes/RuneRef.cs at line 7 [4.2420]
B:BD[4.2571] → [4.2571:2612]
```
public class RuneRef : ScriptableObject
```
[4.2571]
[4.2612]
```
public class RuneRef : ScriptableObject, ISerializationCallbackReceiver
```

Insertion in Assets/Scripts/Combat/Runes/RuneRef.cs at line 25 [4.2420]

[5.5317]

[4.2942]


    public void OnBeforeSerialize() {
    }
    public void OnAfterDeserialize() {
        rune.Populate();
    }

Insertion in Assets/Scripts/Combat/Runes/Rune.cs at line 4 [4.3265]
[4.3383]
[3.5339]
```
using TypeReferences;
```
Replacement in Assets/Scripts/Combat/Runes/Rune.cs at line 8 [4.3265]
B:BD[4.3401] → [4.3401:3403]
B:BD[4.3403] → [3.5360:5413]
```
public class Rune :  ISerializationCallbackReceiver
```
[4.3401]
[4.3422]
```
public class Rune
```

Replacement in Assets/Scripts/Combat/Runes/Rune.cs at line 10 [4.3265]

B:BD[4.3425] → [6.636:718]

    public List<EffectRef> effects = new();
    List<IEffect> _effects = new();

[4.3425]

[4.3528]

    public List<EffectTypePair> Effects = new();

Replacement in Assets/Scripts/Combat/Runes/Rune.cs at line 21 [4.3265]

B:BD[4.3736] → [4.3736:3787]

B:BD[4.3787] → [7.403:537]

        Clear();
        if (_effects != null) {
            _effects.AddRange(effects.Where(effectRef => effectRef.EffectType.Type != null).Select(effectRef => effectRef.Build()));

[4.3736]

[4.3828]

        foreach (var pair in Effects) {
            pair.Populate();

Deletion in Assets/Scripts/Combat/Runes/Rune.cs at line 25 [4.3265]
B:BD[4.3846] → [4.3846:3848]

Deletion in Assets/Scripts/Combat/Runes/Rune.cs at line 26 [4.3265]

B:BD[4.3875] → [4.3875:3950]

        if (_effects != null) {
            _effects.Clear();
        }

Deletion in Assets/Scripts/Combat/Runes/Rune.cs at line 27 [4.3265]
B:BD[4.3957] → [4.3957:3959]

Replacement in Assets/Scripts/Combat/Runes/Rune.cs at line 28 [4.3265]

B:BD[4.4006] → [7.538:582]

        foreach (var effect in _effects) {

[4.4006]

[4.4051]

        foreach (var effect in Effects.Select(pair => pair.Effect)) {

Insertion in Assets/Scripts/Combat/Runes/Rune.cs at line 32 [4.3265]
[3.5421]
[3.5421]
```
}
```

Replacement in Assets/Scripts/Combat/Runes/Rune.cs at line 34 [4.3265]

B:BD[3.5423] → [3.5423:5462]

    public void OnBeforeSerialize() {

[3.5423]

[4.4099]

[Serializable]
public class EffectTypePair
{
    [ClassImplements(typeof(IEffect))]
    public ClassTypeReference EffectType;
    [SerializeReference]
    public IEffect Effect = new CountTagsImmidiateEffect();
    public void Populate() {
        if (EffectType == null || EffectType.Type == null) {
            Effect = null;
        }
        else if (Effect == null || EffectType.Type != Effect.GetType()) {
            Effect = (IEffect)Activator.CreateInstance(EffectType.Type);
        }

Replacement in Assets/Scripts/Combat/Runes/Rune.cs at line 52 [4.3265]
B:BD[3.5465] → [3.5465:5533]
∅:D[3.5533] → [4.4110:4113]
B:BD[4.4110] → [4.4110:4113]
```
    public void OnAfterDeserialize() {
        Populate();
    }
}
```
[3.5465]
```
}
```
Insertion in Assets/Scripts/Combat/Runes/Effects/RemoveTagsEffect.cs at line 4 [4.4675]
[4.4758]
[4.4758]
```
using System;
```
Insertion in Assets/Scripts/Combat/Runes/Effects/RemoveTagsEffect.cs at line 6 [4.4675]
[4.4760]
[4.4760]
```
[Serializable]
```

Replacement in Assets/Scripts/Combat/Runes/Effects/RemoveTagsEffect.cs at line 9 [4.4675]

B:BD[4.4804] → [6.726:805]

    TagColor Color { get; set; }
    float Multiplicative { get; set; } = 1;

[4.4804]

[4.4919]

    [SerializeField] TagColor Color;
    [SerializeField] float Multiplicative = 1f;

Replacement in Assets/Scripts/Combat/Runes/Effects/RemoveTagsEffect.cs at line 12 [4.4675]
B:BD[4.4921] → [6.806:836]
```
    float Flat { get; set; }
```
[4.4921]
[4.4973]
```
    [SerializeField] float Flat;
```
Replacement in Assets/Scripts/Combat/Runes/Effects/RemoveTagsEffect.cs at line 14 [4.4675]
B:BD[4.4975] → [5.5523:5572]
```
    bool MultiplicativeBeforeFlat { get; set; }
```
[4.4975]
[5.5573]
```
    [SerializeField] bool MultiplicativeBeforeFlat;
```
Insertion in Assets/Scripts/Combat/Runes/Effects/ReleaseEffect.cs at line 1 [8.2160]
[8.2160]
[8.2161]
```
using System;
using UnityEngine;
[Serializable]
```
Replacement in Assets/Scripts/Combat/Runes/Effects/ReleaseEffect.cs at line 8 [8.2160]
B:BD[8.2204] → [8.2204:2247]
```
    AreaOfEffect AreaOfEffect {get; set;}
```
[8.2204]
[8.2247]
```
    [SerializeField] AreaOfEffect AreaOfEffect;
```

Replacement in Assets/Scripts/Combat/Runes/Effects/CountTagsImmidiateEffect.cs at line 6 [9.865]

B:BD[9.960] → [9.960:1037]

    TagColor Color { get; set; }
    AreaOfEffect AreaOfEffect {get; set;}

[9.960]

[9.1037]

    [SerializeField] TagColor Color;
    [SerializeField] AreaOfEffect AreaOfEffect;

Replacement in Assets/Scripts/Combat/Runes/Effects/CountTagsImmidiateEffect.cs at line 9 [9.865]
B:BD[9.1039] → [9.1039:1078]
```
    bool FriendOrFoeOff { get; set; }
```
[9.1039]
[9.1078]
```
    [SerializeField] bool FriendOrFoeOff;
```
Replacement in Assets/Scripts/Combat/Runes/Effects/CountTagsEffect.cs at line 5 [4.7015]
B:BD[4.7143] → [5.6475:6509]
```
    TagColor Color { get; set; }
```
[4.7143]
[4.7198]
```
    [SerializeField] TagColor Color;
```
Insertion in Assets/Scripts/Combat/Runes/Effects/CountTagsEffect.cs at line 7 [4.7015]
[4.7200]
[4.7258]
```
    [SerializeField] bool FriendOrFoeOff;
```
Deletion in Assets/Scripts/Combat/Runes/Effects/CountTagsEffect.cs at line 9 [4.7015]
B:BD[4.7260] → [5.6548:6587]
```
    bool FriendOrFoeOff { get; set; }
```
Replacement in Assets/Scripts/Combat/Runes/Effects/ApplyTagsEffect.cs at line 7 [10.295]
B:BD[10.396] → [10.396:435]
```
    bool FriendOrFoeOff { get; set; }
```
[10.396]
[10.435]
```
    [SerializeField] bool FriendOrFoeOff;
```
Replacement in Assets/Scripts/Combat/Runes/Effects/ApplyDamageEffect.cs at line 8 [11.297]
B:BD[5.7288] → [5.7288:7327]
```
    bool FriendOrFoeOff { get; set; }
```
[5.7251]
[11.504]
```
    [SerializeField] bool FriendOrFoeOff;
```

Replacement in Assets/Scripts/Combat/Runes/Effects/AddTagsEffect.cs at line 9 [4.11362]

B:BD[4.11519] → [5.7537:7611]

    TagColor Color { get; set; }
    float Multiplicative { get; set; }

[4.11519]

[4.11632]

    [SerializeField] TagColor Color;
    [SerializeField] float Multiplicative;

Replacement in Assets/Scripts/Combat/Runes/Effects/AddTagsEffect.cs at line 12 [4.11362]
B:BD[4.11634] → [5.7612:7642]
```
    float Flat { get; set; }
```
[4.11634]
[4.11686]
```
    [SerializeField] float Flat;
```
Replacement in Assets/Scripts/Combat/Runes/Effects/AddTagsEffect.cs at line 14 [4.11362]
B:BD[4.11688] → [5.7643:7692]
```
    bool MultiplicativeBeforeFlat { get; set; }
```
[4.11688]
[4.11751]
```
    [SerializeField] bool MultiplicativeBeforeFlat;
```
Insertion in Assets/Scripts/Combat/Runes/Effects/AccumulateDamageByTagEffect.cs at line 9 [4.12412]
[4.12583]
[4.12583]
```
    [SerializeField] TagColor Color;
    [SerializeField] float Multiplier = 1f;
```
Deletion in Assets/Scripts/Combat/Runes/Effects/AccumulateDamageByTagEffect.cs at line 12 [4.12412]
B:BD[6.3538] → [6.3538:3572]
B:BD[6.3594] → [6.3594:3635]
B:BD[6.3635] → [12.733:733]
∅:D[12.733] → [4.12703:12705]
∅:D[6.3635] → [4.12703:12705]
∅:D[5.8321] → [4.12703:12705]
B:BD[4.12703] → [4.12703:12705]
```
    TagColor Color { get; set; }
    float Multiplier { get; set; } = 1;
```
Insertion in Assets/Scripts/Combat/Martial/CombatMove.cs at line 1 [13.5093]
[13.5093]
[13.5094]
```
using System;
```
Deletion in Assets/Scripts/Combat/Martial/CombatMove.cs at line 5 [13.5093]
B:BD[13.5176] → [14.21921:21936]
```
using System;
```

Replacement in Assets/ScriptableObjects/Runes/Sand.asset at line 16 [15.1041]

B:BD[15.1443] → [16.429:657]

    effects:
    - EffectType: AccumulateDamageByTag
      Color: 0
      Multiplicative: 0
      Flat: 0
      MultiplicativeBeforeFlat: 0
      Area:
        length: 0
        width: 0
        shape: 0
      FriendOrFoeOff: 0

[15.1443]

[15.1459]

    effects: []
    _effects: []

Insertion in Assets/ScriptableObjects/Runes/Sand.asset at line 22 [15.1041]
[15.1588]
```
  references:
    version: 2
    RefIds: []
```

Replacement in Assets/ScriptableObjects/Runes/Jolt.asset at line 16 [15.2994]

B:BD[15.3396] → [16.664:878]

    effects:
    - EffectType: AddTags
      Color: 0
      Multiplicative: 0
      Flat: 0
      MultiplicativeBeforeFlat: 0
      Area:
        length: 0
        width: 0
        shape: 0
      FriendOrFoeOff: 0

[15.3396]

[15.3412]

    effects: []
    _effects: []

Insertion in Assets/ScriptableObjects/Runes/Jolt.asset at line 22 [15.2994]
[15.3541]
```
  references:
    version: 2
    RefIds: []
```

Replacement in Assets/ScriptableObjects/Runes/Flame.asset at line 16 [15.3811]

B:BD[15.4214] → [12.786:799]

B:BD[12.799] → [17.6073:6111]

∅:D[16.921] → [12.818:993]

∅:D[17.6111] → [12.818:993]

B:BD[12.818] → [12.818:993]

B:BD[12.993] → [17.6112:6146]

    effects:
    - EffectType:
        _classRef: 
      Color: 0
      Multiplicative: 0
      Flat: 0
      MultiplicativeBeforeFlat: 0
      Area:
        length: 0
        width: 0
        shape: 0
      FriendOrFoeOff: 0
    effectsRef:
    - _classRef:

[15.4214]

[15.4230]

    effects: []
    _effects: []

Replacement in Assets/ScriptableObjects/Runes/Flame.asset at line 19 [15.3811]
B:BD[15.4246] → [15.4246:4261]
```
    speed: 1.2
```
[15.4246]
[15.4261]
```
    speed: 1.3
```
Insertion in Assets/ScriptableObjects/Runes/Flame.asset at line 22 [15.3811]
[15.4360]
```
  references:
    version: 2
    RefIds: []
```
Replacement in Assets/ScriptableObjects/Runes/Double Count.asset at line 16 [18.241]
B:BD[18.651] → [18.651:664]
```
    effects:
```
[18.651]
[18.664]
```
    Effects:
```

Replacement in Assets/ScriptableObjects/Runes/Double Count.asset at line 19 [18.241]

∅:D[3.6265] → [18.743:842]

B:BD[18.743] → [18.743:842]

B:BD[18.842] → [3.6266:6301]

∅:D[3.6301] → [18.879:920]

B:BD[18.879] → [18.879:920]

      Color: 2
      Multiplicative: 0
      Flat: 0
      MultiplicativeBeforeFlat: 0
      Area:
        length: 1
        width: 1
        shape: 1
      FriendOrFoeOff: 0

[3.6265]

[18.920]

      Effect:
        rid: 7043444392066023425

Insertion in Assets/ScriptableObjects/Runes/Double Count.asset at line 25 [18.241]

[18.1048]

  references:
    version: 2
    RefIds:
    - rid: 7043444392066023425
      type: {class: CountTagsEffect, ns: , asm: Assembly-CSharp}
      data:
        Color: 2
        FriendOrFoeOff: 0

Replacement in Assets/ScriptableObjects/Runes/DemoCount.asset at line 16 [9.2213]
B:BD[9.2620] → [9.2620:2633]
```
    effects:
```
[9.2620]
[3.6320]
```
    Effects:
```

Replacement in Assets/ScriptableObjects/Runes/DemoCount.asset at line 19 [9.2213]

∅:D[3.6399] → [9.2670:2847]

B:BD[9.2670] → [9.2670:2847]

      Color: 0
      Multiplicative: 0
      Flat: 0
      MultiplicativeBeforeFlat: 0
      Area:
        length: 15
        width: 15
        shape: 1
      FriendOrFoeOff: 0

[3.6399]

[3.6400]

      Effect:
        rid: 7043444392066023424

Insertion in Assets/ScriptableObjects/Runes/DemoCount.asset at line 25 [9.2213]

[3.6513]

  references:
    version: 2
    RefIds:
    - rid: 7043444392066023424
      type: {class: CountTagsImmidiateEffect, ns: , asm: Assembly-CSharp}
      data:
        Color: 0
        AreaOfEffect:
          length: 15
          width: 15
          shape: 1
        FriendOrFoeOff: 0

Replacement in Assets/Scenes/SampleScene.unity at line 5861 [19.780110080]

B:BD[19.780121071] → [3.6594:6675]

  m_LocalRotation: {x: 0.22914574, y: -0.070709094, z: 0.016692149, w: 0.970677}

[19.780121071]

[20.33888019]

  m_LocalRotation: {x: 0.22914575, y: -0.0707091, z: 0.01669215, w: 0.970677}

Deletion in Assets/Scenes/SampleScene.unity at line 8666 [19.780110080]
B:BD[21.650] → [2.623:623]

Replacement in Assets/Scenes/SampleScene.unity at line 8682 [19.780110080]

B:BD[19.780162310] → [3.6716:6797]

  m_LocalRotation: {x: 0.22914574, y: -0.070709094, z: 0.016692149, w: 0.970677}

[19.780162310]

[20.33918016]

  m_LocalRotation: {x: 0.22914575, y: -0.0707091, z: 0.01669215, w: 0.970677}

Use SerializeReference to edit specific effect in editor

Dependencies

In channels

Change contents

Replacement in Assets/Scripts/Combat/Runes/RuneRef.cs at line 7 [4.2420]

Insertion in Assets/Scripts/Combat/Runes/RuneRef.cs at line 25 [4.2420]

Insertion in Assets/Scripts/Combat/Runes/Rune.cs at line 4 [4.3265]

Replacement in Assets/Scripts/Combat/Runes/Rune.cs at line 8 [4.3265]

Replacement in Assets/Scripts/Combat/Runes/Rune.cs at line 10 [4.3265]

Replacement in Assets/Scripts/Combat/Runes/Rune.cs at line 21 [4.3265]

Deletion in Assets/Scripts/Combat/Runes/Rune.cs at line 25 [4.3265]

Deletion in Assets/Scripts/Combat/Runes/Rune.cs at line 26 [4.3265]

Deletion in Assets/Scripts/Combat/Runes/Rune.cs at line 27 [4.3265]

Replacement in Assets/Scripts/Combat/Runes/Rune.cs at line 28 [4.3265]

Insertion in Assets/Scripts/Combat/Runes/Rune.cs at line 32 [4.3265]

Replacement in Assets/Scripts/Combat/Runes/Rune.cs at line 34 [4.3265]

Replacement in Assets/Scripts/Combat/Runes/Rune.cs at line 52 [4.3265]

Insertion in Assets/Scripts/Combat/Runes/Effects/RemoveTagsEffect.cs at line 4 [4.4675]

Insertion in Assets/Scripts/Combat/Runes/Effects/RemoveTagsEffect.cs at line 6 [4.4675]

Replacement in Assets/Scripts/Combat/Runes/Effects/RemoveTagsEffect.cs at line 9 [4.4675]

Replacement in Assets/Scripts/Combat/Runes/Effects/RemoveTagsEffect.cs at line 12 [4.4675]

Replacement in Assets/Scripts/Combat/Runes/Effects/RemoveTagsEffect.cs at line 14 [4.4675]

Insertion in Assets/Scripts/Combat/Runes/Effects/ReleaseEffect.cs at line 1 [8.2160]

Replacement in Assets/Scripts/Combat/Runes/Effects/ReleaseEffect.cs at line 8 [8.2160]

Replacement in Assets/Scripts/Combat/Runes/Effects/CountTagsImmidiateEffect.cs at line 6 [9.865]

Replacement in Assets/Scripts/Combat/Runes/Effects/CountTagsImmidiateEffect.cs at line 9 [9.865]

Replacement in Assets/Scripts/Combat/Runes/Effects/CountTagsEffect.cs at line 5 [4.7015]

Insertion in Assets/Scripts/Combat/Runes/Effects/CountTagsEffect.cs at line 7 [4.7015]

Deletion in Assets/Scripts/Combat/Runes/Effects/CountTagsEffect.cs at line 9 [4.7015]

Replacement in Assets/Scripts/Combat/Runes/Effects/ApplyTagsEffect.cs at line 7 [10.295]

Replacement in Assets/Scripts/Combat/Runes/Effects/ApplyDamageEffect.cs at line 8 [11.297]

Replacement in Assets/Scripts/Combat/Runes/Effects/AddTagsEffect.cs at line 9 [4.11362]

Replacement in Assets/Scripts/Combat/Runes/Effects/AddTagsEffect.cs at line 12 [4.11362]

Replacement in Assets/Scripts/Combat/Runes/Effects/AddTagsEffect.cs at line 14 [4.11362]

Insertion in Assets/Scripts/Combat/Runes/Effects/AccumulateDamageByTagEffect.cs at line 9 [4.12412]

Deletion in Assets/Scripts/Combat/Runes/Effects/AccumulateDamageByTagEffect.cs at line 12 [4.12412]

Insertion in Assets/Scripts/Combat/Martial/CombatMove.cs at line 1 [13.5093]

Deletion in Assets/Scripts/Combat/Martial/CombatMove.cs at line 5 [13.5093]

Replacement in Assets/ScriptableObjects/Runes/Sand.asset at line 16 [15.1041]

Insertion in Assets/ScriptableObjects/Runes/Sand.asset at line 22 [15.1041]

Replacement in Assets/ScriptableObjects/Runes/Jolt.asset at line 16 [15.2994]

Insertion in Assets/ScriptableObjects/Runes/Jolt.asset at line 22 [15.2994]

Replacement in Assets/ScriptableObjects/Runes/Flame.asset at line 16 [15.3811]

Replacement in Assets/ScriptableObjects/Runes/Flame.asset at line 19 [15.3811]

Insertion in Assets/ScriptableObjects/Runes/Flame.asset at line 22 [15.3811]

Replacement in Assets/ScriptableObjects/Runes/Double Count.asset at line 16 [18.241]