korrat/beancount-importers - Change XWHISGCP3WZJHEQXEFFGHR5JDVOD7NMRH5ZPWFVTWQPA5XJBZKNQC

Extract Amount into separate crate

Created by korrat on June 23, 2023

XWHISGCP3WZJHEQXEFFGHR5JDVOD7NMRH5ZPWFVTWQPA5XJBZKNQC

Dependencies

In channels

main

Change contents

File deletion: that.rs

BF:BFD[4.44] → [4.2426:2457]

BF:BFD[4.2457] → [4.2458:2458]

B:BD[4.3694] → [4.3694:3740]

B:BD[4.3740] → [5.3920:3974]

∅:D[5.3974] → [4.3740:3784]

B:BD[4.3740] → [4.3740:3784]

B:BD[4.3837] → [4.3837:4722]

mod amount {
    use {
        crate::Amount,
        core::{fmt::Debug, hash::Hash, str::FromStr},
        static_assertions::assert_impl_all,
        test_case::test_case,
    };
    assert_impl_all!(
        Amount: Copy,
        Debug,
        FromStr,
        Hash,
        PartialOrd,
        TryFrom<&'static str>
    );
    #[test_case("0 EUR"; "zero")]
    #[test_case("15 USD"; "integer amount")]
    #[test_case("0.30 CAD"; "fractional amount")]
    #[test_case("0.0000067 ETH"; "arbitrary precision")]
    #[test_case("-16.93 USD"; "negative amount")]
    fn parse_when_valid(amount: &str) {
        let account = Amount::try_from(amount).unwrap();
        assert_eq!(account.to_string(), amount);
    }
    #[test_case(" EUR"; "missing units")]
    #[test_case("15 "; "missing commodity")]
    #[test_case("15,000.00 USD"; "thousands separator")]
    #[test_case("15000,00 USD"; "invalid decimal separator")]
    fn do_not_parse_when_invalid(amount: &str) {
        Amount::try_from(amount).unwrap_err();
    }
}

Insertion in common/beancount-types/src/lib.rs at line 9 [4.5874]
[6.2176]
[3.1752]
```
pub use beancount_amount::Amount;
```
Deletion in common/beancount-types/src/lib.rs at line 13 [4.5874]
∅:D[7.83] → [5.4092:4123]
B:BD[5.4092] → [5.4092:4123]
```
pub use crate::amount::Amount;
```
Deletion in common/beancount-types/src/lib.rs at line 35 [4.5874]
B:BD[4.5928] → [4.5928:5940]
```
mod amount;
```
Replacement in common/beancount-types/src/lib.rs at line 55 [4.5874]
B:BD[8.11133] → [8.11133:11176]
```
            Directive::Balance(inner) => {
```
[8.11133]
[8.11176]
```
            Self::Balance(inner) => {
```
Replacement in common/beancount-types/src/lib.rs at line 58 [4.5874]
B:BD[8.11234] → [8.11234:11275]
```
            Directive::Price(inner) => {
```
[8.11234]
[8.11275]
```
            Self::Price(inner) => {
```
Replacement in common/beancount-types/src/lib.rs at line 61 [4.5874]
B:BD[8.11333] → [8.11333:11380]
```
            Directive::Transaction(inner) => {
```
[8.11333]
[8.11380]
```
            Self::Transaction(inner) => {
```
Deletion in common/beancount-types/src/lib.rs at line 136 [4.5874]
B:BD[4.7523] → [4.7523:7547]
```
#[cfg(test)]
mod that;
```
Deletion in common/beancount-types/src/cost.rs at line 1 [4.7580]
B:BD[4.7580] → [4.7581:7608]
```
use crate::amount::Amount;
```
Insertion in common/beancount-types/src/cost.rs at line 6 [4.7580]
[4.7653]
[9.7450]
```
use crate::Amount;
```
Replacement in common/beancount-types/src/account.rs at line 1 [6.1838]
B:BD[6.1838] → [6.1839:1864]
```
pub(crate) mod template;
```
[6.1838]
```
pub mod template;
```
Insertion in common/beancount-types/Cargo.toml at line 27 [4.25786]
[3.1853]
[3.1853]
```
beancount-amount.path    = "../../beancount/amount"
```
File addition: amount (d--x------)
[6.1]
File addition: tests (d--x------)
[0.1]

File addition: basic.rs (---x------)

[0.21]

use core::fmt::Debug;
use core::hash::Hash;
use core::str::FromStr;
use beancount_amount::Amount;
use static_assertions::assert_impl_all;
use test_case::test_case;
assert_impl_all!(
    Amount: Copy,
    Debug,
    FromStr,
    Hash,
    PartialOrd,
    TryFrom<&'static str>
);
#[test_case("0 EUR"; "zero")]
#[test_case("15 USD"; "integer amount")]
#[test_case("0.30 CAD"; "fractional amount")]
#[test_case("0.0000067 ETH"; "arbitrary precision")]
#[test_case("-16.93 USD"; "negative amount")]
fn parse_when_valid(amount: &str) {
    let account = Amount::try_from(amount).unwrap();
    assert_eq!(account.to_string(), amount);
}
#[test_case(" EUR"; "missing units")]
#[test_case("15 "; "missing commodity")]
#[test_case("15,000.00 USD"; "thousands separator")]
#[test_case("15000,00 USD"; "invalid decimal separator")]
fn do_not_parse_when_invalid(amount: &str) {
    Amount::try_from(amount).unwrap_err();
}

File addition: src (d--x------)
[0.1]
File move: amount.rs → lib.rs
BF:BFD[4.44] → [4.9802:9835]
BF:BF[4.9835] → [4.9836:9836]
[0.991]
[4.9836]
Insertion in beancount/amount/src/lib.rs at line 1 [4.9836]
[4.9836]
[5.6396]
```
#![warn(clippy::all, clippy::nursery, clippy::pedantic)]
```
Insertion in beancount/amount/src/lib.rs at line 19 [4.9836]
[5.6736]
[4.9859]
```
use beancount_commodity::Commodity;
use miette::Diagnostic;
```
Deletion in beancount/amount/src/lib.rs at line 25 [4.9836]
B:BD[4.9953] → [5.6737:6760]
```
use crate::Commodity;
```

Replacement in beancount/amount/src/lib.rs at line 139 [4.9836]

B:BD[10.91793401] → [10.91793401:91793465]

    pub fn new(amount: Decimal, commodity: Commodity) -> Self {

[10.91793401]

[9.7676]

    pub const fn new(amount: Decimal, commodity: Commodity) -> Self {

Replacement in beancount/amount/src/lib.rs at line 308 [4.9836]
B:BD[4.11333] → [4.11333:11357]
```
#[derive(Debug, Snafu)]
```
[4.11333]
[4.11357]
```
#[derive(Debug, Diagnostic, Snafu)]
```

File addition: Cargo.toml (---x------)

[0.1]

[package]
name = "beancount-amount"
edition.workspace      = true
publish.workspace      = true
rust-version.workspace = true
version.workspace      = true
[dependencies]
# Inherited dependencies
delegate.workspace     = true
lazy-regex.workspace   = true
miette.workspace       = true
momo.workspace         = true
rust_decimal.workspace = true
serde.workspace        = true
snafu.workspace        = true
# Workspace dependencies
beancount-commodity.workspace = true
[dev-dependencies]
static_assertions.workspace = true
test-case.workspace         = true

Insertion in Cargo.toml at line 32 [12.9831]
[11.2918]
[2.165]
```
forward_ref_generic  = "0.2.1"
```
Replacement in Cargo.toml at line 58 [12.9831]
∅:D[2.454] → [10.91793892:91793924]
B:BD[11.3449] → [10.91793892:91793924]
```
quick-xml            = "0.28.2"
```
[2.454]
[2.455]
```
quick-xml            = "0.29.0"
```

Insertion in Cargo.toml at line 119 [12.9831]

[13.1750]

## Workspace crates
[workspace.dependencies.beancount-commodity]
path = "beancount/commodity"

Insertion in Cargo.lock at line 218 [12.9916]

[14.279]

[3.2346]

name = "beancount-amount"
version = "0.0.0-dev.0"
dependencies = [
 "beancount-commodity",
 "delegate",
 "lazy-regex",
 "miette",
 "momo",
 "rust_decimal",
 "serde",
 "snafu",
 "static_assertions",
 "test-case",
]
[[package]]

Insertion in Cargo.lock at line 343 [12.9916]
[15.2353]
[3.2540]
```
 "beancount-amount",
```
Replacement in Cargo.lock at line 3081 [12.9916]
B:BD[10.91799719] → [10.91799719:91799738]
```
version = "0.28.2"
```
[10.91799719]
[10.91799738]
```
version = "0.29.0"
```

Replacement in Cargo.lock at line 3083 [12.9916]

B:BD[10.91799803] → [10.91799803:91799881]

checksum = "0ce5e73202a820a31f8a0ee32ada5e21029c81fd9e3ebf668a40832e4219d9d1"

[10.91799803]

[10.91799881]

checksum = "81b9228215d82c7b61490fec1de287136b5de6f5700f6e58ea9ad61a7964ca51"

Extract Amount into separate crate

Dependencies

In channels

Change contents

File deletion: that.rs

Insertion in common/beancount-types/src/lib.rs at line 9 [4.5874]

Deletion in common/beancount-types/src/lib.rs at line 13 [4.5874]

Deletion in common/beancount-types/src/lib.rs at line 35 [4.5874]

Replacement in common/beancount-types/src/lib.rs at line 55 [4.5874]

Replacement in common/beancount-types/src/lib.rs at line 58 [4.5874]

Replacement in common/beancount-types/src/lib.rs at line 61 [4.5874]

Deletion in common/beancount-types/src/lib.rs at line 136 [4.5874]

Deletion in common/beancount-types/src/cost.rs at line 1 [4.7580]

Insertion in common/beancount-types/src/cost.rs at line 6 [4.7580]

Replacement in common/beancount-types/src/account.rs at line 1 [6.1838]

Insertion in common/beancount-types/Cargo.toml at line 27 [4.25786]

File addition: amount (d--x------)

File addition: tests (d--x------)

File addition: basic.rs (---x------)

File addition: src (d--x------)

File move: amount.rs → lib.rs

Insertion in beancount/amount/src/lib.rs at line 1 [4.9836]

Insertion in beancount/amount/src/lib.rs at line 19 [4.9836]

Deletion in beancount/amount/src/lib.rs at line 25 [4.9836]

Replacement in beancount/amount/src/lib.rs at line 139 [4.9836]

Replacement in beancount/amount/src/lib.rs at line 308 [4.9836]

File addition: Cargo.toml (---x------)

Insertion in Cargo.toml at line 32 [12.9831]

Replacement in Cargo.toml at line 58 [12.9831]

Insertion in Cargo.toml at line 119 [12.9831]

Insertion in Cargo.lock at line 218 [12.9916]

Insertion in Cargo.lock at line 343 [12.9916]

Replacement in Cargo.lock at line 3081 [12.9916]

Replacement in Cargo.lock at line 3083 [12.9916]