pijul/pijul - Change 5U4HF4FLLJOSZJGOPYGYXKRSRDVI2II7HUCGBYKUG25Z2JF33K2AC

clippy fixes: remove pointless .clone() calls on Copy types (clippy::clone_on_copy)

Created by 3uGTfSxiPfZM9adJMcQLNHqMdb9m3ghhMAxFaFGdAmjJ on May 13, 2022

5U4HF4FLLJOSZJGOPYGYXKRSRDVI2II7HUCGBYKUG25Z2JF33K2AC

Dependencies

In discussions

#682 Another round of Clippy fixes

Change contents

Replacement in pijul/src/remote/mod.rs at line 735 [7.52474]

B:BD[4.95] → [4.95:151]

                    if to_download_.insert(h.clone()) {

[4.95]

[4.151]

                    if to_download_.insert(h) {

Replacement in pijul/src/remote/mod.rs at line 747 [7.52474]

B:BD[8.13213] → [4.219:330]

                    if to_download_.insert(ch.clone()) {
                        to_download.push(ch.clone());

[8.13213]

[4.330]

                    if to_download_.insert(ch) {
                        to_download.push(ch);

Replacement in libpijul/src/unrecord/mod.rs at line 447 [7.231493]

B:BD[5.32] → [5.32:64]

                    return true

[5.32]

[5.64]

                    return true;

Replacement in libpijul/src/tag.rs at line 98 [10.6397]
B:BD[9.1943] → [9.1943:1977]
```
        self.header.state.clone()
```
[9.1943]
[11.1736]
```
        self.header.state
```

Replacement in libpijul/src/tag.rs at line 114 [10.6397]

B:BD[8.37598] → [8.37598:37644]

            state: self.header.state.clone(),

[8.37598]

[8.37644]

            state: self.header.state,

Replacement in libpijul/src/tag.rs at line 249 [10.6397]

B:BD[10.11567] → [10.11567:11724]

            Ok((
                *k,
                Pair {
                    a: v_,
                    b: v.b.clone(),
                },
            ))

[10.11567]

[10.11724]

            Ok((*k, Pair { a: v_, b: v.b }))

Replacement in libpijul/src/tag.rs at line 258 [10.6397]

B:BD[10.11868] → [10.11868:11935]

        |_, _, k: &SerializedMerkle, v: &L64| Ok((k.clone(), *v)),

[10.11868]

[10.11935]

        |_, _, k: &SerializedMerkle, v: &L64| Ok((*k, *v)),

Replacement in libpijul/src/tag.rs at line 405 [10.6397]
B:BD[10.15714] → [12.1987:2017]
```
        state: state.clone(),
```
[10.15714]
[10.15729]
```
        state: state,
```

Replacement in libpijul/src/pristine/sanakirja.rs at line 1361 [7.531056]

B:BD[13.27022] → [14.98701:98762]

        match self.open_remotes.lock().entry(name.clone()) {

[13.27022]

[15.8251]

        match self.open_remotes.lock().entry(name) {

Replacement in libpijul/src/pristine/sanakirja.rs at line 1492 [7.531056]

B:BD[13.28104] → [14.98763:98824]

        match self.open_remotes.lock().entry(name.clone()) {

[13.28104]

[15.9588]

        match self.open_remotes.lock().entry(name) {

Replacement in libpijul/src/pristine/sanakirja.rs at line 1935 [7.531056]
B:BD[16.85876] → [16.85876:85918]
```
            &Pair { a: h, b: m.clone() },
```
[16.85876]
[16.85918]
```
            &Pair { a: h, b: m },
```
Replacement in libpijul/src/pristine/sanakirja.rs at line 1955 [7.531056]
B:BD[16.86262] → [16.86262:86297]
```
                let p = p.clone();
```
[16.86262]
[16.86297]
```
                let p = *p;
```
Replacement in libpijul/src/pristine/path_id.rs at line 42 [7.584967]
B:BD[7.585964] → [7.585964:586017]
```
            parent_inode: self.parent_inode.clone(),
```
[7.585964]
[7.586017]
```
            parent_inode: self.parent_inode,
```
Replacement in libpijul/src/pristine/mod.rs at line 252 [7.586748]
B:BD[7.588808] → [13.35416:35449]
```
            id: self.id.clone(),
```
[7.588808]
[13.35449]
```
            id: self.id,
```
Replacement in libpijul/src/pristine/mod.rs at line 2063 [7.586748]
B:BD[17.3686] → [16.111574:111621]
```
            return Ok(Some((n, m.b.clone())));
```
[17.3686]
[17.3722]
```
            return Ok(Some((n, m.b)));
```
Replacement in libpijul/src/pristine/mod.rs at line 2079 [7.586748]
B:BD[16.111755] → [16.111755:111794]
```
        Ok(Some((b, state.b.clone())))
```
[16.111755]
[17.4037]
```
        Ok(Some((b, state.b)))
```

Replacement in libpijul/src/pristine/hash.rs at line 226 [7.644439]

B:BD[16.116330] → [16.116330:116386]

            Hash::Blake3(unsafe { s.h.blake3.clone() })

[16.116330]

[16.116386]

            Hash::Blake3(unsafe { s.h.blake3 })

Replacement in libpijul/src/pristine/hash.rs at line 252 [7.644439]
B:BD[16.116960] → [16.116960:117004]
```
                h: H { blake3: s.clone() },
```
[16.116960]
[16.117004]
```
                h: H { blake3: *s },
```

Replacement in libpijul/src/key.rs at line 134 [18.5013]

B:BD[18.8892] → [18.8892:8938]

                    expires: expires.clone(),

[18.8892]

[18.8938]

                    expires: *expires,

Replacement in libpijul/src/key.rs at line 146 [18.5013]

B:BD[18.9229] → [18.9229:9330]

                    bincode::serialize(&(Algorithm::Ed25519, expires.clone(), key.public)).unwrap();

[18.9229]

[18.9330]

                    bincode::serialize(&(Algorithm::Ed25519, *expires, key.public)).unwrap();

Replacement in libpijul/src/key.rs at line 152 [18.5013]

B:BD[18.9687] → [18.9687:9733]

                    expires: expires.clone(),

[18.9687]

[2.1745]

                    expires: *expires,

Replacement in libpijul/src/key.rs at line 164 [18.5013]

B:BD[18.10091] → [18.10091:10192]

                    bincode::serialize(&(Algorithm::Ed25519, expires.clone(), key.public)).unwrap();

[18.10091]

[18.10192]

                    bincode::serialize(&(Algorithm::Ed25519, *expires, key.public)).unwrap();

Replacement in libpijul/src/key.rs at line 168 [18.5013]

B:BD[18.10464] → [18.10464:10555]

                    expires: expires.clone(),
                    key: key.public.clone(),

[18.10464]

[13.38827]

                    expires: *expires,
                    key: key.public,

Replacement in libpijul/src/key.rs at line 210 [18.5013]

B:BD[18.11735] → [18.11735:11865]

                    bincode::serialize(&(Algorithm::Ed25519, self.expires.clone(), &self.key))
                        .unwrap();

[18.11735]

[3.302]

                    bincode::serialize(&(Algorithm::Ed25519, self.expires, &self.key)).unwrap();

Replacement in libpijul/src/key.rs at line 228 [18.5013]

B:BD[18.12601] → [13.39593:39619]

∅:D[13.39619] → [18.12630:12730]

B:BD[18.12630] → [18.12630:12730]

                let msg =
                    bincode::serialize(&(Algorithm::Ed25519, self.expires.clone(), &key)).unwrap();

[18.12601]

[13.39620]

                let msg = bincode::serialize(&(Algorithm::Ed25519, self.expires, &key)).unwrap();

Replacement in libpijul/src/key.rs at line 232 [18.5013]

B:BD[18.12924] → [18.12924:12975]

                    expires: self.expires.clone(),

[18.12924]

[18.12975]

                    expires: self.expires,

Replacement in libpijul/src/key.rs at line 250 [18.5013]
B:BD[18.13334] → [18.13334:13376]
```
                expires: expires.clone(),
```
[18.13334]
[18.13376]
```
                expires: *expires,
```

Replacement in libpijul/src/key.rs at line 377 [18.5013]

B:BD[19.4102] → [19.4102:4149]

                ed25519: k.as_bytes().clone(),

[19.4102]

[19.4149]

                ed25519: *k.as_bytes(),

clippy fixes: remove pointless .clone() calls on Copy types (clippy::clone_on_copy)

Dependencies

In discussions

Change contents

Replacement in pijul/src/remote/mod.rs at line 735 [7.52474]

Replacement in pijul/src/remote/mod.rs at line 747 [7.52474]

Replacement in libpijul/src/unrecord/mod.rs at line 447 [7.231493]

Replacement in libpijul/src/tag.rs at line 98 [10.6397]

Replacement in libpijul/src/tag.rs at line 114 [10.6397]

Replacement in libpijul/src/tag.rs at line 249 [10.6397]

Replacement in libpijul/src/tag.rs at line 258 [10.6397]

Replacement in libpijul/src/tag.rs at line 405 [10.6397]

Replacement in libpijul/src/pristine/sanakirja.rs at line 1361 [7.531056]

Replacement in libpijul/src/pristine/sanakirja.rs at line 1492 [7.531056]

Replacement in libpijul/src/pristine/sanakirja.rs at line 1935 [7.531056]

Replacement in libpijul/src/pristine/sanakirja.rs at line 1955 [7.531056]

Replacement in libpijul/src/pristine/path_id.rs at line 42 [7.584967]

Replacement in libpijul/src/pristine/mod.rs at line 252 [7.586748]

Replacement in libpijul/src/pristine/mod.rs at line 2063 [7.586748]

Replacement in libpijul/src/pristine/mod.rs at line 2079 [7.586748]