Resubmitting this after the Nest ate the last one.

I’ve run cargo clippy --fix on everything, split into changes by lint type of ease of review. Some of the changes have dependencies (both Pijul-level and in some cases semantic) on each other - if you need me to redo a change with another change unrecorded so you can merge them separately, I can do that.

For Clippy fixes you’ve previously disagreed with, I’ve added #[allow(clippy::foo)] annotations so we won’t get warnings in the future.

Hi! Thanks for these patches. I’m usually a bit reluctant to applying patches from Clippy, since (1) I’m not confident enough that they never change the semantics and (2) I strongly disagree with a significant portion of Clippy’s definition of the “right” style, which I often find less readable than my own.

I always thought that Clippy’s best use was to experiment with warnings and possibly integrate them into Rustc in the future.

In this particular case, I don’t mind reviewing some of them, but you should add #IUH7IMWES3KQTHVWA5UNHAO7QWVCC5PQJ6VLK3RC3T4F2MS74P3AC to the ones that touch libpijul, which is Pijul’s way of saying that you read the CLA.

Apologies for the giant patch dump - in retrospect it may have been less than helpful.

I strongly disagree with a significant portion of Clippy’s definition of the “right” style, which I often find less readable than my own

Yeah, Clippy does have some questionable lints.

I’ve found enough of them are useful that it’s worth the time to keep cargo clippy happy (either by fixing the code or disabling lints), but it’s entirely reasonable to disagree.

In this particular case, I don’t mind reviewing some of them, but you should add #IUH7IMWES3KQTHVWA5UNHAO7QWVCC5PQJ6VLK3RC3T4F2MS74P3AC to the ones that touch libpijul, which is Pijul’s way of saying that you read the CLA.

I thought I did! Did I miss one?

I thought I did! Did I miss one?

Some do have it, others don’t. This could also be an error with the dependency minimisation algorithm. I’ll try to reproduce.

Don’t try too hard, it may well have been human error - if I recall correctly, my process for the dependency where necessary was rather haphazard.

In any case, it’s in my extra-dependencies now - I think I added it halfway through putting those patches together.

I’ll see about adding the rest now.