#682 Another round of Clippy fixes
IKFZAKEUYS4IYV7EUM4SPRDSHRD7GTU75SLXIWOD4SYIFVIKOTCAC PMX7YELD2PU2EJAN5NFFN3JVF6AYTHR3UY6ASV6O2NAEARN35WKAC HNYCPLU74ZXH5HAADKRMAZADRCNWID3QAIEAFHCEMW2JJOIMABBQC AUMJCJPJYQZCM5FMSIBYS3EJXRAUXEB2TT44YYGBV5WNWQNQHYMAC FUOR67YOW2MF3XA7H7BQRG6B5ALETTW3BRWHH7RU4R52I334DZFAC J4YWT5MHZ4FCOW563RSGDXWQCAVQGO7Y3D5MCGUMFAW2CA64FLFAC JCKZJCIC6HWVEAXYASJN4ZJ3K5O6QS5REYURE55BRDX7IYRYC5RQC DCBFQWI23QZEZXF5GU2OUR2CWHV5W2VROSWJHGT3Q63DXF4T5LGAC BN5KOJ67UJGQH2MTGD322EUKETDY6272HCKK3NLEOWJCA2AB5NPAC X3YFRLLDYR6A7X4L55ZXZ7U7MXARVKBLAVDL7XP6XXIDM6DO4D5AC JY2BWSXXRBJTTZCTMDDZSZPLJSM22SHM74JBHSJFVNRQUVZS65IAC QMEV3YYYTIBQ7WDK3U455WERKSZZSPQY5NWQE4I3TKU4YBHTEQUQC 6WOV6SMESUKCD6NUWU5EFCJX3QMDQNT44X5C5ZL67QTNZOW5MFOAC UGQUX4O7SEL7H67WL5ZYDRTWQLH3QHBX6JB7FNMXT5MK24EIC54QC YYEXUQCYK2O4YKSZXHRSXI54WDRFXPW4VB2RXPKIL5IQ3E3G22LAC MWFLXI2YKXQKF5PTW3B7AMJD4VTTZWGQ6WPPT2PVNHMPQSCFZFXAC P74WM2ADE6IAQP5ZZP3OTFYW6CSIUJOD2RQMA55JVF6GOUACAYCQC EGG3V3546GN3MYXAJQOE26JRN277BHIUO2SGWV6LGEJOSKI2VGKQC CPTY5O5I45PIWQ67M6J2VI67NLE6U4WMR7UV6PWUKRQKJ5YQAFZAC XBHCMTAJYPP7US5ZMPPVQUGJMZGZPA67N57ZD7DRADWZDBICWSYAC QLU6V3BSX63NM3JDKKFESDTPP3CETSN64AUQ7K3UZTMCYYCQV3SAC 5U4HF4FLLJOSZJGOPYGYXKRSRDVI2II7HUCGBYKUG25Z2JF33K2AC 4KY4D5BPKWB4RIP6HKDQPO2NZMYLTJUYOEQM2J5MMEDUDCZNETWAC 4OFXTS6JFJODK3FH4LSIYL7BOHBFZIL2DE3ADB5DEXF6IRXQLDJQC MIDW4ETVSENPHKSWRM6PWCV42PF2K7WGRGBNWLR4WSZIG5INQGFQC QZ6GQGRHJ7RVHDMSXOZZCASN3LXJD7KRYV5RAWJ243DUOUW5QUCAC GENK254EFWM4PQ4Q74QSPKCUHIY5W66HBVPA6BDKDWNIAM7T6PFQC F4HY7B5HXUHNF6A7SYQIB2ZKPJX7SI7JYQBHJQK6VWUNFKBWL5DQC MFELKINPWWZ34GTAYHBWWIVYV6TCIWP4ISX4KHS5JDY24AJEGKCQC EAQE6QLHXR3VYRBJTKJJ4QD774RMSHX6EGRBFZISXBDREX7XN5TAC SKGTRN5EMUBCXEOBI3QDF42YO4PQGXIMENCDDXZEPZNBLD5Z6EUAC N7QIZMCZFGNNHYFNAH57TB3MVT3OMXG6NHW4BWEY6I3C32ARHUZQC XJ6TOZXMBIWKG6RRPRXW4VCEMRQFFTFC755TOPYWBLTEGHWO4JRQC 
pmeunier on February 22, 2023 Hi! Thanks for these patches. I’m usually a bit reluctant to applying patches from Clippy, since (1) I’m not confident enough that they never change the semantics and (2) I strongly disagree with a significant portion of Clippy’s definition of the “right” style, which I often find less readable than my own.
I always thought that Clippy’s best use was to experiment with warnings and possibly integrate them into Rustc in the future.
In this particular case, I don’t mind reviewing some of them, but you should add #IUH7IMWES3KQTHVWA5UNHAO7QWVCC5PQJ6VLK3RC3T4F2MS74P3AC to the ones that touch libpijul, which is Pijul’s way of saying that you read the CLA.
Gaelan on February 22, 2023 Apologies for the giant patch dump - in retrospect it may have been less than helpful.
I strongly disagree with a significant portion of Clippy’s definition of the “right” style, which I often find less readable than my own
Yeah, Clippy does have some questionable lints.
I’ve found enough of them are useful that it’s worth the time to keep cargo clippy happy (either by fixing the code or disabling lints), but it’s entirely reasonable to disagree.
In this particular case, I don’t mind reviewing some of them, but you should add #IUH7IMWES3KQTHVWA5UNHAO7QWVCC5PQJ6VLK3RC3T4F2MS74P3AC to the ones that touch libpijul, which is Pijul’s way of saying that you read the CLA.
I thought I did! Did I miss one?
pmeunier on February 22, 2023 I thought I did! Did I miss one?
Some do have it, others don’t. This could also be an error with the dependency minimisation algorithm. I’ll try to reproduce.
Gaelan on February 22, 2023 Don’t try too hard, it may well have been human error - if I recall correctly, my process for the dependency where necessary was rather haphazard.
In any case, it’s in my extra-dependencies now - I think I added it halfway through putting those patches together.
I’ll see about adding the rest now.
Resubmitting this after the Nest ate the last one.
I’ve run
cargo clippy --fixon everything, split into changes by lint type of ease of review. Some of the changes have dependencies (both Pijul-level and in some cases semantic) on each other - if you need me to redo a change with another change unrecorded so you can merge them separately, I can do that.For Clippy fixes you’ve previously disagreed with, I’ve added
#[allow(clippy::foo)]annotations so we won’t get warnings in the future.