The Nest
Explore
399
The sound distributed version control system

#257 pijul-clone: avoid panics on parsing remote URLs

Closed on January 13, 2021
ubnt-intrepid on January 12, 2021

It prevents to cause panics when an invalid value is specified as remote URL, such as:

$ pijul clone https://nest.pijul.com:pijul/thrussh
ubnt-intrepid added a change on January 12, 2021
pijul-clone: avoid panics on parsing remote URLs
GYPTNCVCXL46ZZ5QDQJKP6E2LH5G4PZBPH3RSL76L6N6CFG45MCAC
tankf33der on January 12, 2021

I need more: $ pijul clone https://nest.pijul.com::tankf33der

crash report - http://ix.io/2LPP

pmeunier added a change on January 13, 2021
pijul-clone: avoid panics on parsing remote URLs by ubnt-intrepid, created on January 12, 2021
5XMUEZMZXQ4T4HGZAGBZWT5YKEXOA7IWLZBSREWBHXLMGHXOFXZAC
main
pmeunier on January 13, 2021

@ubnt-intrepid: good work, thanks! I amended your change after running cargo fmt, you might want to add the following lines to .pijul/config:

[hooks]
record = [ "cargo fmt" ]
pmeunier closed this discussion on January 13, 2021
tankf33der on January 13, 2021

Does my crash fixed too? :/

pmeunier on January 13, 2021

Yes, I can’t reproduce it, after this patch plus the ones in #260 (I believe this patch fixed it).