{"header":{"message":"cryptovec/encoding: checked size arithmetic and overflow-safe reader bounds","description":"- cryptovec: use checked addition for size arithmetic in read (returns an error), resize (checked_next_power_of_two), extend, resize_mut, and an overflow-safe bound in read_u32_be. Prevents a wrapped length from producing an out-of-bounds slice / bad allocation. Not reachable from current callers, but the public API is now sound.\n- encoding.rs: Position::read_string/read_mpint/read_u32/read_byte compute their bound with checked_add, closing a position+len wraparound on 32-bit targets.","timestamp":"2026-08-21T06:46:31.824003946Z","authors":[{}]},"hash":"3H3VGRVD7LAYYO4CBYEGXWJSEDOJBN7Y5M64ACRG2LK5AIYGXCTQC","authors":[{"login":"pmeunier","key":"AAAAC3NzaC1lZDI1NTE5AAAAILagOJFgwaMNhBWQINinKOXmqS4Gh5NgxgriXwdOoINJ"}],"deps":{"hashes":[["3H3VGRVD7LAYYO4CBYEGXWJSEDOJBN7Y5M64ACRG2LK5AIYGXCTQC","cryptovec/encoding: checked size arithmetic and overflow-safe reader bounds"],["AA",null],["7FRJYUI62VW257VVFQXND6OKSAILVTHGEJCXFE6CG6FIOIUTDVYAC","Reboot because of a bad change"],["UHAEQPZUODJ5YVBZJPPJVLO7EBW6DC2JXHQBN26ARELAVULG3JUQC","Support ecdsa-sha2-nistp256 keys for authentication"],["LYRZREY75IOPQJ3DMJJB4SINAEVI5P5TE32SSFO7QKFBDYVXXKNAC","Adding support for MACs and AES in CTR mode"],["JP6IRUAKOPQZFM4TDSJXZ7PEIR2GHJJAXPTBMVDVQCKFEKGVSWJAC","thrussh-keys: bound key/signature parsing and harden agent inputs"]],"deps":["7FRJYUI62VW257VVFQXND6OKSAILVTHGEJCXFE6CG6FIOIUTDVYAC"],"known":["UHAEQPZUODJ5YVBZJPPJVLO7EBW6DC2JXHQBN26ARELAVULG3JUQC","LYRZREY75IOPQJ3DMJJB4SINAEVI5P5TE32SSFO7QKFBDYVXXKNAC","JP6IRUAKOPQZFM4TDSJXZ7PEIR2GHJJAXPTBMVDVQCKFEKGVSWJAC"]},"hunks":[{"Replacement":{"inode":{"change":2,"pos":427990},"path":"cryptovec/src/lib.rs","line":247,"ins":{"up_context":[{"change":2,"pos":434960}],"down_context":[{"change":2,"pos":435022}],"flag":"BLOCK","start":3,"end":160,"inode":{"change":2,"pos":427990}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":434960},"to":{"change":2,"start":434960,"end":435022},"introduced_by":2}],"inode":{"change":2,"pos":427990}},"ins_contents":[{"Add":{"text":" let next_capacity = size","pos":"3H3VGRVD7LAYYO4CBYEGXWJSEDOJBN7Y5M64ACRG2LK5AIYGXCTQC:43"}},{"Add":{"text":" .checked_next_power_of_two()","pos":"3H3VGRVD7LAYYO4CBYEGXWJSEDOJBN7Y5M64ACRG2LK5AIYGXCTQC:92"}},{"Add":{"text":" .expect(\"CryptoVec allocation size overflow\");","pos":"3H3VGRVD7LAYYO4CBYEGXWJSEDOJBN7Y5M64ACRG2LK5AIYGXCTQC:159"}}],"del_contents":[{"Del":{"text":" let next_capacity = size.next_power_of_two();","pos":"7FRJYUI62VW257VVFQXND6OKSAILVTHGEJCXFE6CG6FIOIUTDVYAC:435021"}}]}},{"Replacement":{"inode":{"change":2,"pos":427990},"path":"cryptovec/src/lib.rs","line":317,"ins":{"up_context":[{"change":2,"pos":437263}],"down_context":[{"change":2,"pos":437300}],"flag":"BLOCK","start":161,"end":216,"inode":{"change":2,"pos":427990}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":437263},"to":{"change":2,"start":437263,"end":437300},"introduced_by":2}],"inode":{"change":2,"pos":427990}},"ins_contents":[{"Add":{"text":" assert!(i <= self.size && self.size - i >= 4);","pos":"3H3VGRVD7LAYYO4CBYEGXWJSEDOJBN7Y5M64ACRG2LK5AIYGXCTQC:215"}}],"del_contents":[{"Del":{"text":" assert!(i + 4 <= self.size);","pos":"7FRJYUI62VW257VVFQXND6OKSAILVTHGEJCXFE6CG6FIOIUTDVYAC:437299"}}]}},{"Replacement":{"inode":{"change":2,"pos":427990},"path":"cryptovec/src/lib.rs","line":337,"ins":{"up_context":[{"change":2,"pos":437868}],"down_context":[{"change":2,"pos":437909}],"flag":"BLOCK","start":217,"end":476,"inode":{"change":2,"pos":427990}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":437868},"to":{"change":2,"start":437868,"end":437909},"introduced_by":2}],"inode":{"change":2,"pos":427990}},"ins_contents":[{"Add":{"text":" let new_size = cur_size.checked_add(n_bytes).ok_or_else(|| {","pos":"3H3VGRVD7LAYYO4CBYEGXWJSEDOJBN7Y5M64ACRG2LK5AIYGXCTQC:285"}},{"Add":{"text":" std::io::Error::new(","pos":"3H3VGRVD7LAYYO4CBYEGXWJSEDOJBN7Y5M64ACRG2LK5AIYGXCTQC:318"}},{"Add":{"text":" std::io::ErrorKind::InvalidInput,","pos":"3H3VGRVD7LAYYO4CBYEGXWJSEDOJBN7Y5M64ACRG2LK5AIYGXCTQC:368"}},{"Add":{"text":" \"CryptoVec::read size overflow\",","pos":"3H3VGRVD7LAYYO4CBYEGXWJSEDOJBN7Y5M64ACRG2LK5AIYGXCTQC:417"}},{"Add":{"text":" )","pos":"3H3VGRVD7LAYYO4CBYEGXWJSEDOJBN7Y5M64ACRG2LK5AIYGXCTQC:431"}},{"Add":{"text":" })?;","pos":"3H3VGRVD7LAYYO4CBYEGXWJSEDOJBN7Y5M64ACRG2LK5AIYGXCTQC:444"}},{"Add":{"text":" self.resize(new_size);","pos":"3H3VGRVD7LAYYO4CBYEGXWJSEDOJBN7Y5M64ACRG2LK5AIYGXCTQC:475"}}],"del_contents":[{"Del":{"text":" self.resize(cur_size + n_bytes);","pos":"7FRJYUI62VW257VVFQXND6OKSAILVTHGEJCXFE6CG6FIOIUTDVYAC:437908"}}]}},{"Replacement":{"inode":{"change":2,"pos":427990},"path":"cryptovec/src/lib.rs","line":389,"ins":{"up_context":[{"change":2,"pos":439324}],"down_context":[{"change":2,"pos":439355}],"flag":"BLOCK","start":477,"end":553,"inode":{"change":2,"pos":427990}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":439324},"to":{"change":2,"start":439324,"end":439355},"introduced_by":2}],"inode":{"change":2,"pos":427990}},"ins_contents":[{"Add":{"text":" self.resize(size.checked_add(n).expect(\"CryptoVec size overflow\"));","pos":"3H3VGRVD7LAYYO4CBYEGXWJSEDOJBN7Y5M64ACRG2LK5AIYGXCTQC:552"}}],"del_contents":[{"Del":{"text":" self.resize(size + n);","pos":"7FRJYUI62VW257VVFQXND6OKSAILVTHGEJCXFE6CG6FIOIUTDVYAC:439354"}}]}},{"Replacement":{"inode":{"change":2,"pos":427990},"path":"cryptovec/src/lib.rs","line":401,"ins":{"up_context":[{"change":2,"pos":439677}],"down_context":[{"change":2,"pos":439714}],"flag":"BLOCK","start":554,"end":636,"inode":{"change":2,"pos":427990}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":439677},"to":{"change":2,"start":439677,"end":439714},"introduced_by":2}],"inode":{"change":2,"pos":427990}},"ins_contents":[{"Add":{"text":" self.resize(size.checked_add(s.len()).expect(\"CryptoVec size overflow\"));","pos":"3H3VGRVD7LAYYO4CBYEGXWJSEDOJBN7Y5M64ACRG2LK5AIYGXCTQC:635"}}],"del_contents":[{"Del":{"text":" self.resize(size + s.len());","pos":"7FRJYUI62VW257VVFQXND6OKSAILVTHGEJCXFE6CG6FIOIUTDVYAC:439713"}}]}},{"Replacement":{"inode":{"change":2,"pos":96067},"path":"ssh-keys/src/encoding.rs","line":202,"ins":{"up_context":[{"change":2,"pos":101502}],"down_context":[{"change":2,"pos":101551}],"flag":"BLOCK","start":640,"end":725,"inode":{"change":2,"pos":96067}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":101502},"to":{"change":2,"start":101502,"end":101551},"introduced_by":2}],"inode":{"change":2,"pos":96067}},"ins_contents":[{"Add":{"text":" if self.position.checked_add(len).map_or(false, |end| end <= self.s.len()) {","pos":"3H3VGRVD7LAYYO4CBYEGXWJSEDOJBN7Y5M64ACRG2LK5AIYGXCTQC:724"}}],"del_contents":[{"Del":{"text":" if self.position + len <= self.s.len() {","pos":"7FRJYUI62VW257VVFQXND6OKSAILVTHGEJCXFE6CG6FIOIUTDVYAC:101550"}}]}},{"Replacement":{"inode":{"change":2,"pos":96067},"path":"ssh-keys/src/encoding.rs","line":212,"ins":{"up_context":[{"change":2,"pos":101848}],"down_context":[{"change":2,"pos":101895}],"flag":"BLOCK","start":726,"end":809,"inode":{"change":2,"pos":96067}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":101848},"to":{"change":2,"start":101848,"end":101895},"introduced_by":2}],"inode":{"change":2,"pos":96067}},"ins_contents":[{"Add":{"text":" if self.position.checked_add(4).map_or(false, |end| end <= self.s.len()) {","pos":"3H3VGRVD7LAYYO4CBYEGXWJSEDOJBN7Y5M64ACRG2LK5AIYGXCTQC:808"}}],"del_contents":[{"Del":{"text":" if self.position + 4 <= self.s.len() {","pos":"7FRJYUI62VW257VVFQXND6OKSAILVTHGEJCXFE6CG6FIOIUTDVYAC:101894"}}]}},{"Replacement":{"inode":{"change":2,"pos":96067},"path":"ssh-keys/src/encoding.rs","line":222,"ins":{"up_context":[{"change":2,"pos":102181}],"down_context":[{"change":2,"pos":102228}],"flag":"BLOCK","start":810,"end":893,"inode":{"change":2,"pos":96067}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":102181},"to":{"change":2,"start":102181,"end":102228},"introduced_by":2}],"inode":{"change":2,"pos":96067}},"ins_contents":[{"Add":{"text":" if self.position.checked_add(1).map_or(false, |end| end <= self.s.len()) {","pos":"3H3VGRVD7LAYYO4CBYEGXWJSEDOJBN7Y5M64ACRG2LK5AIYGXCTQC:892"}}],"del_contents":[{"Del":{"text":" if self.position + 1 <= self.s.len() {","pos":"7FRJYUI62VW257VVFQXND6OKSAILVTHGEJCXFE6CG6FIOIUTDVYAC:102227"}}]}},{"Replacement":{"inode":{"change":2,"pos":96067},"path":"ssh-keys/src/encoding.rs","line":234,"ins":{"up_context":[{"change":2,"pos":102543}],"down_context":[{"change":2,"pos":102592}],"flag":"BLOCK","start":894,"end":979,"inode":{"change":2,"pos":96067}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":102543},"to":{"change":2,"start":102543,"end":102592},"introduced_by":2}],"inode":{"change":2,"pos":96067}},"ins_contents":[{"Add":{"text":" if self.position.checked_add(len).map_or(false, |end| end <= self.s.len()) {","pos":"3H3VGRVD7LAYYO4CBYEGXWJSEDOJBN7Y5M64ACRG2LK5AIYGXCTQC:978"}}],"del_contents":[{"Del":{"text":" if self.position + len <= self.s.len() {","pos":"7FRJYUI62VW257VVFQXND6OKSAILVTHGEJCXFE6CG6FIOIUTDVYAC:102591"}}]}}],"owner":"pijul","repo":"thrussh","token":"HpnuByAhvsGfBJmxzn4FFgrMRB8uuUvMlCmrxqB2jMY=","login":null}

…

Dependencies

Change contents

Review