Pure-Rust asynchronous SSH library, both client and server

#30 AgentClient::sign_request_signature should return self on error

Closed on March 27, 2021
kim on March 25, 2021

Matching the signatures of sign_request and sign_request_base64, this would greatly improve handling errors, as the socket itself is usually still good to use.

kim on March 25, 2021

Hm ok, I have a patch for this, but can’t seem to submit it (either connection reset or refused). Guess I’ll have to wait a bit until the nest becomes more stable?

kim added a change on March 25, 2021
NLPZS76WC64DN5RQEOB45KWXUSEP4VJOVEBR6OMCMFX4MYIOMKSAC
main
pmeunier on March 27, 2021

It seems you found a way! Thanks.

Sorry about the whole fire incident. I’m working on a high-availability strategy for this website. As long as there isn’t any major incident of that kind in the next few days, such an outage should never happen again.

pmeunier closed this discussion on March 27, 2021
kim on March 27, 2021

Thanks @pmeunier, and sorry about the hassle the fire caused you. Perhaps some day pijul will allow to send patches via email as a backup ;)

I realise that the patch shows a lot of seemingly unrelated changes (file permissions?). Is that normal these days, or did I do something wrong?

pmeunier on March 27, 2021

Perhaps some day pijul will allow to send patches via email as a backup ;)

It’s already possible, actually! You can send the binary patch as an attachment, or do pijul change $HASH_PREFIX and send the resulting text.

I realise that the patch shows a lot of seemingly unrelated changes (file permissions?). Is that normal these days, or did I do something wrong?

This is due to a security fix introduced recently, where we don’t record all permissions anymore, just the executable bit. This repository hadn’t had its permissions fixed, and your patch fixed them. Since this is fixed this won’t happen again on this repository.