I’ve attached a failing test case.
I believe @Robin_Jadoul could be interested.
LLGVFVFCZMGNQCOQ5SPR5W7TG4ZB432ET6YJRWXNJL2CCUVAH6RAC
Thanks for finding this, I could correctly connect to an ssh server with a p256 key, so I thought it’d be fine, but there’s some code duplication or overlapping functionality (e.g. PublicKey::parse
vs parse_public_key
), leading to this particular function not being exercised properly.
Should be fixed with the above change
Fixed and published, thank you both!
thrussh_keys::parse_public_key_base64 fails to parse a P256 key with the error:
Err
value: CouldNotReadKey’, thrussh-keys/src/lib.rs:522:10This seems to be after parsing the base64 data, due to some length mismatch.