pijul/zstd-seekable - Change 2T5FQPPAY43APQPUMLXCUIT2VOCMDNYZ26OHSGNEZR3KWWXJXXXQC

make_seekable was dereferencing a null pointer

Created by pmeunier on August 5, 2021

2T5FQPPAY43APQPUMLXCUIT2VOCMDNYZ26OHSGNEZR3KWWXJXXXQC

Dependencies

In channels

main

In discussions

#5 Oxidizing C files

Change contents

Replacement in src/lib.rs at line 487 [4.241245]

B:BD[3.464] → [3.464:543]

        let mut seekable = Self::make_seekable(source, ptr::null_mut(), size);

[3.464]

[5.3587]

        let mut seekable = Self::make_seekable(source, size)?;

Replacement in src/lib.rs at line 493 [4.241245]

∅:D[3.642] → [6.1055:1146]

B:BD[5.3650] → [6.1055:1146]

∅:D[7.277] → [8.8948:8967]

∅:D[6.1146] → [8.8948:8967]

B:BD[8.8948] → [8.8948:8967]

    fn make_seekable(source: R, dstream: *mut ZSTD_DStream, size: Option<usize>) -> Self {
        Seekable {

[3.642]

[8.8967]

    fn make_seekable(source: R, size: Option<usize>) -> Result<Self, Error> {
        let dstream = unsafe { ZSTD_createDStream() };
        if dstream.is_null() {
            return Err(Error::Null);
        }
        Ok(Seekable {

Replacement in src/lib.rs at line 511 [4.241245]
∅:D[2.235] → [4.251995:252005]
∅:D[8.9506] → [4.251995:252005]
B:BD[4.251995] → [4.251995:252005]
```
        }
```
[2.235]
[4.252005]
```
        })
```
Deletion in src/lib.rs at line 778 [4.241245]
B:BD[8.17537] → [8.17537:17660]
∅:D[8.17660] → [4.255545:255555]
B:BD[4.255545] → [4.255545:255555]
B:BD[4.255555] → [8.17661:17662]
```
        let dstream = unsafe { ZSTD_createDStream() };
        if dstream.is_null() {
            return Err(Error::Null);
        }
```

Replacement in src/lib.rs at line 780 [4.241245]

B:BD[7.645] → [6.3506:3587]

        let mut seekable = Seekable::make_seekable(source, dstream, Some(size));

[7.645]

[8.17785]

        let mut seekable = Seekable::make_seekable(source, Some(size))?;

Replacement in src/lib.rs at line 790 [4.241245]

B:BD[7.846] → [6.3588:3671]

        let mut seekable = Seekable::make_seekable(source, ptr::null_mut(), None);

[7.846]

[8.18635]

        let mut seekable = Seekable::make_seekable(source, None)?;