Discussion related to convert C files to Rust, see Zulip thread.

I just tested in more real conditions (an extension of Sanakirja, soon to be integrated into Pijul), and found a segfault.

Oh boy, isn’t that fun?! Would it be possible to add some minimum code to reproduce these segfaults as tests?

Oh boy, isn’t that fun?

This is really fun, and also totally expected! Don’t worry, I don’t think there are too many different execution paths in that library, so testing won’t be hard. Have you tried using coverage measurements?

Another question I had was, I’d like to wrap this up and use it directly in Pijul, do you plan to add more stuff, or is it ready to test?

Have you tried using coverage measurements?

No, I haven’t!

… do you plan to add more stuff, or is it ready to test?

It should be good to go, since I translated everything including the new things from the reference implementation, which we should always keep an eye on (perhaps stating on the repo’s README?). What we could do after testing and whatnot is improve performance, but that’s not required.

Thanks! I’m closing this discussion just to mean that it is solved, feel free to continue pushing/discussing.